* [PATCH] media: imx-jpeg: Disable useless interrupt to avoid kernel panic
@ 2022-08-04 9:38 Ming Qian
2022-08-17 21:24 ` Mirela Rabulea
0 siblings, 1 reply; 2+ messages in thread
From: Ming Qian @ 2022-08-04 9:38 UTC (permalink / raw)
To: mchehab, mirela.rabulea, hverkuil-cisco
Cc: shawnguo, s.hauer, kernel, festevam, xiahong.bao, linux-imx,
linux-media, linux-kernel, devicetree, linux-arm-kernel
There is a hardware bug that the interrupt STMBUF_HALF may be triggered
after or when disable interrupt.
It may led to unexpected kernel panic.
And interrupt STMBUF_HALF and STMBUF_RTND have no other effect.
So disable them and the unused interrupts.
meanwhile clear the interrupt status when disable interrupt.
Signed-off-by: Ming Qian <ming.qian@nxp.com>
---
drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
index 9418fcf740a8..ef28122a5ed4 100644
--- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
+++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
@@ -76,12 +76,14 @@ void print_wrapper_info(struct device *dev, void __iomem *reg)
void mxc_jpeg_enable_irq(void __iomem *reg, int slot)
{
- writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
+ writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_STATUS));
+ writel(0xF0C, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
}
void mxc_jpeg_disable_irq(void __iomem *reg, int slot)
{
writel(0x0, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
+ writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_STATUS));
}
void mxc_jpeg_sw_reset(void __iomem *reg)
--
2.37.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: imx-jpeg: Disable useless interrupt to avoid kernel panic
2022-08-04 9:38 [PATCH] media: imx-jpeg: Disable useless interrupt to avoid kernel panic Ming Qian
@ 2022-08-17 21:24 ` Mirela Rabulea
0 siblings, 0 replies; 2+ messages in thread
From: Mirela Rabulea @ 2022-08-17 21:24 UTC (permalink / raw)
To: mchehab, Ming Qian, Mirela Rabulea (OSS), hverkuil-cisco
Cc: linux-media, kernel, dl-linux-imx, s.hauer, festevam, X.H. Bao,
shawnguo, linux-kernel, linux-arm-kernel, devicetree
On Thu, 2022-08-04 at 17:38 +0800, Ming Qian wrote:
> There is a hardware bug that the interrupt STMBUF_HALF may be
> triggered
> after or when disable interrupt.
> It may led to unexpected kernel panic.
> And interrupt STMBUF_HALF and STMBUF_RTND have no other effect.
> So disable them and the unused interrupts.
>
> meanwhile clear the interrupt status when disable interrupt.
>
> Signed-off-by: Ming Qian <ming.qian@nxp.com>
Reviewed-by: Mirela Rabulea <mirela.rabulea@nxp.com>
> ---
> drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
> b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
> index 9418fcf740a8..ef28122a5ed4 100644
> --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
> +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
> @@ -76,12 +76,14 @@ void print_wrapper_info(struct device *dev, void
> __iomem *reg)
>
> void mxc_jpeg_enable_irq(void __iomem *reg, int slot)
> {
> - writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
> + writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_STATUS));
> + writel(0xF0C, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
> }
>
> void mxc_jpeg_disable_irq(void __iomem *reg, int slot)
> {
> writel(0x0, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
> + writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_STATUS));
> }
>
> void mxc_jpeg_sw_reset(void __iomem *reg)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-17 21:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-04 9:38 [PATCH] media: imx-jpeg: Disable useless interrupt to avoid kernel panic Ming Qian
2022-08-17 21:24 ` Mirela Rabulea
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).