* [PATCH] scsi: initio: remove redundant assignment to pointer scb
@ 2022-08-05 11:41 Colin Ian King
2022-08-23 3:43 ` Martin K. Petersen
2022-09-01 5:12 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2022-08-05 11:41 UTC (permalink / raw)
To: James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
The variable scb is assigned a value but it is never read. The assignment
is redundant and can be removed. Also replace the != NULL check with the
more usual non-null check idiom.
Cleans up clang scan build warning:
drivers/scsi/initio.c:1169:9: warning: Although the value stored to 'scb'
is used in the enclosing expression, the value is never actually read
from 'scb' [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/scsi/initio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c
index f585d6e5fab9..375261d67619 100644
--- a/drivers/scsi/initio.c
+++ b/drivers/scsi/initio.c
@@ -1166,7 +1166,7 @@ static void tulip_scsi(struct initio_host * host)
return;
}
if (host->jsint & (TSS_FUNC_COMP | TSS_BUS_SERV)) { /* func complete or Bus service */
- if ((scb = host->active) != NULL)
+ if (host->active)
initio_next_state(host);
return;
}
--
2.35.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: initio: remove redundant assignment to pointer scb
2022-08-05 11:41 [PATCH] scsi: initio: remove redundant assignment to pointer scb Colin Ian King
@ 2022-08-23 3:43 ` Martin K. Petersen
2022-09-01 5:12 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-08-23 3:43 UTC (permalink / raw)
To: Colin Ian King
Cc: James E . J . Bottomley, Martin K . Petersen, linux-scsi,
kernel-janitors, linux-kernel
Colin,
> The variable scb is assigned a value but it is never read. The assignment
> is redundant and can be removed. Also replace the != NULL check with the
> more usual non-null check idiom.
Applied to 6.1/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: initio: remove redundant assignment to pointer scb
2022-08-05 11:41 [PATCH] scsi: initio: remove redundant assignment to pointer scb Colin Ian King
2022-08-23 3:43 ` Martin K. Petersen
@ 2022-09-01 5:12 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-09-01 5:12 UTC (permalink / raw)
To: Colin Ian King, linux-scsi, James E . J . Bottomley
Cc: Martin K . Petersen, linux-kernel, kernel-janitors
On Fri, 5 Aug 2022 12:41:00 +0100, Colin Ian King wrote:
> The variable scb is assigned a value but it is never read. The assignment
> is redundant and can be removed. Also replace the != NULL check with the
> more usual non-null check idiom.
>
> Cleans up clang scan build warning:
> drivers/scsi/initio.c:1169:9: warning: Although the value stored to 'scb'
> is used in the enclosing expression, the value is never actually read
> from 'scb' [deadcode.DeadStores]
>
> [...]
Applied to 6.1/scsi-queue, thanks!
[1/1] scsi: initio: remove redundant assignment to pointer scb
https://git.kernel.org/mkp/scsi/c/3fa5975b07e9
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-01 5:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-05 11:41 [PATCH] scsi: initio: remove redundant assignment to pointer scb Colin Ian King
2022-08-23 3:43 ` Martin K. Petersen
2022-09-01 5:12 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).