* [PATCH 0/2] Fix some typos in SC8180X pinctrl driver
@ 2022-08-07 12:26 Molly Sophia
2022-08-07 12:26 ` [PATCH 1/2] pinctrl: qcom: sc8180x: Fix gpio_wakeirq_map Molly Sophia
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Molly Sophia @ 2022-08-07 12:26 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross, Konrad Dybcio, Linus Walleij,
linux-arm-msm, linux-gpio, linux-kernel
Cc: Molly Sophia
There are some little mistakes in the sc8180x pinctrl
driver. The following patches fix them.
Molly Sophia (2):
pinctrl: qcom: sc8180x: Fix gpio_wakeirq_map
pinctrl: qcom: sc8180x: Fix wrong pin numbers
drivers/pinctrl/qcom/pinctrl-sc8180x.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] pinctrl: qcom: sc8180x: Fix gpio_wakeirq_map
2022-08-07 12:26 [PATCH 0/2] Fix some typos in SC8180X pinctrl driver Molly Sophia
@ 2022-08-07 12:26 ` Molly Sophia
2022-08-08 4:19 ` Bjorn Andersson
2022-08-07 12:26 ` [PATCH 2/2] pinctrl: qcom: sc8180x: Fix wrong pin numbers Molly Sophia
2022-08-22 8:57 ` [PATCH 0/2] Fix some typos in SC8180X pinctrl driver Linus Walleij
2 siblings, 1 reply; 6+ messages in thread
From: Molly Sophia @ 2022-08-07 12:26 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross, Konrad Dybcio, Linus Walleij,
linux-arm-msm, linux-gpio, linux-kernel
Cc: Molly Sophia
Currently in the wakeirq_map, gpio36 and gpio37 have the same wakeirq
number, resulting in gpio37 being unable to trigger interrupts.
It looks like that this is a typo in the wakeirq map. So fix it.
Signed-off-by: Molly Sophia <mollysophia379@gmail.com>
---
drivers/pinctrl/qcom/pinctrl-sc8180x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-sc8180x.c b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
index 6bec7f143134..b4bf009fe23e 100644
--- a/drivers/pinctrl/qcom/pinctrl-sc8180x.c
+++ b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
@@ -1582,7 +1582,7 @@ static const int sc8180x_acpi_reserved_gpios[] = {
static const struct msm_gpio_wakeirq_map sc8180x_pdc_map[] = {
{ 3, 31 }, { 5, 32 }, { 8, 33 }, { 9, 34 }, { 10, 100 }, { 12, 104 },
{ 24, 37 }, { 26, 38 }, { 27, 41 }, { 28, 42 }, { 30, 39 }, { 36, 43 },
- { 37, 43 }, { 38, 45 }, { 39, 118 }, { 39, 125 }, { 41, 47 },
+ { 37, 44 }, { 38, 45 }, { 39, 118 }, { 39, 125 }, { 41, 47 },
{ 42, 48 }, { 46, 50 }, { 47, 49 }, { 48, 51 }, { 49, 53 }, { 50, 52 },
{ 51, 116 }, { 51, 123 }, { 53, 54 }, { 54, 55 }, { 55, 56 },
{ 56, 57 }, { 58, 58 }, { 60, 60 }, { 68, 62 }, { 70, 63 }, { 76, 86 },
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] pinctrl: qcom: sc8180x: Fix wrong pin numbers
2022-08-07 12:26 [PATCH 0/2] Fix some typos in SC8180X pinctrl driver Molly Sophia
2022-08-07 12:26 ` [PATCH 1/2] pinctrl: qcom: sc8180x: Fix gpio_wakeirq_map Molly Sophia
@ 2022-08-07 12:26 ` Molly Sophia
2022-08-08 4:17 ` Bjorn Andersson
2022-08-22 8:57 ` [PATCH 0/2] Fix some typos in SC8180X pinctrl driver Linus Walleij
2 siblings, 1 reply; 6+ messages in thread
From: Molly Sophia @ 2022-08-07 12:26 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross, Konrad Dybcio, Linus Walleij,
linux-arm-msm, linux-gpio, linux-kernel
Cc: Molly Sophia
The pin numbers for UFS_RESET and SDC2_* are not
consistent in the pinctrl driver for sc8180x.
So fix it.
Signed-off-by: Molly Sophia <mollysophia379@gmail.com>
---
drivers/pinctrl/qcom/pinctrl-sc8180x.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-sc8180x.c b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
index b4bf009fe23e..704a99d2f93c 100644
--- a/drivers/pinctrl/qcom/pinctrl-sc8180x.c
+++ b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
@@ -530,10 +530,10 @@ DECLARE_MSM_GPIO_PINS(187);
DECLARE_MSM_GPIO_PINS(188);
DECLARE_MSM_GPIO_PINS(189);
-static const unsigned int sdc2_clk_pins[] = { 190 };
-static const unsigned int sdc2_cmd_pins[] = { 191 };
-static const unsigned int sdc2_data_pins[] = { 192 };
-static const unsigned int ufs_reset_pins[] = { 193 };
+static const unsigned int ufs_reset_pins[] = { 190 };
+static const unsigned int sdc2_clk_pins[] = { 191 };
+static const unsigned int sdc2_cmd_pins[] = { 192 };
+static const unsigned int sdc2_data_pins[] = { 193 };
enum sc8180x_functions {
msm_mux_adsp_ext,
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] pinctrl: qcom: sc8180x: Fix wrong pin numbers
2022-08-07 12:26 ` [PATCH 2/2] pinctrl: qcom: sc8180x: Fix wrong pin numbers Molly Sophia
@ 2022-08-08 4:17 ` Bjorn Andersson
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2022-08-08 4:17 UTC (permalink / raw)
To: Molly Sophia
Cc: Andy Gross, Konrad Dybcio, Linus Walleij, linux-arm-msm,
linux-gpio, linux-kernel
On Sun 07 Aug 05:26 PDT 2022, Molly Sophia wrote:
> The pin numbers for UFS_RESET and SDC2_* are not
> consistent in the pinctrl driver for sc8180x.
> So fix it.
>
> Signed-off-by: Molly Sophia <mollysophia379@gmail.com>
Fixes: 97423113ec4b ("pinctrl: qcom: Add sc8180x TLMM driver")
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/pinctrl/qcom/pinctrl-sc8180x.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc8180x.c b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
> index b4bf009fe23e..704a99d2f93c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc8180x.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
> @@ -530,10 +530,10 @@ DECLARE_MSM_GPIO_PINS(187);
> DECLARE_MSM_GPIO_PINS(188);
> DECLARE_MSM_GPIO_PINS(189);
>
> -static const unsigned int sdc2_clk_pins[] = { 190 };
> -static const unsigned int sdc2_cmd_pins[] = { 191 };
> -static const unsigned int sdc2_data_pins[] = { 192 };
> -static const unsigned int ufs_reset_pins[] = { 193 };
> +static const unsigned int ufs_reset_pins[] = { 190 };
> +static const unsigned int sdc2_clk_pins[] = { 191 };
> +static const unsigned int sdc2_cmd_pins[] = { 192 };
> +static const unsigned int sdc2_data_pins[] = { 193 };
>
> enum sc8180x_functions {
> msm_mux_adsp_ext,
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] pinctrl: qcom: sc8180x: Fix gpio_wakeirq_map
2022-08-07 12:26 ` [PATCH 1/2] pinctrl: qcom: sc8180x: Fix gpio_wakeirq_map Molly Sophia
@ 2022-08-08 4:19 ` Bjorn Andersson
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2022-08-08 4:19 UTC (permalink / raw)
To: Molly Sophia
Cc: Andy Gross, Konrad Dybcio, Linus Walleij, linux-arm-msm,
linux-gpio, linux-kernel
On Sun 07 Aug 05:26 PDT 2022, Molly Sophia wrote:
> Currently in the wakeirq_map, gpio36 and gpio37 have the same wakeirq
> number, resulting in gpio37 being unable to trigger interrupts.
> It looks like that this is a typo in the wakeirq map. So fix it.
>
Thank you for finding this, I've been scratching my head about the
i2c-hid interrupts on this gpio for a while now. This indeed looks like
a typo, and the documentation confirms that 44 is the correct PDC irq
line.
> Signed-off-by: Molly Sophia <mollysophia379@gmail.com>
Fixes: 97423113ec4b ("pinctrl: qcom: Add sc8180x TLMM driver")
Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/pinctrl/qcom/pinctrl-sc8180x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc8180x.c b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
> index 6bec7f143134..b4bf009fe23e 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc8180x.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
> @@ -1582,7 +1582,7 @@ static const int sc8180x_acpi_reserved_gpios[] = {
> static const struct msm_gpio_wakeirq_map sc8180x_pdc_map[] = {
> { 3, 31 }, { 5, 32 }, { 8, 33 }, { 9, 34 }, { 10, 100 }, { 12, 104 },
> { 24, 37 }, { 26, 38 }, { 27, 41 }, { 28, 42 }, { 30, 39 }, { 36, 43 },
> - { 37, 43 }, { 38, 45 }, { 39, 118 }, { 39, 125 }, { 41, 47 },
> + { 37, 44 }, { 38, 45 }, { 39, 118 }, { 39, 125 }, { 41, 47 },
> { 42, 48 }, { 46, 50 }, { 47, 49 }, { 48, 51 }, { 49, 53 }, { 50, 52 },
> { 51, 116 }, { 51, 123 }, { 53, 54 }, { 54, 55 }, { 55, 56 },
> { 56, 57 }, { 58, 58 }, { 60, 60 }, { 68, 62 }, { 70, 63 }, { 76, 86 },
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Fix some typos in SC8180X pinctrl driver
2022-08-07 12:26 [PATCH 0/2] Fix some typos in SC8180X pinctrl driver Molly Sophia
2022-08-07 12:26 ` [PATCH 1/2] pinctrl: qcom: sc8180x: Fix gpio_wakeirq_map Molly Sophia
2022-08-07 12:26 ` [PATCH 2/2] pinctrl: qcom: sc8180x: Fix wrong pin numbers Molly Sophia
@ 2022-08-22 8:57 ` Linus Walleij
2 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2022-08-22 8:57 UTC (permalink / raw)
To: Molly Sophia
Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, linux-arm-msm,
linux-gpio, linux-kernel
On Sun, Aug 7, 2022 at 2:27 PM Molly Sophia <mollysophia379@gmail.com> wrote:
> There are some little mistakes in the sc8180x pinctrl
> driver. The following patches fix them.
Both patches applied for fixes, thanks for finding this!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-22 8:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-07 12:26 [PATCH 0/2] Fix some typos in SC8180X pinctrl driver Molly Sophia
2022-08-07 12:26 ` [PATCH 1/2] pinctrl: qcom: sc8180x: Fix gpio_wakeirq_map Molly Sophia
2022-08-08 4:19 ` Bjorn Andersson
2022-08-07 12:26 ` [PATCH 2/2] pinctrl: qcom: sc8180x: Fix wrong pin numbers Molly Sophia
2022-08-08 4:17 ` Bjorn Andersson
2022-08-22 8:57 ` [PATCH 0/2] Fix some typos in SC8180X pinctrl driver Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).