From: Andres Freund <andres@anarazel.de>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Roberto Sassu <roberto.sassu@huawei.com>,
Daniel Borkmann <daniel@iogearbox.net>,
quentin@isovalent.com, ast@kernel.org, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@google.com, peterz@infradead.org,
mingo@redhat.com, terrelln@fb.com, nathan@kernel.org,
ndesaulniers@google.com, bpf@vger.kernel.org,
linux-perf-users@vger.kernel.org, llvm@lists.linux.dev,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH 4/4] build: Switch to new openssl API for test-libcrypto
Date: Tue, 9 Aug 2022 10:00:34 -0700 [thread overview]
Message-ID: <20220809170034.hx7fyiosm3tfekwf@awork3.anarazel.de> (raw)
In-Reply-To: <YvJ7awkCVBYaZ2dd@kernel.org>
Hi,
On 2022-08-09 12:21:15 -0300, Arnaldo Carvalho de Melo wrote:
> So I backtracked, the way it works needs further consideration with
> regard to the patchkit from Andres, that is already upstream, so it
> would be good for Roberto to take a look at what is in torvalds/master
> now and see if we have to removed that styled thing from Andres.
Why would it have to be removed - seems to be fairly independent, leaving the
line conflicts aside? Or do you just mean folding it into one-big-test? If so,
that'd make sense, although I'm not sure how ready the infrastructure
FWIW, if I would have to maintain these, I'd probably change FEATURE_TESTS,
FEATURE_DISPLAY into one-item-per-line to make conflicts less common and
easier to resolve.
> Andres, if you could take a look at Roberto's patchkit as well that
> would be great.
I briefly scanned it, and the only real comment I have mirror's Quentin's,
namely that it'd be nice to avoid displaying more tests that don't tell the
user much.
Greetings,
Andres Freund
next prev parent reply other threads:[~2022-08-09 17:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 17:05 [PATCH 1/4] tools, build: Retry detection of bfd-related features Roberto Sassu
2022-07-19 17:05 ` [PATCH 2/4] bpftool: Complete libbfd feature detection Roberto Sassu
2022-07-20 20:07 ` Quentin Monnet
2022-07-19 17:05 ` [PATCH 3/4] perf: Remove FEATURE_CHECK_LDFLAGS-disassembler-four-args Roberto Sassu
2022-07-19 17:05 ` [PATCH 4/4] build: Switch to new openssl API for test-libcrypto Roberto Sassu
2022-08-08 16:14 ` Daniel Borkmann
2022-08-08 18:33 ` Arnaldo Carvalho de Melo
2022-08-09 15:15 ` Arnaldo Carvalho de Melo
2022-08-09 15:21 ` Arnaldo Carvalho de Melo
2022-08-09 15:28 ` Roberto Sassu
2022-08-09 16:01 ` Roberto Sassu
2022-08-09 17:00 ` Andres Freund [this message]
2022-08-09 19:04 ` Arnaldo Carvalho de Melo
2022-08-09 19:10 ` Arnaldo Carvalho de Melo
2022-08-09 15:21 ` Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809170034.hx7fyiosm3tfekwf@awork3.anarazel.de \
--to=andres@anarazel.de \
--cc=acme@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.lau@linux.dev \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=quentin@isovalent.com \
--cc=roberto.sassu@huawei.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).