From: Quentin Monnet <quentin@isovalent.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: Roberto Sassu <roberto.sassu@huawei.com>,
ast@kernel.org, andrii@kernel.org, martin.lau@linux.dev,
song@kernel.org, john.fastabend@gmail.com, kpsingh@kernel.org,
sdf@google.com, peterz@infradead.org, mingo@redhat.com,
terrelln@fb.com, nathan@kernel.org, ndesaulniers@google.com,
bpf@vger.kernel.org, linux-perf-users@vger.kernel.org,
llvm@lists.linux.dev, linux-kernel@vger.kernel.org,
Andres Freund <andres@anarazel.de>, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH 4/4] build: Switch to new openssl API for test-libcrypto
Date: Tue, 9 Aug 2022 16:21:29 +0100 [thread overview]
Message-ID: <692f0648-6f47-f4b7-f806-e57af59b1447@isovalent.com> (raw)
In-Reply-To: <YvJ6DbzBNsAgNZS4@kernel.org>
On 09/08/2022 16:15, Arnaldo Carvalho de Melo wrote:
> Em Mon, Aug 08, 2022 at 03:33:34PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Mon, Aug 08, 2022 at 06:14:48PM +0200, Daniel Borkmann escreveu:
>>> Hi Arnaldo,
>>>
>>> On 7/19/22 7:05 PM, Roberto Sassu wrote:
>>>> Switch to new EVP API for detecting libcrypto, as Fedora 36 returns an
>>>> error when it encounters the deprecated function MD5_Init() and the others.
>>>> The error would be interpreted as missing libcrypto, while in reality it is
>>>> not.
>>>>
>>>> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
>>>
>>> Given rest of the tooling fixes from Andres Freund went via perf tree and the
>>> below is perf related as well, I presume you'll pick this up, too?
>>
>> Sure.
>>
>>> [0] https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=perf/core
>
> So I fixed up the first one, minor fuzzes, the second I had to fix
> conflicts with the patchset from Andres, ended up as below, will test
> build it then in my container kit.
>
> - Arnaldo
>
> commit bea955a0256e20cc18e87087e42f2a903b9a8b84
> Author: Roberto Sassu <roberto.sassu@huawei.com>
> Date: Tue Jul 19 19:05:53 2022 +0200
>
> bpftool: Complete libbfd feature detection
>
> Commit 6e8ccb4f624a7 ("tools/bpf: properly account for libbfd variations")
> sets the linking flags depending on which flavor of the libbfd feature was
> detected.
>
> However, the flavors except libbfd cannot be detected, as they are not in
> the feature list.
>
> Complete the list of features to detect by adding libbfd-liberty and
> libbfd-liberty-z.
>
> Committer notes:
>
> Adjust conflict with with:
>
> 1e1613f64cc8a09d ("tools bpftool: Don't display disassembler-four-args feature test")
> 600b7b26c07a070d ("tools bpftool: Fix compilation error with new binutils")
>
> Fixes: 6e8ccb4f624a73c5 ("tools/bpf: properly account for libbfd variations")
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> Cc: Alexei Starovoitov <ast@kernel.org>
> Cc: Andres Freund <andres@anarazel.de>
> Cc: Andrii Nakryiko <andrii@kernel.org>
> Cc: bpf@vger.kernel.org
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: John Fastabend <john.fastabend@gmail.com>
> Cc: KP Singh <kpsingh@kernel.org>
> Cc: llvm@lists.linux.dev
> Cc: Martin KaFai Lau <martin.lau@linux.dev>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> Cc: Nick Terrell <terrelln@fb.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Quentin Monnet <quentin@isovalent.com>
> Cc: Song Liu <song@kernel.org>
> Cc: Stanislav Fomichev <sdf@google.com>
> Link: https://lore.kernel.org/r/20220719170555.2576993-2-roberto.sassu@huawei.com
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile
> index 04d733e98bffbc08..9cc132277150c534 100644
> --- a/tools/bpf/bpftool/Makefile
> +++ b/tools/bpf/bpftool/Makefile
> @@ -93,9 +93,11 @@ INSTALL ?= install
> RM ?= rm -f
>
> FEATURE_USER = .bpftool
> -FEATURE_TESTS = libbfd disassembler-four-args disassembler-init-styled libcap \
> +FEATURE_TESTS = libbfd libbfd-liberty libbfd-liberty-z
> + disassembler-four-args disassembler-init-styled libcap \
> clang-bpf-co-re
> -FEATURE_DISPLAY = libbfd libcap clang-bpf-co-re
> +FEATURE_DISPLAY = libbfd libbfd-liberty libbfd-liberty-z
> + libcap clang-bpf-co-re
>
> check_feat := 1
> NON_CHECK_FEAT_TARGETS := clean uninstall doc doc-clean doc-install doc-uninstall
The adjustment looks good, thanks Arnaldo!
prev parent reply other threads:[~2022-08-09 15:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 17:05 [PATCH 1/4] tools, build: Retry detection of bfd-related features Roberto Sassu
2022-07-19 17:05 ` [PATCH 2/4] bpftool: Complete libbfd feature detection Roberto Sassu
2022-07-20 20:07 ` Quentin Monnet
2022-07-19 17:05 ` [PATCH 3/4] perf: Remove FEATURE_CHECK_LDFLAGS-disassembler-four-args Roberto Sassu
2022-07-19 17:05 ` [PATCH 4/4] build: Switch to new openssl API for test-libcrypto Roberto Sassu
2022-08-08 16:14 ` Daniel Borkmann
2022-08-08 18:33 ` Arnaldo Carvalho de Melo
2022-08-09 15:15 ` Arnaldo Carvalho de Melo
2022-08-09 15:21 ` Arnaldo Carvalho de Melo
2022-08-09 15:28 ` Roberto Sassu
2022-08-09 16:01 ` Roberto Sassu
2022-08-09 17:00 ` Andres Freund
2022-08-09 19:04 ` Arnaldo Carvalho de Melo
2022-08-09 19:10 ` Arnaldo Carvalho de Melo
2022-08-09 15:21 ` Quentin Monnet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=692f0648-6f47-f4b7-f806-e57af59b1447@isovalent.com \
--to=quentin@isovalent.com \
--cc=acme@kernel.org \
--cc=andres@anarazel.de \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.lau@linux.dev \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=roberto.sassu@huawei.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).