linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/5] dt-bindings: display/msm: dpu: opp-table fixes
@ 2022-08-11  8:43 Krzysztof Kozlowski
  2022-08-11  8:43 ` [PATCH 1/5] dt-bindings: display/msm: dpu-msm8998: add missing DPU opp-table Krzysztof Kozlowski
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-11  8:43 UTC (permalink / raw)
  To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
	David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
	Del Regno, Loic Poulain, Krishna Manikandan, Jami Kettunen,
	Stephen Boyd, Bjorn Andersson, linux-arm-msm, dri-devel,
	freedreno, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

Hi,

There is a conflicting series of
https://lore.kernel.org/all/20220710090040.35193-1-dmitry.baryshkov@linaro.org/
but I think this one here should go before to fix the issue before the
refactoring.

Best regards,
Krzysztof

Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>

Krzysztof Kozlowski (5):
  dt-bindings: display/msm: dpu-msm8998: add missing DPU opp-table
  dt-bindings: display/msm: dpu-qcm2290: add missing DPU opp-table
  dt-bindings: display/msm: dpu-sc7180: add missing DPU opp-table
  dt-bindings: display/msm: dpu-sc7280: add missing DPU opp-table
  dt-bindings: display/msm: dpu-sdm845: add missing DPU opp-table

 Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml | 3 +++
 Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml | 2 ++
 Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml  | 2 ++
 Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml  | 2 ++
 Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml  | 3 +++
 5 files changed, 12 insertions(+)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/5] dt-bindings: display/msm: dpu-msm8998: add missing DPU opp-table
  2022-08-11  8:43 [PATCH 0/5] dt-bindings: display/msm: dpu: opp-table fixes Krzysztof Kozlowski
@ 2022-08-11  8:43 ` Krzysztof Kozlowski
  2022-08-14 21:25   ` Rob Herring
  2022-08-11  8:43 ` [PATCH 2/5] dt-bindings: display/msm: dpu-qcm2290: " Krzysztof Kozlowski
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-11  8:43 UTC (permalink / raw)
  To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
	David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
	Del Regno, Loic Poulain, Krishna Manikandan, Jami Kettunen,
	Stephen Boyd, Bjorn Andersson, linux-arm-msm, dri-devel,
	freedreno, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses
opp-table, so reference it which allows restricting DPU schema to fixed
list of properties.

Fixes: 6e986a8f1cf1 ("dt-bindings: display: msm: Add binding for msm8998 dpu")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
---
 Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
index 2df64afb76e6..7ed438bc7dce 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
@@ -62,6 +62,7 @@ patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
     description: Node containing the properties of DPU.
+    additionalProperties: false
 
     properties:
       compatible:
@@ -105,6 +106,8 @@ patternProperties:
         maxItems: 1
 
       operating-points-v2: true
+      opp-table: true
+
       ports:
         $ref: /schemas/graph.yaml#/properties/ports
         description: |
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/5] dt-bindings: display/msm: dpu-qcm2290: add missing DPU opp-table
  2022-08-11  8:43 [PATCH 0/5] dt-bindings: display/msm: dpu: opp-table fixes Krzysztof Kozlowski
  2022-08-11  8:43 ` [PATCH 1/5] dt-bindings: display/msm: dpu-msm8998: add missing DPU opp-table Krzysztof Kozlowski
@ 2022-08-11  8:43 ` Krzysztof Kozlowski
  2022-08-11  8:43 ` [PATCH 3/5] dt-bindings: display/msm: dpu-sc7180: " Krzysztof Kozlowski
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-11  8:43 UTC (permalink / raw)
  To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
	David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
	Del Regno, Loic Poulain, Krishna Manikandan, Jami Kettunen,
	Stephen Boyd, Bjorn Andersson, linux-arm-msm, dri-devel,
	freedreno, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses
opp-table, so reference it which allows restricting DPU schema to fixed
list of properties.

Fixes: 164f69d9d45a ("dt-bindings: msm: disp: add yaml schemas for QCM2290 DPU bindings")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
---
 Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
index 734d14de966d..47759c871429 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
@@ -74,6 +74,7 @@ patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
     description: Node containing the properties of DPU.
+    additionalProperties: false
 
     properties:
       compatible:
@@ -113,6 +114,7 @@ patternProperties:
         maxItems: 1
 
       operating-points-v2: true
+      opp-table: true
 
       ports:
         $ref: /schemas/graph.yaml#/properties/ports
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 3/5] dt-bindings: display/msm: dpu-sc7180: add missing DPU opp-table
  2022-08-11  8:43 [PATCH 0/5] dt-bindings: display/msm: dpu: opp-table fixes Krzysztof Kozlowski
  2022-08-11  8:43 ` [PATCH 1/5] dt-bindings: display/msm: dpu-msm8998: add missing DPU opp-table Krzysztof Kozlowski
  2022-08-11  8:43 ` [PATCH 2/5] dt-bindings: display/msm: dpu-qcm2290: " Krzysztof Kozlowski
@ 2022-08-11  8:43 ` Krzysztof Kozlowski
  2022-08-11  8:43 ` [PATCH 4/5] dt-bindings: display/msm: dpu-sc7280: " Krzysztof Kozlowski
  2022-08-11  8:43 ` [PATCH 5/5] dt-bindings: display/msm: dpu-sdm845: " Krzysztof Kozlowski
  4 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-11  8:43 UTC (permalink / raw)
  To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
	David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
	Del Regno, Loic Poulain, Krishna Manikandan, Jami Kettunen,
	Stephen Boyd, Bjorn Andersson, linux-arm-msm, dri-devel,
	freedreno, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses
opp-table, so reference it which allows restricting DPU schema to fixed
list of properties.

Fixes: 3d7a0dd8f39b ("dt-bindings: msm: disp: add yaml schemas for DPU bindings")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
---
 Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
index d3c3e4b07897..d30b6f9bd9d2 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
@@ -73,6 +73,7 @@ patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
     description: Node containing the properties of DPU.
+    additionalProperties: false
 
     properties:
       compatible:
@@ -114,6 +115,7 @@ patternProperties:
         maxItems: 1
 
       operating-points-v2: true
+      opp-table: true
 
       ports:
         $ref: /schemas/graph.yaml#/properties/ports
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 4/5] dt-bindings: display/msm: dpu-sc7280: add missing DPU opp-table
  2022-08-11  8:43 [PATCH 0/5] dt-bindings: display/msm: dpu: opp-table fixes Krzysztof Kozlowski
                   ` (2 preceding siblings ...)
  2022-08-11  8:43 ` [PATCH 3/5] dt-bindings: display/msm: dpu-sc7180: " Krzysztof Kozlowski
@ 2022-08-11  8:43 ` Krzysztof Kozlowski
  2022-08-11  8:43 ` [PATCH 5/5] dt-bindings: display/msm: dpu-sdm845: " Krzysztof Kozlowski
  4 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-11  8:43 UTC (permalink / raw)
  To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
	David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
	Del Regno, Loic Poulain, Krishna Manikandan, Jami Kettunen,
	Stephen Boyd, Bjorn Andersson, linux-arm-msm, dri-devel,
	freedreno, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses
opp-table, so reference it which allows restricting DPU schema to fixed
list of properties.

Fixes: 57fd4f34ddac ("dt-bindings: msm: add DT bindings for sc7280")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
---
 Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
index f427eec3d3a4..5a4bec99b98a 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
@@ -72,6 +72,7 @@ patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
     description: Node containing the properties of DPU.
+    additionalProperties: false
 
     properties:
       compatible:
@@ -112,6 +113,7 @@ patternProperties:
         maxItems: 1
 
       operating-points-v2: true
+      opp-table: true
 
       ports:
         $ref: /schemas/graph.yaml#/properties/ports
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 5/5] dt-bindings: display/msm: dpu-sdm845: add missing DPU opp-table
  2022-08-11  8:43 [PATCH 0/5] dt-bindings: display/msm: dpu: opp-table fixes Krzysztof Kozlowski
                   ` (3 preceding siblings ...)
  2022-08-11  8:43 ` [PATCH 4/5] dt-bindings: display/msm: dpu-sc7280: " Krzysztof Kozlowski
@ 2022-08-11  8:43 ` Krzysztof Kozlowski
  4 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-11  8:43 UTC (permalink / raw)
  To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
	David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
	Del Regno, Loic Poulain, Krishna Manikandan, Jami Kettunen,
	Stephen Boyd, Bjorn Andersson, linux-arm-msm, dri-devel,
	freedreno, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses
opp-table, so reference it which allows restricting DPU schema to fixed
list of properties.

Fixes: 3d7a0dd8f39b ("dt-bindings: msm: disp: add yaml schemas for DPU bindings")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
---
 Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
index 2bb8896beffc..aa99201dae3f 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
@@ -65,6 +65,7 @@ patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
     description: Node containing the properties of DPU.
+    additionalProperties: false
 
     properties:
       compatible:
@@ -102,6 +103,8 @@ patternProperties:
         maxItems: 1
 
       operating-points-v2: true
+      opp-table: true
+
       ports:
         $ref: /schemas/graph.yaml#/properties/ports
         description: |
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/5] dt-bindings: display/msm: dpu-msm8998: add missing DPU opp-table
  2022-08-11  8:43 ` [PATCH 1/5] dt-bindings: display/msm: dpu-msm8998: add missing DPU opp-table Krzysztof Kozlowski
@ 2022-08-14 21:25   ` Rob Herring
  2022-08-17  6:17     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 8+ messages in thread
From: Rob Herring @ 2022-08-14 21:25 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
	David Airlie, Daniel Vetter, Krzysztof Kozlowski, Del Regno,
	Loic Poulain, Krishna Manikandan, Jami Kettunen, Stephen Boyd,
	Bjorn Andersson, linux-arm-msm, dri-devel, freedreno, devicetree,
	linux-kernel

On Thu, Aug 11, 2022 at 11:43:27AM +0300, Krzysztof Kozlowski wrote:
> The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses
> opp-table, so reference it which allows restricting DPU schema to fixed
> list of properties.
> 
> Fixes: 6e986a8f1cf1 ("dt-bindings: display: msm: Add binding for msm8998 dpu")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
>  Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
> index 2df64afb76e6..7ed438bc7dce 100644
> --- a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
> @@ -62,6 +62,7 @@ patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
>      description: Node containing the properties of DPU.
> +    additionalProperties: false
>  
>      properties:
>        compatible:
> @@ -105,6 +106,8 @@ patternProperties:
>          maxItems: 1
>  
>        operating-points-v2: true
> +      opp-table: true

type: object

Otherwise, 'opp-table;' would be accepted.

> +
>        ports:
>          $ref: /schemas/graph.yaml#/properties/ports
>          description: |
> -- 
> 2.34.1
> 
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/5] dt-bindings: display/msm: dpu-msm8998: add missing DPU opp-table
  2022-08-14 21:25   ` Rob Herring
@ 2022-08-17  6:17     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-17  6:17 UTC (permalink / raw)
  To: Rob Herring
  Cc: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
	David Airlie, Daniel Vetter, Krzysztof Kozlowski, Del Regno,
	Loic Poulain, Krishna Manikandan, Jami Kettunen, Stephen Boyd,
	Bjorn Andersson, linux-arm-msm, dri-devel, freedreno, devicetree,
	linux-kernel

On 15/08/2022 00:25, Rob Herring wrote:

>>      properties:
>>        compatible:
>> @@ -105,6 +106,8 @@ patternProperties:
>>          maxItems: 1
>>  
>>        operating-points-v2: true
>> +      opp-table: true
> 
> type: object
> 
> Otherwise, 'opp-table;' would be accepted.
> 

Thanks, I'll fix it.


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-08-17  6:17 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-11  8:43 [PATCH 0/5] dt-bindings: display/msm: dpu: opp-table fixes Krzysztof Kozlowski
2022-08-11  8:43 ` [PATCH 1/5] dt-bindings: display/msm: dpu-msm8998: add missing DPU opp-table Krzysztof Kozlowski
2022-08-14 21:25   ` Rob Herring
2022-08-17  6:17     ` Krzysztof Kozlowski
2022-08-11  8:43 ` [PATCH 2/5] dt-bindings: display/msm: dpu-qcm2290: " Krzysztof Kozlowski
2022-08-11  8:43 ` [PATCH 3/5] dt-bindings: display/msm: dpu-sc7180: " Krzysztof Kozlowski
2022-08-11  8:43 ` [PATCH 4/5] dt-bindings: display/msm: dpu-sc7280: " Krzysztof Kozlowski
2022-08-11  8:43 ` [PATCH 5/5] dt-bindings: display/msm: dpu-sdm845: " Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).