linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] perf evsel: Update the hint for the usage of the load latency event
@ 2022-08-17 12:40 kan.liang
  0 siblings, 0 replies; only message in thread
From: kan.liang @ 2022-08-17 12:40 UTC (permalink / raw)
  To: acme, linux-kernel; +Cc: eranian, ak, namhyung, irogers, Kan Liang

From: Kan Liang <kan.liang@linux.intel.com>

The current message is not providing enough information. It's hard for
a user to figure out what's the auxiliary event.

Adding the event name of the auxiliary event in the hint. The user can
simply cut & paste.

Suggested-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
---
 tools/perf/util/evsel.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 4852089e1d79..0d1bb5c723e9 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -3056,7 +3056,8 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target,
 		break;
 	case ENODATA:
 		return scnprintf(msg, size, "Cannot collect data source with the load latency event alone. "
-				 "Please add an auxiliary event in front of the load latency event.");
+				 "Please add an auxiliary event in front of the load latency event. "
+				 "For example, -e {mem-loads-aux,%s}.", evsel__name(evsel));
 	default:
 		break;
 	}
-- 
2.35.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-08-17 12:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-17 12:40 [PATCH] perf evsel: Update the hint for the usage of the load latency event kan.liang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).