linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [jgunthorpe:vfio_dma_buf 1/18] drivers/vfio/pci/vfio_pci_zdev.c:116:5: warning: no previous prototype for 'vfio_pci_info_zdev_add_caps'
@ 2022-08-17  5:39 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-08-17  5:39 UTC (permalink / raw)
  To: Jason Gunthorpe; +Cc: kbuild-all, linux-kernel

tree:   https://github.com/jgunthorpe/linux vfio_dma_buf
head:   f5c3d9a2ccc263572e3fc0f87a338679af57184a
commit: 25ad961c532a633fa112c551f8ec63cd17fda180 [1/18] vfio/pci: Split linux/vfio_pci_core.h
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20220817/202208171357.kX3EBdtG-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/jgunthorpe/linux/commit/25ad961c532a633fa112c551f8ec63cd17fda180
        git remote add jgunthorpe https://github.com/jgunthorpe/linux
        git fetch --no-tags jgunthorpe vfio_dma_buf
        git checkout 25ad961c532a633fa112c551f8ec63cd17fda180
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/vfio/pci/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/vfio/pci/vfio_pci_zdev.c:116:5: warning: no previous prototype for 'vfio_pci_info_zdev_add_caps' [-Wmissing-prototypes]
     116 | int vfio_pci_info_zdev_add_caps(struct vfio_pci_core_device *vdev,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/vfio/pci/vfio_pci_zdev.c:144:5: warning: no previous prototype for 'vfio_pci_zdev_open_device' [-Wmissing-prototypes]
     144 | int vfio_pci_zdev_open_device(struct vfio_pci_core_device *vdev)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/vfio/pci/vfio_pci_zdev.c:157:6: warning: no previous prototype for 'vfio_pci_zdev_close_device' [-Wmissing-prototypes]
     157 | void vfio_pci_zdev_close_device(struct vfio_pci_core_device *vdev)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/vfio_pci_info_zdev_add_caps +116 drivers/vfio/pci/vfio_pci_zdev.c

e6b817d4b8217a Matthew Rosato 2020-10-07  112  
e6b817d4b8217a Matthew Rosato 2020-10-07  113  /*
e6b817d4b8217a Matthew Rosato 2020-10-07  114   * Add all supported capabilities to the VFIO_DEVICE_GET_INFO capability chain.
e6b817d4b8217a Matthew Rosato 2020-10-07  115   */
536475109c8284 Max Gurtovoy   2021-08-26 @116  int vfio_pci_info_zdev_add_caps(struct vfio_pci_core_device *vdev,
e6b817d4b8217a Matthew Rosato 2020-10-07  117  				struct vfio_info_cap *caps)
e6b817d4b8217a Matthew Rosato 2020-10-07  118  {
e6b817d4b8217a Matthew Rosato 2020-10-07  119  	struct zpci_dev *zdev = to_zpci(vdev->pdev);
e6b817d4b8217a Matthew Rosato 2020-10-07  120  	int ret;
e6b817d4b8217a Matthew Rosato 2020-10-07  121  
e6b817d4b8217a Matthew Rosato 2020-10-07  122  	if (!zdev)
e6b817d4b8217a Matthew Rosato 2020-10-07  123  		return -ENODEV;
e6b817d4b8217a Matthew Rosato 2020-10-07  124  
46c47466609444 Max Gurtovoy   2021-02-01  125  	ret = zpci_base_cap(zdev, caps);
e6b817d4b8217a Matthew Rosato 2020-10-07  126  	if (ret)
e6b817d4b8217a Matthew Rosato 2020-10-07  127  		return ret;
e6b817d4b8217a Matthew Rosato 2020-10-07  128  
46c47466609444 Max Gurtovoy   2021-02-01  129  	ret = zpci_group_cap(zdev, caps);
e6b817d4b8217a Matthew Rosato 2020-10-07  130  	if (ret)
e6b817d4b8217a Matthew Rosato 2020-10-07  131  		return ret;
e6b817d4b8217a Matthew Rosato 2020-10-07  132  
e6b817d4b8217a Matthew Rosato 2020-10-07  133  	if (zdev->util_str_avail) {
46c47466609444 Max Gurtovoy   2021-02-01  134  		ret = zpci_util_cap(zdev, caps);
e6b817d4b8217a Matthew Rosato 2020-10-07  135  		if (ret)
e6b817d4b8217a Matthew Rosato 2020-10-07  136  			return ret;
e6b817d4b8217a Matthew Rosato 2020-10-07  137  	}
e6b817d4b8217a Matthew Rosato 2020-10-07  138  
46c47466609444 Max Gurtovoy   2021-02-01  139  	ret = zpci_pfip_cap(zdev, caps);
e6b817d4b8217a Matthew Rosato 2020-10-07  140  
e6b817d4b8217a Matthew Rosato 2020-10-07  141  	return ret;
e6b817d4b8217a Matthew Rosato 2020-10-07  142  }
8061d1c31f1a01 Matthew Rosato 2022-06-06  143  
8061d1c31f1a01 Matthew Rosato 2022-06-06 @144  int vfio_pci_zdev_open_device(struct vfio_pci_core_device *vdev)
8061d1c31f1a01 Matthew Rosato 2022-06-06  145  {
8061d1c31f1a01 Matthew Rosato 2022-06-06  146  	struct zpci_dev *zdev = to_zpci(vdev->pdev);
8061d1c31f1a01 Matthew Rosato 2022-06-06  147  
8061d1c31f1a01 Matthew Rosato 2022-06-06  148  	if (!zdev)
8061d1c31f1a01 Matthew Rosato 2022-06-06  149  		return -ENODEV;
8061d1c31f1a01 Matthew Rosato 2022-06-06  150  
8061d1c31f1a01 Matthew Rosato 2022-06-06  151  	if (!vdev->vdev.kvm)
8061d1c31f1a01 Matthew Rosato 2022-06-06  152  		return 0;
8061d1c31f1a01 Matthew Rosato 2022-06-06  153  
8061d1c31f1a01 Matthew Rosato 2022-06-06  154  	return kvm_s390_pci_register_kvm(zdev, vdev->vdev.kvm);
8061d1c31f1a01 Matthew Rosato 2022-06-06  155  }
8061d1c31f1a01 Matthew Rosato 2022-06-06  156  
8061d1c31f1a01 Matthew Rosato 2022-06-06 @157  void vfio_pci_zdev_close_device(struct vfio_pci_core_device *vdev)

:::::: The code at line 116 was first introduced by commit
:::::: 536475109c82841126ca341ef0f138e7298880c1 vfio/pci: Rename vfio_pci_device to vfio_pci_core_device

:::::: TO: Max Gurtovoy <mgurtovoy@nvidia.com>
:::::: CC: Alex Williamson <alex.williamson@redhat.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-08-17  5:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-17  5:39 [jgunthorpe:vfio_dma_buf 1/18] drivers/vfio/pci/vfio_pci_zdev.c:116:5: warning: no previous prototype for 'vfio_pci_info_zdev_add_caps' kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).