linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/6] ARM: dts: pci-mvebu: Fix assigned-addresses for every PCIe Root Port
@ 2022-08-17 22:30 Pali Rohár
  2022-08-17 22:30 ` [PATCH 1/6] ARM: dts: dove: " Pali Rohár
                   ` (7 more replies)
  0 siblings, 8 replies; 10+ messages in thread
From: Pali Rohár @ 2022-08-17 22:30 UTC (permalink / raw)
  To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Rob Herring
  Cc: linux-arm-kernel, devicetree, linux-kernel, Marek Behún

Per IEEE Std 1275-1994 bindings documentation (to which kernel DT
bindings refers), DT property assigned-addresses contains BDF address
of resource. Currently more PCIe Root Port nodes have BDF address in
assigned-addresses which points to different PCIe Root Port nodes. This
obviously does not make sense as the address resource specified in
assigned-addresses of every PCIe Root Port describes address range of
internal registers which are specific for corresponding Marvell PCIe
Root Port. Fix this issue and align all BDF addresses in
assigned-addresses DT property to specify correct BDF address of the
current PCIe Root Port.

Note that current version of pci-mvebu.c controller driver, which
registers Marvell PCIe Root Ports, ignores BDF value in DT property
assigned-addresses. It expects that Root Port's assigned-addresses
contains address range of that root port. That is why driver currently
works without any issue and nobody spotted it. But if driver or
something else would do device tree validation then this issue should be
spotted and throws error. Also device tree files may be used by other
projects where drivers may require correct values.

This patch series aligns BDF address of every Marvell PCIe Root Port in
node name, config space in reg property and mem in assigned-address
property of internal registers resource.

Pali Rohár (6):
  ARM: dts: dove: Fix assigned-addresses for every PCIe Root Port
  ARM: dts: armada-370: Fix assigned-addresses for every PCIe Root Port
  ARM: dts: armada-xp: Fix assigned-addresses for every PCIe Root Port
  ARM: dts: armada-375: Fix assigned-addresses for every PCIe Root Port
  ARM: dts: armada-38x: Fix assigned-addresses for every PCIe Root Port
  ARM: dts: armada-39x: Fix assigned-addresses for every PCIe Root Port

 arch/arm/boot/dts/armada-370.dtsi        |  2 +-
 arch/arm/boot/dts/armada-375.dtsi        |  2 +-
 arch/arm/boot/dts/armada-380.dtsi        |  4 ++--
 arch/arm/boot/dts/armada-385.dtsi        |  6 +++---
 arch/arm/boot/dts/armada-39x.dtsi        |  6 +++---
 arch/arm/boot/dts/armada-xp-mv78230.dtsi |  8 ++++----
 arch/arm/boot/dts/armada-xp-mv78260.dtsi | 16 ++++++++--------
 arch/arm/boot/dts/dove.dtsi              |  2 +-
 8 files changed, 23 insertions(+), 23 deletions(-)

-- 
2.20.1


^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-11-27 23:56 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-17 22:30 [PATCH 0/6] ARM: dts: pci-mvebu: Fix assigned-addresses for every PCIe Root Port Pali Rohár
2022-08-17 22:30 ` [PATCH 1/6] ARM: dts: dove: " Pali Rohár
2022-08-17 22:30 ` [PATCH 2/6] ARM: dts: armada-370: " Pali Rohár
2022-08-17 22:30 ` [PATCH 3/6] ARM: dts: armada-xp: " Pali Rohár
2022-08-17 22:30 ` [PATCH 4/6] ARM: dts: armada-375: " Pali Rohár
2022-08-17 22:30 ` [PATCH 5/6] ARM: dts: armada-38x: " Pali Rohár
2022-08-17 22:30 ` [PATCH 6/6] ARM: dts: armada-39x: " Pali Rohár
2022-10-09 11:15 ` [PATCH 0/6] ARM: dts: pci-mvebu: " Pali Rohár
2022-11-01 22:19   ` Pali Rohár
2022-11-27 23:56 ` Gregory CLEMENT

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).