linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8mp-verdin: add cpu-supply
@ 2022-08-22  7:53 Max Krummenacher
  2022-08-22  9:22 ` Laurent Pinchart
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Max Krummenacher @ 2022-08-22  7:53 UTC (permalink / raw)
  To: Max Krummenacher
  Cc: Fabio Estevam, Krzysztof Kozlowski, Laurent Pinchart,
	Marcel Ziswiler, NXP Linux Team, Pengutronix Kernel Team,
	Philippe Schenker, Rob Herring, Sascha Hauer, Shawn Guo,
	devicetree, linux-arm-kernel, linux-kernel

From: Max Krummenacher <max.krummenacher@toradex.com>

Add the cpu-supply property to all CPU nodes to enable the cpufreq
driver.

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>

---

 .../boot/dts/freescale/imx8mp-verdin.dtsi      | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
index f062fdbb2719..dbc22b672fb3 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
@@ -146,6 +146,22 @@ reserved-memory {
 	};
 };
 
+&A53_0 {
+	cpu-supply = <&reg_vdd_arm>;
+};
+
+&A53_1 {
+	cpu-supply = <&reg_vdd_arm>;
+};
+
+&A53_2 {
+	cpu-supply = <&reg_vdd_arm>;
+};
+
+&A53_3 {
+	cpu-supply = <&reg_vdd_arm>;
+};
+
 &cpu_alert0 {
 	temperature = <95000>;
 };
@@ -453,7 +469,7 @@ BUCK1 {
 				regulator-ramp-delay = <3125>;
 			};
 
-			BUCK2 {
+			reg_vdd_arm: BUCK2 {
 				nxp,dvs-run-voltage = <950000>;
 				nxp,dvs-standby-voltage = <850000>;
 				regulator-always-on;
-- 
2.35.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp-verdin: add cpu-supply
  2022-08-22  7:53 [PATCH] arm64: dts: imx8mp-verdin: add cpu-supply Max Krummenacher
@ 2022-08-22  9:22 ` Laurent Pinchart
  2022-08-22  9:33 ` Marcel Ziswiler
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2022-08-22  9:22 UTC (permalink / raw)
  To: Max Krummenacher
  Cc: Max Krummenacher, Fabio Estevam, Krzysztof Kozlowski,
	Marcel Ziswiler, NXP Linux Team, Pengutronix Kernel Team,
	Philippe Schenker, Rob Herring, Sascha Hauer, Shawn Guo,
	devicetree, linux-arm-kernel, linux-kernel

Hi Max,

Thank you for the patch.

On Mon, Aug 22, 2022 at 09:53:42AM +0200, Max Krummenacher wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
> 
> Add the cpu-supply property to all CPU nodes to enable the cpufreq
> driver.
> 
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
>  .../boot/dts/freescale/imx8mp-verdin.dtsi      | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> index f062fdbb2719..dbc22b672fb3 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> @@ -146,6 +146,22 @@ reserved-memory {
>  	};
>  };
>  
> +&A53_0 {
> +	cpu-supply = <&reg_vdd_arm>;
> +};
> +
> +&A53_1 {
> +	cpu-supply = <&reg_vdd_arm>;
> +};
> +
> +&A53_2 {
> +	cpu-supply = <&reg_vdd_arm>;
> +};
> +
> +&A53_3 {
> +	cpu-supply = <&reg_vdd_arm>;
> +};
> +
>  &cpu_alert0 {
>  	temperature = <95000>;
>  };
> @@ -453,7 +469,7 @@ BUCK1 {
>  				regulator-ramp-delay = <3125>;
>  			};
>  
> -			BUCK2 {
> +			reg_vdd_arm: BUCK2 {
>  				nxp,dvs-run-voltage = <950000>;
>  				nxp,dvs-standby-voltage = <850000>;
>  				regulator-always-on;

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp-verdin: add cpu-supply
  2022-08-22  7:53 [PATCH] arm64: dts: imx8mp-verdin: add cpu-supply Max Krummenacher
  2022-08-22  9:22 ` Laurent Pinchart
@ 2022-08-22  9:33 ` Marcel Ziswiler
  2022-08-29 18:21 ` Francesco Dolcini
  2022-09-03  1:49 ` Shawn Guo
  3 siblings, 0 replies; 5+ messages in thread
From: Marcel Ziswiler @ 2022-08-22  9:33 UTC (permalink / raw)
  To: max.oss.09, Max Krummenacher
  Cc: laurent.pinchart, kernel, linux-imx, festevam, Philippe Schenker,
	devicetree, s.hauer, shawnguo, linux-arm-kernel, linux-kernel,
	krzysztof.kozlowski+dt, robh+dt

On Mon, 2022-08-22 at 09:53 +0200, Max Krummenacher wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
> 
> Add the cpu-supply property to all CPU nodes to enable the cpufreq
> driver.
> 
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>

Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

> ---
> 
>  .../boot/dts/freescale/imx8mp-verdin.dtsi      | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-
> verdin.dtsi
> index f062fdbb2719..dbc22b672fb3 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> @@ -146,6 +146,22 @@ reserved-memory {
>         };
>  };
>  
> +&A53_0 {
> +       cpu-supply = <&reg_vdd_arm>;
> +};
> +
> +&A53_1 {
> +       cpu-supply = <&reg_vdd_arm>;
> +};
> +
> +&A53_2 {
> +       cpu-supply = <&reg_vdd_arm>;
> +};
> +
> +&A53_3 {
> +       cpu-supply = <&reg_vdd_arm>;
> +};
> +
>  &cpu_alert0 {
>         temperature = <95000>;
>  };
> @@ -453,7 +469,7 @@ BUCK1 {
>                                 regulator-ramp-delay = <3125>;
>                         };
>  
> -                       BUCK2 {
> +                       reg_vdd_arm: BUCK2 {
>                                 nxp,dvs-run-voltage = <950000>;
>                                 nxp,dvs-standby-voltage = <850000>;
>                                 regulator-always-on;

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp-verdin: add cpu-supply
  2022-08-22  7:53 [PATCH] arm64: dts: imx8mp-verdin: add cpu-supply Max Krummenacher
  2022-08-22  9:22 ` Laurent Pinchart
  2022-08-22  9:33 ` Marcel Ziswiler
@ 2022-08-29 18:21 ` Francesco Dolcini
  2022-09-03  1:49 ` Shawn Guo
  3 siblings, 0 replies; 5+ messages in thread
From: Francesco Dolcini @ 2022-08-29 18:21 UTC (permalink / raw)
  To: Max Krummenacher, linux-arm-kernel
  Cc: Max Krummenacher, Fabio Estevam, Krzysztof Kozlowski,
	Laurent Pinchart, Marcel Ziswiler, NXP Linux Team,
	Pengutronix Kernel Team, Philippe Schenker, Rob Herring,
	Sascha Hauer, Shawn Guo, devicetree, linux-kernel

On Mon, Aug 22, 2022 at 09:53:42AM +0200, Max Krummenacher wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
> 
> Add the cpu-supply property to all CPU nodes to enable the cpufreq
> driver.
> 
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>

This would need a fixes tag IMO:

Fixes: a39ed23bdf6e ("arm64: dts: freescale: add initial support for verdin imx8m plus")

Francesco


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp-verdin: add cpu-supply
  2022-08-22  7:53 [PATCH] arm64: dts: imx8mp-verdin: add cpu-supply Max Krummenacher
                   ` (2 preceding siblings ...)
  2022-08-29 18:21 ` Francesco Dolcini
@ 2022-09-03  1:49 ` Shawn Guo
  3 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2022-09-03  1:49 UTC (permalink / raw)
  To: Max Krummenacher
  Cc: Max Krummenacher, Fabio Estevam, Krzysztof Kozlowski,
	Laurent Pinchart, Marcel Ziswiler, NXP Linux Team,
	Pengutronix Kernel Team, Philippe Schenker, Rob Herring,
	Sascha Hauer, devicetree, linux-arm-kernel, linux-kernel

On Mon, Aug 22, 2022 at 09:53:42AM +0200, Max Krummenacher wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
> 
> Add the cpu-supply property to all CPU nodes to enable the cpufreq
> driver.
> 
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>

Applied, thanks!

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-09-03  1:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-22  7:53 [PATCH] arm64: dts: imx8mp-verdin: add cpu-supply Max Krummenacher
2022-08-22  9:22 ` Laurent Pinchart
2022-08-22  9:33 ` Marcel Ziswiler
2022-08-29 18:21 ` Francesco Dolcini
2022-09-03  1:49 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).