linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] gadget/udc: fix repeated words in comments
@ 2022-08-22 11:57 Jilin Yuan
  0 siblings, 0 replies; 5+ messages in thread
From: Jilin Yuan @ 2022-08-22 11:57 UTC (permalink / raw)
  To: balbi, daniel, haojian.zhuang, robert.jarzmik
  Cc: linux-usb, linux-arm-kernel, linux-kernel, Jilin Yuan

 Delete the redundant word 'tell'.
 Delete the redundant word 'also'.
 Delete the redundant word 'with'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/usb/gadget/udc/at91_udc.c   | 2 +-
 drivers/usb/gadget/udc/core.c       | 2 +-
 drivers/usb/gadget/udc/pxa25x_udc.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
index 728987280373..c80d0902bb30 100644
--- a/drivers/usb/gadget/udc/at91_udc.c
+++ b/drivers/usb/gadget/udc/at91_udc.c
@@ -994,7 +994,7 @@ static const struct usb_gadget_ops at91_udc_ops = {
 	.udc_stop		= at91_stop,
 
 	/*
-	 * VBUS-powered devices may also also want to support bigger
+	 * VBUS-powered devices may also want to support bigger
 	 * power budgets after an appropriate SET_CONFIGURATION.
 	 */
 	/* .vbus_power		= at91_vbus_power, */
diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
index b5b42f7a299b..8dd8fbd44d65 100644
--- a/drivers/usb/gadget/udc/core.c
+++ b/drivers/usb/gadget/udc/core.c
@@ -900,7 +900,7 @@ EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
 
 /**
  * usb_gadget_giveback_request - give the request back to the gadget layer
- * @ep: the endpoint to be used with with the request
+ * @ep: the endpoint to be used with the request
  * @req: the request being given back
  *
  * This is called by device controller drivers in order to return the
diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c
index c593fc383481..176e2b157021 100644
--- a/drivers/usb/gadget/udc/pxa25x_udc.c
+++ b/drivers/usb/gadget/udc/pxa25x_udc.c
@@ -1737,7 +1737,7 @@ static void handle_ep0 (struct pxa25x_udc *dev)
 				/* hardware automagic preventing STALL... */
 				if (dev->req_config) {
 					/* hardware sometimes neglects to tell
-					 * tell us about config change events,
+					 * us about config change events,
 					 * so later ones may fail...
 					 */
 					WARNING("config change %02x fail %d?\n",
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] gadget/udc: fix repeated words in comments
  2022-08-21 15:20 Jilin Yuan
@ 2022-08-22  6:14 ` Greg KH
  0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2022-08-22  6:14 UTC (permalink / raw)
  To: Jilin Yuan
  Cc: daniel, haojian.zhuang, robert.jarzmik, balbi, linux-usb, linux-kernel

On Sun, Aug 21, 2022 at 11:20:09PM +0800, Jilin Yuan wrote:
>  Delete the redundant word 'tell'.
> 
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
>  drivers/usb/gadget/udc/pxa25x_udc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c
> index c593fc383481..176e2b157021 100644
> --- a/drivers/usb/gadget/udc/pxa25x_udc.c
> +++ b/drivers/usb/gadget/udc/pxa25x_udc.c
> @@ -1737,7 +1737,7 @@ static void handle_ep0 (struct pxa25x_udc *dev)
>  				/* hardware automagic preventing STALL... */
>  				if (dev->req_config) {
>  					/* hardware sometimes neglects to tell
> -					 * tell us about config change events,
> +					 * us about config change events,
>  					 * so later ones may fail...
>  					 */
>  					WARNING("config change %02x fail %d?\n",
> -- 
> 2.36.1
> 

You sent 3 patches that do different things, yet have the same exact
subject line :(

Please fix up and resend _ALL_ of your USB patches with a unique subject
line, _AND_ as a patch series as I have now dropped them all from my
review queue.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] gadget/udc: fix repeated words in comments
@ 2022-08-21 15:24 Jilin Yuan
  0 siblings, 0 replies; 5+ messages in thread
From: Jilin Yuan @ 2022-08-21 15:24 UTC (permalink / raw)
  To: balbi; +Cc: linux-usb, linux-arm-kernel, linux-kernel, Jilin Yuan

 Delete the redundant word 'also'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/usb/gadget/udc/at91_udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
index 728987280373..c80d0902bb30 100644
--- a/drivers/usb/gadget/udc/at91_udc.c
+++ b/drivers/usb/gadget/udc/at91_udc.c
@@ -994,7 +994,7 @@ static const struct usb_gadget_ops at91_udc_ops = {
 	.udc_stop		= at91_stop,
 
 	/*
-	 * VBUS-powered devices may also also want to support bigger
+	 * VBUS-powered devices may also want to support bigger
 	 * power budgets after an appropriate SET_CONFIGURATION.
 	 */
 	/* .vbus_power		= at91_vbus_power, */
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] gadget/udc: fix repeated words in comments
@ 2022-08-21 15:22 Jilin Yuan
  0 siblings, 0 replies; 5+ messages in thread
From: Jilin Yuan @ 2022-08-21 15:22 UTC (permalink / raw)
  To: balbi; +Cc: linux-usb, linux-kernel, Jilin Yuan

Delete the redundant word 'with'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/usb/gadget/udc/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
index 7886497253cc..8dd8fbd44d65 100644
--- a/drivers/usb/gadget/udc/core.c
+++ b/drivers/usb/gadget/udc/core.c
@@ -165,7 +165,7 @@ EXPORT_SYMBOL_GPL(usb_ep_disable);
 
 /**
  * usb_ep_alloc_request - allocate a request object to use with this endpoint
- * @ep:the endpoint to be used with with the request
+ * @ep:the endpoint to be used with the request
  * @gfp_flags:GFP_* flags to use
  *
  * Request objects must be allocated with this call, since they normally
@@ -900,7 +900,7 @@ EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
 
 /**
  * usb_gadget_giveback_request - give the request back to the gadget layer
- * @ep: the endpoint to be used with with the request
+ * @ep: the endpoint to be used with the request
  * @req: the request being given back
  *
  * This is called by device controller drivers in order to return the
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] gadget/udc: fix repeated words in comments
@ 2022-08-21 15:20 Jilin Yuan
  2022-08-22  6:14 ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Jilin Yuan @ 2022-08-21 15:20 UTC (permalink / raw)
  To: daniel, haojian.zhuang, robert.jarzmik, balbi
  Cc: linux-usb, linux-kernel, Jilin Yuan

 Delete the redundant word 'tell'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/usb/gadget/udc/pxa25x_udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c
index c593fc383481..176e2b157021 100644
--- a/drivers/usb/gadget/udc/pxa25x_udc.c
+++ b/drivers/usb/gadget/udc/pxa25x_udc.c
@@ -1737,7 +1737,7 @@ static void handle_ep0 (struct pxa25x_udc *dev)
 				/* hardware automagic preventing STALL... */
 				if (dev->req_config) {
 					/* hardware sometimes neglects to tell
-					 * tell us about config change events,
+					 * us about config change events,
 					 * so later ones may fail...
 					 */
 					WARNING("config change %02x fail %d?\n",
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-08-22 11:57 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-22 11:57 [PATCH] gadget/udc: fix repeated words in comments Jilin Yuan
  -- strict thread matches above, loose matches on Subject: below --
2022-08-21 15:24 Jilin Yuan
2022-08-21 15:22 Jilin Yuan
2022-08-21 15:20 Jilin Yuan
2022-08-22  6:14 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).