linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: "Peter Zijlstra" <peterz@infradead.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	"Jiri Olsa" <jolsa@kernel.org>,
	"Namhyung Kim" <namhyung@kernel.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Darren Hart" <dvhart@infradead.org>,
	"Davidlohr Bueso" <dave@stgolabs.net>,
	"André Almeida" <andrealmeid@igalia.com>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Tom Rix" <trix@redhat.com>, "Weiguo Li" <liwg06@foxmail.com>,
	"Athira Rajeev" <atrajeev@linux.vnet.ibm.com>,
	"Thomas Richter" <tmricht@linux.ibm.com>,
	"Ravi Bangoria" <ravi.bangoria@amd.com>,
	"Dario Petrillo" <dario.pk1@gmail.com>,
	Hewenliang <hewenliang4@huawei.com>,
	yaowenbin <yaowenbin1@huawei.com>,
	"Wenyu Liu" <liuwenyu7@huawei.com>,
	"Song Liu" <songliubraving@fb.com>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Dave Marchevsky" <davemarchevsky@fb.com>,
	"Leo Yan" <leo.yan@linaro.org>,
	"Kim Phillips" <kim.phillips@amd.com>,
	"Pavithra Gurushankar" <gpavithrasha@gmail.com>,
	"Alexandre Truong" <alexandre.truong@arm.com>,
	"Quentin Monnet" <quentin@isovalent.com>,
	"William Cohen" <wcohen@redhat.com>,
	"Andres Freund" <andres@anarazel.de>,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	"Martin Liška" <mliska@suse.cz>,
	"Colin Ian King" <colin.king@intel.com>,
	"James Clark" <james.clark@arm.com>,
	"Fangrui Song" <maskray@google.com>,
	"Stephane Eranian" <eranian@google.com>,
	"Kajol Jain" <kjain@linux.ibm.com>,
	"Alexey Bayduraev" <alexey.v.bayduraev@linux.intel.com>,
	"Riccardo Mancini" <rickyman7@gmail.com>,
	"Andi Kleen" <ak@linux.intel.com>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	"Zechuan Chen" <chenzechuan1@huawei.com>,
	"Jason Wang" <wangborong@cdjrlc.com>,
	"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
	"Remi Bernon" <rbernon@codeweavers.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	bpf@vger.kernel.org, llvm@lists.linux.dev
Cc: Ian Rogers <irogers@google.com>
Subject: [PATCH v3 04/18] perf hist: Update use of pthread mutex
Date: Wed, 24 Aug 2022 08:38:47 -0700	[thread overview]
Message-ID: <20220824153901.488576-5-irogers@google.com> (raw)
In-Reply-To: <20220824153901.488576-1-irogers@google.com>

Switch to the use of mutex wrappers that provide better error checking.

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/builtin-top.c | 8 ++++----
 tools/perf/util/hist.c   | 6 +++---
 tools/perf/util/hist.h   | 4 ++--
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index fd8fd913c533..14e60f6f219c 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -220,7 +220,7 @@ static void perf_top__record_precise_ip(struct perf_top *top,
 		 * This function is now called with he->hists->lock held.
 		 * Release it before going to sleep.
 		 */
-		pthread_mutex_unlock(&he->hists->lock);
+		mutex_unlock(&he->hists->lock);
 
 		if (err == -ERANGE && !he->ms.map->erange_warned)
 			ui__warn_map_erange(he->ms.map, sym, ip);
@@ -230,7 +230,7 @@ static void perf_top__record_precise_ip(struct perf_top *top,
 			sleep(1);
 		}
 
-		pthread_mutex_lock(&he->hists->lock);
+		mutex_lock(&he->hists->lock);
 	}
 }
 
@@ -836,12 +836,12 @@ static void perf_event__process_sample(struct perf_tool *tool,
 		else
 			iter.ops = &hist_iter_normal;
 
-		pthread_mutex_lock(&hists->lock);
+		mutex_lock(&hists->lock);
 
 		if (hist_entry_iter__add(&iter, &al, top->max_stack, top) < 0)
 			pr_err("Problem incrementing symbol period, skipping event\n");
 
-		pthread_mutex_unlock(&hists->lock);
+		mutex_unlock(&hists->lock);
 	}
 
 	addr_location__put(&al);
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index 1c085ab56534..698add038cec 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -1622,13 +1622,13 @@ struct rb_root_cached *hists__get_rotate_entries_in(struct hists *hists)
 {
 	struct rb_root_cached *root;
 
-	pthread_mutex_lock(&hists->lock);
+	mutex_lock(&hists->lock);
 
 	root = hists->entries_in;
 	if (++hists->entries_in > &hists->entries_in_array[1])
 		hists->entries_in = &hists->entries_in_array[0];
 
-	pthread_mutex_unlock(&hists->lock);
+	mutex_unlock(&hists->lock);
 
 	return root;
 }
@@ -2805,7 +2805,7 @@ int __hists__init(struct hists *hists, struct perf_hpp_list *hpp_list)
 	hists->entries_in = &hists->entries_in_array[0];
 	hists->entries_collapsed = RB_ROOT_CACHED;
 	hists->entries = RB_ROOT_CACHED;
-	pthread_mutex_init(&hists->lock, NULL);
+	mutex_init(&hists->lock);
 	hists->socket_filter = -1;
 	hists->hpp_list = hpp_list;
 	INIT_LIST_HEAD(&hists->hpp_formats);
diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h
index 7ed4648d2fc2..508428b2c1b2 100644
--- a/tools/perf/util/hist.h
+++ b/tools/perf/util/hist.h
@@ -4,10 +4,10 @@
 
 #include <linux/rbtree.h>
 #include <linux/types.h>
-#include <pthread.h>
 #include "evsel.h"
 #include "color.h"
 #include "events_stats.h"
+#include "mutex.h"
 
 struct hist_entry;
 struct hist_entry_ops;
@@ -98,7 +98,7 @@ struct hists {
 	const struct dso	*dso_filter;
 	const char		*uid_filter_str;
 	const char		*symbol_filter_str;
-	pthread_mutex_t		lock;
+	struct mutex		lock;
 	struct hists_stats	stats;
 	u64			event_stream;
 	u16			col_len[HISTC_NR_COLS];
-- 
2.37.2.609.g9ff673ca1a-goog


  parent reply	other threads:[~2022-08-24 15:40 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-24 15:38 [PATCH v3 00/18] Mutex wrapper, locking and memory leak fixes Ian Rogers
2022-08-24 15:38 ` [PATCH v3 01/18] perf mutex: Wrapped usage of mutex and cond Ian Rogers
2022-08-26  8:49   ` Adrian Hunter
2022-08-24 15:38 ` [PATCH v3 02/18] perf bench: Update use of pthread mutex/cond Ian Rogers
2022-08-24 15:38 ` [PATCH v3 03/18] perf tests: Avoid pthread.h inclusion Ian Rogers
2022-08-24 15:38 ` Ian Rogers [this message]
2022-08-24 15:38 ` [PATCH v3 05/18] perf bpf: Remove unused pthread.h include Ian Rogers
2022-08-24 15:38 ` [PATCH v3 06/18] perf lock: " Ian Rogers
2022-08-24 15:38 ` [PATCH v3 07/18] perf record: Update use of pthread mutex Ian Rogers
2022-08-24 15:38 ` [PATCH v3 08/18] perf sched: " Ian Rogers
2022-08-24 15:38 ` [PATCH v3 09/18] perf ui: " Ian Rogers
2022-08-26 10:11   ` Adrian Hunter
2022-08-26 16:01     ` Ian Rogers
2022-08-26 10:24   ` Adrian Hunter
2022-08-26 16:02     ` Ian Rogers
2022-08-26 17:22       ` Adrian Hunter
2022-08-26 17:45         ` Ian Rogers
2022-08-26 18:52           ` Adrian Hunter
2022-08-26 19:00             ` Namhyung Kim
2022-08-26 19:20               ` Adrian Hunter
2022-08-26 20:40                 ` Namhyung Kim
2022-08-26 20:52                   ` Ian Rogers
2022-08-27  7:11                     ` Adrian Hunter
2022-08-24 15:38 ` [PATCH v3 10/18] perf mmap: Remove unnecessary pthread.h include Ian Rogers
2022-08-24 15:38 ` [PATCH v3 11/18] perf dso: Update use of pthread mutex Ian Rogers
2022-08-26 10:37   ` Adrian Hunter
2022-08-26 16:05     ` Ian Rogers
2022-08-26 17:34       ` Adrian Hunter
2022-08-26 17:46         ` Ian Rogers
2022-08-24 15:38 ` [PATCH v3 12/18] perf annotate: " Ian Rogers
2022-08-24 15:38 ` [PATCH v3 13/18] perf top: " Ian Rogers
2022-08-24 15:38 ` [PATCH v3 14/18] perf dso: Hold lock when accessing nsinfo Ian Rogers
2022-08-24 15:38 ` [PATCH v3 15/18] perf mutex: Add thread safety annotations Ian Rogers
2022-08-26 11:12   ` Adrian Hunter
2022-08-26 16:45   ` Arnaldo Carvalho de Melo
2022-08-26 17:00     ` Ian Rogers
2022-08-26 19:13       ` Arnaldo Carvalho de Melo
2022-08-24 15:38 ` [PATCH v3 16/18] perf sched: Fixes for thread safety analysis Ian Rogers
2022-08-26 12:12   ` Adrian Hunter
2022-08-26 16:06     ` Ian Rogers
2022-08-26 17:41       ` Adrian Hunter
2022-08-26 17:48         ` Ian Rogers
2022-08-26 18:26           ` Namhyung Kim
2022-08-26 19:35             ` Adrian Hunter
2022-08-26 20:48               ` Namhyung Kim
2022-08-24 15:39 ` [PATCH v3 17/18] perf top: " Ian Rogers
2022-08-24 15:39 ` [PATCH v3 18/18] perf build: Enable -Wthread-safety with clang Ian Rogers
     [not found] ` <CA+JHD906M0truH7wPNZ=eJwdCA=qLhYDonUx_ZQBwJYpiX1hNg@mail.gmail.com>
2022-08-25 16:14   ` [PATCH v3 00/18] Mutex wrapper, locking and memory leak fixes Adrian Hunter
2022-08-26 12:36     ` Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220824153901.488576-5-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexandre.truong@arm.com \
    --cc=alexey.v.bayduraev@linux.intel.com \
    --cc=andrealmeid@igalia.com \
    --cc=andres@anarazel.de \
    --cc=andrii@kernel.org \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=bpf@vger.kernel.org \
    --cc=chenzechuan1@huawei.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=colin.king@intel.com \
    --cc=dario.pk1@gmail.com \
    --cc=dave@stgolabs.net \
    --cc=davemarchevsky@fb.com \
    --cc=dvhart@infradead.org \
    --cc=eranian@google.com \
    --cc=gpavithrasha@gmail.com \
    --cc=hewenliang4@huawei.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@kernel.org \
    --cc=kim.phillips@amd.com \
    --cc=kjain@linux.ibm.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=liuwenyu7@huawei.com \
    --cc=liwg06@foxmail.com \
    --cc=llvm@lists.linux.dev \
    --cc=mark.rutland@arm.com \
    --cc=maskray@google.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mliska@suse.cz \
    --cc=namhyung@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=peterz@infradead.org \
    --cc=quentin@isovalent.com \
    --cc=ravi.bangoria@amd.com \
    --cc=rbernon@codeweavers.com \
    --cc=rickyman7@gmail.com \
    --cc=songliubraving@fb.com \
    --cc=tglx@linutronix.de \
    --cc=tmricht@linux.ibm.com \
    --cc=trix@redhat.com \
    --cc=wangborong@cdjrlc.com \
    --cc=wcohen@redhat.com \
    --cc=yaowenbin1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).