From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Ian Rogers <irogers@google.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Darren Hart" <dvhart@infradead.org>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"André Almeida" <andrealmeid@igalia.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Tom Rix" <trix@redhat.com>, "Weiguo Li" <liwg06@foxmail.com>,
"Athira Rajeev" <atrajeev@linux.vnet.ibm.com>,
"Thomas Richter" <tmricht@linux.ibm.com>,
"Ravi Bangoria" <ravi.bangoria@amd.com>,
"Dario Petrillo" <dario.pk1@gmail.com>,
Hewenliang <hewenliang4@huawei.com>,
yaowenbin <yaowenbin1@huawei.com>,
"Wenyu Liu" <liuwenyu7@huawei.com>,
"Song Liu" <songliubraving@fb.com>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Dave Marchevsky" <davemarchevsky@fb.com>,
"Leo Yan" <leo.yan@linaro.org>,
"Kim Phillips" <kim.phillips@amd.com>,
"Pavithra Gurushankar" <gpavithrasha@gmail.com>,
"Alexandre Truong" <alexandre.truong@arm.com>,
"Quentin Monnet" <quentin@isovalent.com>,
"William Cohen" <wcohen@redhat.com>,
"Andres Freund" <andres@anarazel.de>,
"Martin Liška" <mliska@suse.cz>,
"Colin Ian King" <colin.king@intel.com>,
"James Clark" <james.clark@arm.com>,
"Fangrui Song" <maskray@google.com>,
"Stephane Eranian" <eranian@google.com>,
"Kajol Jain" <kjain@linux.ibm.com>,
"Alexey Bayduraev" <alexey.v.bayduraev@linux.intel.com>,
"Riccardo Mancini" <rickyman7@gmail.com>,
"Andi Kleen" <ak@linux.intel.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Zechuan Chen" <chenzechuan1@huawei.com>,
"Jason Wang" <wangborong@cdjrlc.com>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"Remi Bernon" <rbernon@codeweavers.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-perf-users <linux-perf-users@vger.kernel.org>,
bpf <bpf@vger.kernel.org>,
llvm@lists.linux.dev
Subject: Re: [PATCH v3 00/18] Mutex wrapper, locking and memory leak fixes
Date: Fri, 26 Aug 2022 15:36:46 +0300 [thread overview]
Message-ID: <fd249ce0-f065-e522-d6c7-72985367cc53@intel.com> (raw)
In-Reply-To: <c422c9b3-d6e2-e1d5-5273-6a720fdde6c4@intel.com>
On 25/08/22 19:14, Adrian Hunter wrote:
> On 25/08/22 15:30, Arnaldo Carvalho de Melo wrote:
>> On Wed, Aug 24, 2022, 12:39 PM Ian Rogers <irogers@google.com <mailto:irogers@google.com>> wrote:
>>
>> When fixing a locking race and memory leak in:
>> https://lore.kernel.org/linux-perf-users/20211118193714.2293728-1-irogers@google.com/ <https://lore.kernel.org/linux-perf-users/20211118193714.2293728-1-irogers@google.com/>
>>
>> It was requested that debug mutex code be separated out into its own
>> files. This was, in part, done by Pavithra Gurushankar in:
>> https://lore.kernel.org/lkml/20220727111954.105118-1-gpavithrasha@gmail.com/ <https://lore.kernel.org/lkml/20220727111954.105118-1-gpavithrasha@gmail.com/>
>>
>> These patches fix issues with the previous patches, add in the
>> original dso->nsinfo fix and then build on our mutex wrapper with
>> clang's -Wthread-safety analysis. The analysis found missing unlocks
>> in builtin-sched.c which are fixed and -Wthread-safety is enabled by
>> default when building with clang.
>>
>> v3. Adds a missing new line to the error messages and removes the
>> pshared argument to mutex_init by having two functions, mutex_init
>> and mutex_init_pshared. These changes were suggested by Adrian Hunter.
>>
>>
>> Adrian, can I have your Acked-by or, better, Reviewed-by?
>
> Sure, just let me have another look. Should get to it
> tomorrow.
Looks good but a couple of things that need to be fixed up.
>
>>
>> Thanks,
>>
>> - Arnaldo
>>
>> v2. Breaks apart changes that s/pthread_mutex/mutex/g and the lock
>> annotations as requested by Arnaldo and Namhyung. A boolean is
>> added to builtin-sched.c to terminate thread funcs rather than
>> leaving them blocked on delted mutexes.
>>
>> Ian Rogers (17):
>> perf bench: Update use of pthread mutex/cond
>> perf tests: Avoid pthread.h inclusion
>> perf hist: Update use of pthread mutex
>> perf bpf: Remove unused pthread.h include
>> perf lock: Remove unused pthread.h include
>> perf record: Update use of pthread mutex
>> perf sched: Update use of pthread mutex
>> perf ui: Update use of pthread mutex
>> perf mmap: Remove unnecessary pthread.h include
>> perf dso: Update use of pthread mutex
>> perf annotate: Update use of pthread mutex
>> perf top: Update use of pthread mutex
>> perf dso: Hold lock when accessing nsinfo
>> perf mutex: Add thread safety annotations
>> perf sched: Fixes for thread safety analysis
>> perf top: Fixes for thread safety analysis
>> perf build: Enable -Wthread-safety with clang
>>
>> Pavithra Gurushankar (1):
>> perf mutex: Wrapped usage of mutex and cond
>>
>> tools/perf/Makefile.config | 5 +
>> tools/perf/bench/epoll-ctl.c | 33 +++---
>> tools/perf/bench/epoll-wait.c | 33 +++---
>> tools/perf/bench/futex-hash.c | 33 +++---
>> tools/perf/bench/futex-lock-pi.c | 33 +++---
>> tools/perf/bench/futex-requeue.c | 33 +++---
>> tools/perf/bench/futex-wake-parallel.c | 33 +++---
>> tools/perf/bench/futex-wake.c | 33 +++---
>> tools/perf/bench/numa.c | 93 ++++++----------
>> tools/perf/builtin-inject.c | 4 +
>> tools/perf/builtin-lock.c | 1 -
>> tools/perf/builtin-record.c | 13 ++-
>> tools/perf/builtin-sched.c | 105 +++++++++---------
>> tools/perf/builtin-top.c | 45 ++++----
>> tools/perf/tests/mmap-basic.c | 2 -
>> tools/perf/tests/openat-syscall-all-cpus.c | 2 +-
>> tools/perf/tests/perf-record.c | 2 -
>> tools/perf/ui/browser.c | 20 ++--
>> tools/perf/ui/browsers/annotate.c | 12 +--
>> tools/perf/ui/setup.c | 5 +-
>> tools/perf/ui/tui/helpline.c | 5 +-
>> tools/perf/ui/tui/progress.c | 8 +-
>> tools/perf/ui/tui/setup.c | 8 +-
>> tools/perf/ui/tui/util.c | 18 ++--
>> tools/perf/ui/ui.h | 4 +-
>> tools/perf/util/Build | 1 +
>> tools/perf/util/annotate.c | 15 +--
>> tools/perf/util/annotate.h | 4 +-
>> tools/perf/util/bpf-event.h | 1 -
>> tools/perf/util/build-id.c | 12 ++-
>> tools/perf/util/dso.c | 19 ++--
>> tools/perf/util/dso.h | 4 +-
>> tools/perf/util/hist.c | 6 +-
>> tools/perf/util/hist.h | 4 +-
>> tools/perf/util/map.c | 3 +
>> tools/perf/util/mmap.h | 1 -
>> tools/perf/util/mutex.c | 119 +++++++++++++++++++++
>> tools/perf/util/mutex.h | 109 +++++++++++++++++++
>> tools/perf/util/probe-event.c | 3 +
>> tools/perf/util/symbol.c | 4 +-
>> tools/perf/util/top.h | 5 +-
>> 41 files changed, 570 insertions(+), 323 deletions(-)
>> create mode 100644 tools/perf/util/mutex.c
>> create mode 100644 tools/perf/util/mutex.h
>>
>> --
>> 2.37.2.609.g9ff673ca1a-goog
>>
>
prev parent reply other threads:[~2022-08-26 12:37 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 15:38 [PATCH v3 00/18] Mutex wrapper, locking and memory leak fixes Ian Rogers
2022-08-24 15:38 ` [PATCH v3 01/18] perf mutex: Wrapped usage of mutex and cond Ian Rogers
2022-08-26 8:49 ` Adrian Hunter
2022-08-24 15:38 ` [PATCH v3 02/18] perf bench: Update use of pthread mutex/cond Ian Rogers
2022-08-24 15:38 ` [PATCH v3 03/18] perf tests: Avoid pthread.h inclusion Ian Rogers
2022-08-24 15:38 ` [PATCH v3 04/18] perf hist: Update use of pthread mutex Ian Rogers
2022-08-24 15:38 ` [PATCH v3 05/18] perf bpf: Remove unused pthread.h include Ian Rogers
2022-08-24 15:38 ` [PATCH v3 06/18] perf lock: " Ian Rogers
2022-08-24 15:38 ` [PATCH v3 07/18] perf record: Update use of pthread mutex Ian Rogers
2022-08-24 15:38 ` [PATCH v3 08/18] perf sched: " Ian Rogers
2022-08-24 15:38 ` [PATCH v3 09/18] perf ui: " Ian Rogers
2022-08-26 10:11 ` Adrian Hunter
2022-08-26 16:01 ` Ian Rogers
2022-08-26 10:24 ` Adrian Hunter
2022-08-26 16:02 ` Ian Rogers
2022-08-26 17:22 ` Adrian Hunter
2022-08-26 17:45 ` Ian Rogers
2022-08-26 18:52 ` Adrian Hunter
2022-08-26 19:00 ` Namhyung Kim
2022-08-26 19:20 ` Adrian Hunter
2022-08-26 20:40 ` Namhyung Kim
2022-08-26 20:52 ` Ian Rogers
2022-08-27 7:11 ` Adrian Hunter
2022-08-24 15:38 ` [PATCH v3 10/18] perf mmap: Remove unnecessary pthread.h include Ian Rogers
2022-08-24 15:38 ` [PATCH v3 11/18] perf dso: Update use of pthread mutex Ian Rogers
2022-08-26 10:37 ` Adrian Hunter
2022-08-26 16:05 ` Ian Rogers
2022-08-26 17:34 ` Adrian Hunter
2022-08-26 17:46 ` Ian Rogers
2022-08-24 15:38 ` [PATCH v3 12/18] perf annotate: " Ian Rogers
2022-08-24 15:38 ` [PATCH v3 13/18] perf top: " Ian Rogers
2022-08-24 15:38 ` [PATCH v3 14/18] perf dso: Hold lock when accessing nsinfo Ian Rogers
2022-08-24 15:38 ` [PATCH v3 15/18] perf mutex: Add thread safety annotations Ian Rogers
2022-08-26 11:12 ` Adrian Hunter
2022-08-26 16:45 ` Arnaldo Carvalho de Melo
2022-08-26 17:00 ` Ian Rogers
2022-08-26 19:13 ` Arnaldo Carvalho de Melo
2022-08-24 15:38 ` [PATCH v3 16/18] perf sched: Fixes for thread safety analysis Ian Rogers
2022-08-26 12:12 ` Adrian Hunter
2022-08-26 16:06 ` Ian Rogers
2022-08-26 17:41 ` Adrian Hunter
2022-08-26 17:48 ` Ian Rogers
2022-08-26 18:26 ` Namhyung Kim
2022-08-26 19:35 ` Adrian Hunter
2022-08-26 20:48 ` Namhyung Kim
2022-08-24 15:39 ` [PATCH v3 17/18] perf top: " Ian Rogers
2022-08-24 15:39 ` [PATCH v3 18/18] perf build: Enable -Wthread-safety with clang Ian Rogers
[not found] ` <CA+JHD906M0truH7wPNZ=eJwdCA=qLhYDonUx_ZQBwJYpiX1hNg@mail.gmail.com>
2022-08-25 16:14 ` [PATCH v3 00/18] Mutex wrapper, locking and memory leak fixes Adrian Hunter
2022-08-26 12:36 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd249ce0-f065-e522-d6c7-72985367cc53@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandre.truong@arm.com \
--cc=alexey.v.bayduraev@linux.intel.com \
--cc=andrealmeid@igalia.com \
--cc=andres@anarazel.de \
--cc=andrii@kernel.org \
--cc=arnaldo.melo@gmail.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=chenzechuan1@huawei.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=colin.king@intel.com \
--cc=dario.pk1@gmail.com \
--cc=dave@stgolabs.net \
--cc=davemarchevsky@fb.com \
--cc=dvhart@infradead.org \
--cc=eranian@google.com \
--cc=gpavithrasha@gmail.com \
--cc=hewenliang4@huawei.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kim.phillips@amd.com \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=liuwenyu7@huawei.com \
--cc=liwg06@foxmail.com \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=maskray@google.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mliska@suse.cz \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=quentin@isovalent.com \
--cc=ravi.bangoria@amd.com \
--cc=rbernon@codeweavers.com \
--cc=rickyman7@gmail.com \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
--cc=tmricht@linux.ibm.com \
--cc=trix@redhat.com \
--cc=wangborong@cdjrlc.com \
--cc=wcohen@redhat.com \
--cc=yaowenbin1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).