* [PATCH v3 1/4] ARM: dts: integratorap: Update spi node properties
2022-03-12 11:38 [PATCH v3 0/4] DT fixes for pl022 for arm platforms Kuldeep Singh
@ 2022-03-12 11:38 ` Kuldeep Singh
2022-03-24 22:07 ` Linus Walleij
2022-03-12 11:38 ` [PATCH v3 2/4] ARM: dts: realview: Update spi clock-names property Kuldeep Singh
` (2 subsequent siblings)
3 siblings, 1 reply; 12+ messages in thread
From: Kuldeep Singh @ 2022-03-12 11:38 UTC (permalink / raw)
To: Linus Walleij, Rob Herring; +Cc: linux-arm-kernel, devicetree, linux-kernel
As per spi pl022 binding, SPI clock name is "sspclk" and not "spiclk".
Fix it.
Also update ssp node name to enable spi bindings check.
Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
---
v3:
- Reword commit message
v2:
-Remove ssp alias
arch/arm/boot/dts/integratorap-im-pd1.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/integratorap-im-pd1.dts b/arch/arm/boot/dts/integratorap-im-pd1.dts
index d47bfb66d069..4c22e4436271 100644
--- a/arch/arm/boot/dts/integratorap-im-pd1.dts
+++ b/arch/arm/boot/dts/integratorap-im-pd1.dts
@@ -178,12 +178,12 @@ uart@200000 {
clock-names = "uartclk", "apb_pclk";
};
- ssp@300000 {
+ spi@300000 {
compatible = "arm,pl022", "arm,primecell";
reg = <0x00300000 0x1000>;
interrupts-extended = <&impd1_vic 3>;
clocks = <&impd1_sspclk>, <&sysclk>;
- clock-names = "spiclk", "apb_pclk";
+ clock-names = "sspclk", "apb_pclk";
};
impd1_gpio0: gpio@400000 {
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/4] ARM: dts: integratorap: Update spi node properties
2022-03-12 11:38 ` [PATCH v3 1/4] ARM: dts: integratorap: Update spi node properties Kuldeep Singh
@ 2022-03-24 22:07 ` Linus Walleij
2022-08-10 19:46 ` Rob Herring
0 siblings, 1 reply; 12+ messages in thread
From: Linus Walleij @ 2022-03-24 22:07 UTC (permalink / raw)
To: Kuldeep Singh; +Cc: Rob Herring, linux-arm-kernel, devicetree, linux-kernel
On Sat, Mar 12, 2022 at 12:39 PM Kuldeep Singh
<singh.kuldeep87k@gmail.com> wrote:
> As per spi pl022 binding, SPI clock name is "sspclk" and not "spiclk".
> Fix it.
>
> Also update ssp node name to enable spi bindings check.
>
> Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> ---
> v3:
> - Reword commit message
This and patches 2, 3/4 applied to the versatile DTS branch.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/4] ARM: dts: integratorap: Update spi node properties
2022-03-24 22:07 ` Linus Walleij
@ 2022-08-10 19:46 ` Rob Herring
2022-08-15 17:30 ` Kuldeep Singh
2022-08-24 22:14 ` Linus Walleij
0 siblings, 2 replies; 12+ messages in thread
From: Rob Herring @ 2022-08-10 19:46 UTC (permalink / raw)
To: Linus Walleij; +Cc: Kuldeep Singh, linux-arm-kernel, devicetree, linux-kernel
On Thu, Mar 24, 2022 at 4:07 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Sat, Mar 12, 2022 at 12:39 PM Kuldeep Singh
> <singh.kuldeep87k@gmail.com> wrote:
>
> > As per spi pl022 binding, SPI clock name is "sspclk" and not "spiclk".
> > Fix it.
> >
> > Also update ssp node name to enable spi bindings check.
> >
> > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> > ---
> > v3:
> > - Reword commit message
>
> This and patches 2, 3/4 applied to the versatile DTS branch.
What happened to this?
Rob
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/4] ARM: dts: integratorap: Update spi node properties
2022-08-10 19:46 ` Rob Herring
@ 2022-08-15 17:30 ` Kuldeep Singh
2022-08-24 22:15 ` Linus Walleij
2022-08-24 22:14 ` Linus Walleij
1 sibling, 1 reply; 12+ messages in thread
From: Kuldeep Singh @ 2022-08-15 17:30 UTC (permalink / raw)
To: Rob Herring; +Cc: Linus Walleij, linux-arm-kernel, devicetree, linux-kernel
> > This and patches 2, 3/4 applied to the versatile DTS branch.
>
> What happened to this?
Thanks Rob for pointing this out, I lost track for these changes.
I just noticed Linus applied ste-dbx change only and skipped others(integrator,
realview, versatile).
These patches fix clock-name as per pl022 binding which causes no harm.
Linus, Any reason to skip others?
Regards
Kuldeep
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/4] ARM: dts: integratorap: Update spi node properties
2022-08-15 17:30 ` Kuldeep Singh
@ 2022-08-24 22:15 ` Linus Walleij
2022-08-25 3:01 ` Kuldeep Singh
0 siblings, 1 reply; 12+ messages in thread
From: Linus Walleij @ 2022-08-24 22:15 UTC (permalink / raw)
To: Kuldeep Singh; +Cc: Rob Herring, linux-arm-kernel, devicetree, linux-kernel
On Mon, Aug 15, 2022 at 7:30 PM Kuldeep Singh
<singh.kuldeep87k@gmail.com> wrote:
>
> > > This and patches 2, 3/4 applied to the versatile DTS branch.
> >
> > What happened to this?
>
> Thanks Rob for pointing this out, I lost track for these changes.
> I just noticed Linus applied ste-dbx change only and skipped others(integrator,
> realview, versatile).
>
> These patches fix clock-name as per pl022 binding which causes no harm.
> Linus, Any reason to skip others?
I just forgot to send them. I'll fix.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/4] ARM: dts: integratorap: Update spi node properties
2022-08-24 22:15 ` Linus Walleij
@ 2022-08-25 3:01 ` Kuldeep Singh
0 siblings, 0 replies; 12+ messages in thread
From: Kuldeep Singh @ 2022-08-25 3:01 UTC (permalink / raw)
To: Linus Walleij; +Cc: Rob Herring, linux-arm-kernel, devicetree, linux-kernel
On Thu, Aug 25, 2022 at 12:15:17AM +0200, Linus Walleij wrote:
> On Mon, Aug 15, 2022 at 7:30 PM Kuldeep Singh
> <singh.kuldeep87k@gmail.com> wrote:
> >
> > > > This and patches 2, 3/4 applied to the versatile DTS branch.
> > >
> > > What happened to this?
> >
> > Thanks Rob for pointing this out, I lost track for these changes.
> > I just noticed Linus applied ste-dbx change only and skipped others(integrator,
> > realview, versatile).
> >
> > These patches fix clock-name as per pl022 binding which causes no harm.
> > Linus, Any reason to skip others?
>
> I just forgot to send them. I'll fix.
Ok np. Thanks!
--
Kuldeep
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/4] ARM: dts: integratorap: Update spi node properties
2022-08-10 19:46 ` Rob Herring
2022-08-15 17:30 ` Kuldeep Singh
@ 2022-08-24 22:14 ` Linus Walleij
1 sibling, 0 replies; 12+ messages in thread
From: Linus Walleij @ 2022-08-24 22:14 UTC (permalink / raw)
To: Rob Herring; +Cc: Kuldeep Singh, linux-arm-kernel, devicetree, linux-kernel
On Wed, Aug 10, 2022 at 9:47 PM Rob Herring <robh+dt@kernel.org> wrote:
> On Thu, Mar 24, 2022 at 4:07 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> > On Sat, Mar 12, 2022 at 12:39 PM Kuldeep Singh
> > <singh.kuldeep87k@gmail.com> wrote:
> >
> > > As per spi pl022 binding, SPI clock name is "sspclk" and not "spiclk".
> > > Fix it.
> > >
> > > Also update ssp node name to enable spi bindings check.
> > >
> > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> > > ---
> > > v3:
> > > - Reword commit message
> >
> > This and patches 2, 3/4 applied to the versatile DTS branch.
>
> What happened to this?
I forgot to send them upstream this merge window :/
Simple as that.
I'll send them pronto.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 2/4] ARM: dts: realview: Update spi clock-names property
2022-03-12 11:38 [PATCH v3 0/4] DT fixes for pl022 for arm platforms Kuldeep Singh
2022-03-12 11:38 ` [PATCH v3 1/4] ARM: dts: integratorap: Update spi node properties Kuldeep Singh
@ 2022-03-12 11:38 ` Kuldeep Singh
2022-03-12 11:38 ` [PATCH v3 3/4] ARM: dts: versatile: " Kuldeep Singh
2022-03-12 11:38 ` [PATCH v3 4/4] ARM: dts: ste-dbx: " Kuldeep Singh
3 siblings, 0 replies; 12+ messages in thread
From: Kuldeep Singh @ 2022-03-12 11:38 UTC (permalink / raw)
To: Linus Walleij, Rob Herring; +Cc: linux-arm-kernel, devicetree, linux-kernel
Now that spi pl022 binding only accept "sspclk" as clock name, realview
platforms with "SSPCLK" clock name start raising dtbs_check warnings.
Make necessary changes to update this property in order to make it
compliant with binding.
clock-names:0: 'sspclk' was expected
Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
---
v3:
- Reword commit message
v2:
- Split patches as per platform
arch/arm/boot/dts/arm-realview-eb.dtsi | 2 +-
arch/arm/boot/dts/arm-realview-pb1176.dts | 2 +-
arch/arm/boot/dts/arm-realview-pb11mp.dts | 2 +-
arch/arm/boot/dts/arm-realview-pbx.dtsi | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/arm-realview-eb.dtsi b/arch/arm/boot/dts/arm-realview-eb.dtsi
index 2dfb32bf9d48..fbb2258b451f 100644
--- a/arch/arm/boot/dts/arm-realview-eb.dtsi
+++ b/arch/arm/boot/dts/arm-realview-eb.dtsi
@@ -399,7 +399,7 @@ ssp: spi@1000d000 {
compatible = "arm,pl022", "arm,primecell";
reg = <0x1000d000 0x1000>;
clocks = <&sspclk>, <&pclk>;
- clock-names = "SSPCLK", "apb_pclk";
+ clock-names = "sspclk", "apb_pclk";
};
wdog: watchdog@10010000 {
diff --git a/arch/arm/boot/dts/arm-realview-pb1176.dts b/arch/arm/boot/dts/arm-realview-pb1176.dts
index 06b8723b09eb..efed325af88d 100644
--- a/arch/arm/boot/dts/arm-realview-pb1176.dts
+++ b/arch/arm/boot/dts/arm-realview-pb1176.dts
@@ -410,7 +410,7 @@ pb1176_ssp: spi@1010b000 {
interrupt-parent = <&intc_dc1176>;
interrupts = <0 17 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&sspclk>, <&pclk>;
- clock-names = "SSPCLK", "apb_pclk";
+ clock-names = "sspclk", "apb_pclk";
};
pb1176_serial0: serial@1010c000 {
diff --git a/arch/arm/boot/dts/arm-realview-pb11mp.dts b/arch/arm/boot/dts/arm-realview-pb11mp.dts
index 295aef448123..89103d54ecc1 100644
--- a/arch/arm/boot/dts/arm-realview-pb11mp.dts
+++ b/arch/arm/boot/dts/arm-realview-pb11mp.dts
@@ -555,7 +555,7 @@ spi@1000d000 {
interrupt-parent = <&intc_pb11mp>;
interrupts = <0 11 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&sspclk>, <&pclk>;
- clock-names = "SSPCLK", "apb_pclk";
+ clock-names = "sspclk", "apb_pclk";
};
watchdog@1000f000 {
diff --git a/arch/arm/boot/dts/arm-realview-pbx.dtsi b/arch/arm/boot/dts/arm-realview-pbx.dtsi
index 6f61f968d689..ec1507c5147c 100644
--- a/arch/arm/boot/dts/arm-realview-pbx.dtsi
+++ b/arch/arm/boot/dts/arm-realview-pbx.dtsi
@@ -390,7 +390,7 @@ ssp: spi@1000d000 {
compatible = "arm,pl022", "arm,primecell";
reg = <0x1000d000 0x1000>;
clocks = <&sspclk>, <&pclk>;
- clock-names = "SSPCLK", "apb_pclk";
+ clock-names = "sspclk", "apb_pclk";
};
wdog0: watchdog@1000f000 {
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 3/4] ARM: dts: versatile: Update spi clock-names property
2022-03-12 11:38 [PATCH v3 0/4] DT fixes for pl022 for arm platforms Kuldeep Singh
2022-03-12 11:38 ` [PATCH v3 1/4] ARM: dts: integratorap: Update spi node properties Kuldeep Singh
2022-03-12 11:38 ` [PATCH v3 2/4] ARM: dts: realview: Update spi clock-names property Kuldeep Singh
@ 2022-03-12 11:38 ` Kuldeep Singh
2022-03-12 11:38 ` [PATCH v3 4/4] ARM: dts: ste-dbx: " Kuldeep Singh
3 siblings, 0 replies; 12+ messages in thread
From: Kuldeep Singh @ 2022-03-12 11:38 UTC (permalink / raw)
To: Linus Walleij, Rob Herring; +Cc: linux-arm-kernel, devicetree, linux-kernel
Now that spi pl022 binding only accept "sspclk" as clock name, versatile
platform with "SSPCLK" clock name start raising dtbs_check warnings.
Make necessary changes to update this property in order to make it
compliant with binding.
clock-names:0: 'sspclk' was expected
Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
---
v3:
- Reword commit message
v2:
- Split patches as per platform
arch/arm/boot/dts/versatile-ab.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/versatile-ab.dts b/arch/arm/boot/dts/versatile-ab.dts
index 79f7cc241282..a520615f4d8d 100644
--- a/arch/arm/boot/dts/versatile-ab.dts
+++ b/arch/arm/boot/dts/versatile-ab.dts
@@ -391,7 +391,7 @@ spi@101f4000 {
reg = <0x101f4000 0x1000>;
interrupts = <11>;
clocks = <&xtal24mhz>, <&pclk>;
- clock-names = "SSPCLK", "apb_pclk";
+ clock-names = "sspclk", "apb_pclk";
};
fpga {
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 4/4] ARM: dts: ste-dbx: Update spi clock-names property
2022-03-12 11:38 [PATCH v3 0/4] DT fixes for pl022 for arm platforms Kuldeep Singh
` (2 preceding siblings ...)
2022-03-12 11:38 ` [PATCH v3 3/4] ARM: dts: versatile: " Kuldeep Singh
@ 2022-03-12 11:38 ` Kuldeep Singh
2022-03-14 22:28 ` Linus Walleij
3 siblings, 1 reply; 12+ messages in thread
From: Kuldeep Singh @ 2022-03-12 11:38 UTC (permalink / raw)
To: Linus Walleij, Rob Herring; +Cc: linux-arm-kernel, devicetree, linux-kernel
Now that spi pl022 binding only accept "sspclk" as clock name, ST
ericsson platform with "SSPCLK" clock name start raising dtbs_check
warnings. Make necessary changes to update this property in order to
make it compliant with binding.
clock-names:0: 'sspclk' was expected
Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
---
v3:
- Reword commit message
v2:
- Split patches as per platform
arch/arm/boot/dts/ste-dbx5x0.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/ste-dbx5x0.dtsi b/arch/arm/boot/dts/ste-dbx5x0.dtsi
index dc0bcc7020f1..c28b32640254 100644
--- a/arch/arm/boot/dts/ste-dbx5x0.dtsi
+++ b/arch/arm/boot/dts/ste-dbx5x0.dtsi
@@ -755,7 +755,7 @@ ssp0: spi@80002000 {
#address-cells = <1>;
#size-cells = <0>;
clocks = <&prcc_kclk 3 1>, <&prcc_pclk 3 1>;
- clock-names = "SSPCLK", "apb_pclk";
+ clock-names = "sspclk", "apb_pclk";
dmas = <&dma 8 0 0x2>, /* Logical - DevToMem */
<&dma 8 0 0x0>; /* Logical - MemToDev */
dma-names = "rx", "tx";
@@ -772,7 +772,7 @@ ssp1: spi@80003000 {
#address-cells = <1>;
#size-cells = <0>;
clocks = <&prcc_kclk 3 2>, <&prcc_pclk 3 2>;
- clock-names = "SSPCLK", "apb_pclk";
+ clock-names = "sspclk", "apb_pclk";
dmas = <&dma 9 0 0x2>, /* Logical - DevToMem */
<&dma 9 0 0x0>; /* Logical - MemToDev */
dma-names = "rx", "tx";
@@ -790,7 +790,7 @@ spi0: spi@8011a000 {
#size-cells = <0>;
/* Same clock wired to kernel and pclk */
clocks = <&prcc_pclk 2 8>, <&prcc_pclk 2 8>;
- clock-names = "SSPCLK", "apb_pclk";
+ clock-names = "sspclk", "apb_pclk";
dmas = <&dma 0 0 0x2>, /* Logical - DevToMem */
<&dma 0 0 0x0>; /* Logical - MemToDev */
dma-names = "rx", "tx";
@@ -807,7 +807,7 @@ spi1: spi@80112000 {
#size-cells = <0>;
/* Same clock wired to kernel and pclk */
clocks = <&prcc_pclk 2 2>, <&prcc_pclk 2 2>;
- clock-names = "SSPCLK", "apb_pclk";
+ clock-names = "sspclk", "apb_pclk";
dmas = <&dma 35 0 0x2>, /* Logical - DevToMem */
<&dma 35 0 0x0>; /* Logical - MemToDev */
dma-names = "rx", "tx";
@@ -824,7 +824,7 @@ spi2: spi@80111000 {
#size-cells = <0>;
/* Same clock wired to kernel and pclk */
clocks = <&prcc_pclk 2 1>, <&prcc_pclk 2 1>;
- clock-names = "SSPCLK", "apb_pclk";
+ clock-names = "sspclk", "apb_pclk";
dmas = <&dma 33 0 0x2>, /* Logical - DevToMem */
<&dma 33 0 0x0>; /* Logical - MemToDev */
dma-names = "rx", "tx";
@@ -841,7 +841,7 @@ spi3: spi@80129000 {
#size-cells = <0>;
/* Same clock wired to kernel and pclk */
clocks = <&prcc_pclk 1 7>, <&prcc_pclk 1 7>;
- clock-names = "SSPCLK", "apb_pclk";
+ clock-names = "sspclk", "apb_pclk";
dmas = <&dma 40 0 0x2>, /* Logical - DevToMem */
<&dma 40 0 0x0>; /* Logical - MemToDev */
dma-names = "rx", "tx";
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v3 4/4] ARM: dts: ste-dbx: Update spi clock-names property
2022-03-12 11:38 ` [PATCH v3 4/4] ARM: dts: ste-dbx: " Kuldeep Singh
@ 2022-03-14 22:28 ` Linus Walleij
0 siblings, 0 replies; 12+ messages in thread
From: Linus Walleij @ 2022-03-14 22:28 UTC (permalink / raw)
To: Kuldeep Singh; +Cc: Rob Herring, linux-arm-kernel, devicetree, linux-kernel
On Sat, Mar 12, 2022 at 12:39 PM Kuldeep Singh
<singh.kuldeep87k@gmail.com> wrote:
> Now that spi pl022 binding only accept "sspclk" as clock name, ST
> ericsson platform with "SSPCLK" clock name start raising dtbs_check
> warnings. Make necessary changes to update this property in order to
> make it compliant with binding.
>
> clock-names:0: 'sspclk' was expected
>
> Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> ---
> v3:
> - Reword commit message
Patch applied to the ux500 tree!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 12+ messages in thread