From: Michael Walle <michael@walle.cc>
To: "Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Shawn Guo" <shawnguo@kernel.org>, "Li Yang" <leoyang.li@nxp.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Frank Rowand" <frowand.list@gmail.com>
Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
Michael Walle <michael@walle.cc>
Subject: [PATCH v1 00/14] nvmem: core: introduce NVMEM layouts
Date: Thu, 25 Aug 2022 23:44:09 +0200 [thread overview]
Message-ID: <20220825214423.903672-1-michael@walle.cc> (raw)
This is now the third attempt to fetch the MAC addresses from the VPD
for the Kontron sl28 boards. Previous discussions can be found here:
https://lore.kernel.org/lkml/20211228142549.1275412-1-michael@walle.cc/
NVMEM cells are typically added by board code or by the devicetree. But
as the cells get more complex, there is (valid) push back from the
devicetree maintainers to not put that handling in the devicetree.
Therefore, introduce NVMEM layouts. They operate on the NVMEM device and
can add cells during runtime. That way it is possible to add complex
cells than it is possible right now with the offset/length/bits
description in the device tree. For example, you can have post processing
for individual cells (think of endian swapping, or ethernet offset
handling). You can also have cells which have no static offset, like the
ones in an u-boot environment. The last patches will convert the current
u-boot environment driver to a NVMEM layout and lifting the restriction
that it only works with mtd devices. But as it will change the required
compatible strings, it is marked as RFC for now. It also needs to have
its device tree schema update which is left out here.
For now, the layouts are selected by a specifc compatible string in a
device tree. E.g. the VPD on the kontron sl28 do (within a SPI flash node):
compatible = "kontron,sl28-vpd", "user-otp";
or if you'd use the u-boot environment (within an MTD patition):
compatible = "u-boot,env", "nvmem";
The "user-otp" (or "nvmem") will lead to a NVMEM device, the
"kontron,sl28-vpd" (or "u-boot,env") will then apply the specific layout
on top of the NVMEM device.
NVMEM layouts as modules?
While possible in principle, it doesn't make any sense because the NVMEM
core can't be compiled as a module. The layouts needs to be available at
probe time. (That is also the reason why they get registered with
subsys_initcall().) So if the NVMEM core would be a module, the layouts
could be modules, too.
Michael Walle (14):
net: add helper eth_addr_add()
of: base: add of_parse_phandle_with_optional_args()
nvmem: core: add an index parameter to the cell
nvmem: core: drop the removal of the cells in nvmem_add_cells()
nvmem: core: add nvmem_add_one_cell()
nvmem: core: introduce NVMEM layouts
nvmem: core: add per-cell post processing
dt-bindings: mtd: relax the nvmem compatible string
dt-bindings: nvmem: add YAML schema for the sl28 vpd layout
nvmem: layouts: add sl28vpd layout
nvmem: core: export nvmem device size
nvmem: layouts: rewrite the u-boot-env driver as a NVMEM layout
nvmem: layouts: u-boot-env: add device node
arm64: dts: ls1028a: sl28: get MAC addresses from VPD
.../devicetree/bindings/mtd/mtd.yaml | 7 +-
.../nvmem/layouts/kontron,sl28-vpd.yaml | 52 +++++
.../fsl-ls1028a-kontron-kbox-a-230-ls.dts | 8 +
.../fsl-ls1028a-kontron-sl28-var1.dts | 2 +
.../fsl-ls1028a-kontron-sl28-var2.dts | 4 +
.../fsl-ls1028a-kontron-sl28-var4.dts | 2 +
.../freescale/fsl-ls1028a-kontron-sl28.dts | 13 ++
drivers/nvmem/Kconfig | 2 +
drivers/nvmem/Makefile | 1 +
drivers/nvmem/core.c | 183 +++++++++++----
drivers/nvmem/imx-ocotp.c | 4 +-
drivers/nvmem/layouts/Kconfig | 22 ++
drivers/nvmem/layouts/Makefile | 7 +
drivers/nvmem/layouts/sl28vpd.c | 144 ++++++++++++
drivers/nvmem/layouts/u-boot-env.c | 147 ++++++++++++
drivers/nvmem/u-boot-env.c | 218 ------------------
include/linux/etherdevice.h | 14 ++
include/linux/nvmem-consumer.h | 11 +
include/linux/nvmem-provider.h | 47 +++-
include/linux/of.h | 25 ++
20 files changed, 649 insertions(+), 264 deletions(-)
create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml
create mode 100644 drivers/nvmem/layouts/Kconfig
create mode 100644 drivers/nvmem/layouts/Makefile
create mode 100644 drivers/nvmem/layouts/sl28vpd.c
create mode 100644 drivers/nvmem/layouts/u-boot-env.c
delete mode 100644 drivers/nvmem/u-boot-env.c
--
2.30.2
next reply other threads:[~2022-08-25 21:44 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 21:44 Michael Walle [this message]
2022-08-25 21:44 ` [PATCH v1 01/14] net: add helper eth_addr_add() Michael Walle
2022-09-01 16:26 ` Michael Walle
2022-09-01 16:31 ` Andrew Lunn
2022-09-01 19:54 ` Jakub Kicinski
2022-08-25 21:44 ` [PATCH v1 02/14] of: base: add of_parse_phandle_with_optional_args() Michael Walle
2022-08-25 21:44 ` [PATCH v1 03/14] nvmem: core: add an index parameter to the cell Michael Walle
2022-08-25 21:44 ` [PATCH v1 04/14] nvmem: core: drop the removal of the cells in nvmem_add_cells() Michael Walle
2022-08-25 21:44 ` [PATCH v1 05/14] nvmem: core: add nvmem_add_one_cell() Michael Walle
2022-08-25 21:44 ` [PATCH v1 06/14] nvmem: core: introduce NVMEM layouts Michael Walle
2022-08-26 8:16 ` Michael Walle
2022-08-28 14:06 ` Rafał Miłecki
2022-08-28 14:33 ` Michael Walle
2022-08-30 13:36 ` Srinivas Kandagatla
2022-08-30 14:24 ` Michael Walle
2022-08-30 14:43 ` Srinivas Kandagatla
2022-08-30 15:02 ` Michael Walle
2022-08-30 15:23 ` Srinivas Kandagatla
2022-08-25 21:44 ` [PATCH v1 07/14] nvmem: core: add per-cell post processing Michael Walle
2022-08-30 13:37 ` Srinivas Kandagatla
2022-08-30 14:20 ` Michael Walle
2022-08-25 21:44 ` [PATCH v1 08/14] dt-bindings: mtd: relax the nvmem compatible string Michael Walle
2022-08-31 7:37 ` Krzysztof Kozlowski
2022-08-31 7:48 ` Michael Walle
2022-08-31 7:55 ` Krzysztof Kozlowski
2022-08-31 21:48 ` Rob Herring
2022-08-31 22:30 ` Michael Walle
2022-09-02 14:46 ` Rob Herring
2022-08-25 21:44 ` [PATCH v1 09/14] dt-bindings: nvmem: add YAML schema for the sl28 vpd layout Michael Walle
2022-08-26 16:05 ` Rob Herring
2022-08-31 7:45 ` Krzysztof Kozlowski
2022-08-31 8:17 ` Michael Walle
2022-08-31 9:24 ` Krzysztof Kozlowski
2022-08-31 9:51 ` Michael Walle
2022-08-31 13:07 ` Krzysztof Kozlowski
2022-08-31 15:29 ` Michael Walle
2022-08-25 21:44 ` [PATCH v1 10/14] nvmem: layouts: add sl28vpd layout Michael Walle
2022-08-25 21:44 ` [PATCH v1 11/14] nvmem: core: export nvmem device size Michael Walle
2022-08-25 21:44 ` [RFC PATCH v1 12/14] nvmem: layouts: rewrite the u-boot-env driver as a NVMEM layout Michael Walle
2022-08-28 14:04 ` Rafał Miłecki
2022-08-28 14:42 ` Michael Walle
2022-08-25 21:44 ` [RFC PATCH v1 13/14] nvmem: layouts: u-boot-env: add device node Michael Walle
2022-08-28 13:55 ` Rafał Miłecki
2022-08-28 14:36 ` Michael Walle
2022-08-25 21:44 ` [PATCH v1 14/14] arm64: dts: ls1028a: sl28: get MAC addresses from VPD Michael Walle
2022-08-28 15:05 ` [PATCH v1 00/14] nvmem: core: introduce NVMEM layouts Rafał Miłecki
2022-08-29 8:22 ` Michael Walle
2022-08-30 13:37 ` Srinivas Kandagatla
2022-08-31 7:48 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220825214423.903672-1-michael@walle.cc \
--to=michael@walle.cc \
--cc=a.fatoum@pengutronix.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=frowand.list@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).