linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net: sched: using TCQ_MIN_PRIO_BANDS in prio_tune()
@ 2022-08-26  4:10 Zhengchao Shao
  2022-08-29  5:50 ` Cong Wang
  2022-08-30 11:30 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Zhengchao Shao @ 2022-08-26  4:10 UTC (permalink / raw)
  To: netdev, linux-kernel, davem, edumazet, kuba, pabeni, jhs,
	xiyou.wangcong, jiri
  Cc: weiyongjun1, yuehaibing, shaozhengchao

Using TCQ_MIN_PRIO_BANDS instead of magic number in prio_tune().

Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
---
 net/sched/sch_prio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sched/sch_prio.c b/net/sched/sch_prio.c
index 3b8d7197c06b..fbbd4f7015be 100644
--- a/net/sched/sch_prio.c
+++ b/net/sched/sch_prio.c
@@ -187,7 +187,7 @@ static int prio_tune(struct Qdisc *sch, struct nlattr *opt,
 		return -EINVAL;
 	qopt = nla_data(opt);
 
-	if (qopt->bands > TCQ_PRIO_BANDS || qopt->bands < 2)
+	if (qopt->bands > TCQ_PRIO_BANDS || qopt->bands < TCQ_MIN_PRIO_BANDS)
 		return -EINVAL;
 
 	for (i = 0; i <= TC_PRIO_MAX; i++) {
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: sched: using TCQ_MIN_PRIO_BANDS in prio_tune()
  2022-08-26  4:10 [PATCH net-next] net: sched: using TCQ_MIN_PRIO_BANDS in prio_tune() Zhengchao Shao
@ 2022-08-29  5:50 ` Cong Wang
  2022-08-30 11:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Cong Wang @ 2022-08-29  5:50 UTC (permalink / raw)
  To: Zhengchao Shao
  Cc: netdev, linux-kernel, davem, edumazet, kuba, pabeni, jhs, jiri,
	weiyongjun1, yuehaibing

On Fri, Aug 26, 2022 at 12:10:35PM +0800, Zhengchao Shao wrote:
> Using TCQ_MIN_PRIO_BANDS instead of magic number in prio_tune().
> 
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>

Acked-by: Cong Wang <xiyou.wangcong@gmail.com>

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: sched: using TCQ_MIN_PRIO_BANDS in prio_tune()
  2022-08-26  4:10 [PATCH net-next] net: sched: using TCQ_MIN_PRIO_BANDS in prio_tune() Zhengchao Shao
  2022-08-29  5:50 ` Cong Wang
@ 2022-08-30 11:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-08-30 11:30 UTC (permalink / raw)
  To: Zhengchao Shao
  Cc: netdev, linux-kernel, davem, edumazet, kuba, pabeni, jhs,
	xiyou.wangcong, jiri, weiyongjun1, yuehaibing

Hello:

This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Fri, 26 Aug 2022 12:10:35 +0800 you wrote:
> Using TCQ_MIN_PRIO_BANDS instead of magic number in prio_tune().
> 
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
>  net/sched/sch_prio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [net-next] net: sched: using TCQ_MIN_PRIO_BANDS in prio_tune()
    https://git.kernel.org/netdev/net-next/c/4b7477f0921a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-08-30 11:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-26  4:10 [PATCH net-next] net: sched: using TCQ_MIN_PRIO_BANDS in prio_tune() Zhengchao Shao
2022-08-29  5:50 ` Cong Wang
2022-08-30 11:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).