* [RESEND PATCH] dt-bindings: crypto: ti,sa2ul: drop dma-coherent property
@ 2022-08-26 9:11 Jayesh Choudhary
2022-08-29 20:02 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Jayesh Choudhary @ 2022-08-26 9:11 UTC (permalink / raw)
To: herbert
Cc: davem, robh+dt, krzysztof.kozlowski+dt, j-keerthy, linux-crypto,
devicetree, linux-kernel
crypto driver itself is not dma-coherent. It is the dmaengine
that moves data and the buffers are to be mapped to the
dmaengine provider. So this property should be dropped.
Fixes: 2ce9a7299bf6 ('dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation')
Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
---
Resending the patch as it got ACK-ed but did not get MERGED.
(https://lore.kernel.org/all/2935fd8e-ceda-fec9-db47-65d3ec142e32@linaro.org/)
We get some warnings which are expected. I will post the dt-node
fixes once this patch gets merged.
.../devicetree/bindings/crypto/ti,sa2ul.yaml | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
index 02f47c2e7998..0c15fefb6671 100644
--- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
+++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
@@ -35,8 +35,6 @@ properties:
- const: rx1
- const: rx2
- dma-coherent: true
-
"#address-cells":
const: 2
@@ -72,16 +70,6 @@ required:
- dmas
- dma-names
-if:
- properties:
- compatible:
- enum:
- - ti,j721e-sa2ul
- - ti,am654-sa2ul
-then:
- required:
- - dma-coherent
-
additionalProperties: false
examples:
@@ -95,5 +83,4 @@ examples:
dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
<&main_udmap 0x4001>;
dma-names = "tx", "rx1", "rx2";
- dma-coherent;
};
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH] dt-bindings: crypto: ti,sa2ul: drop dma-coherent property
2022-08-26 9:11 [RESEND PATCH] dt-bindings: crypto: ti,sa2ul: drop dma-coherent property Jayesh Choudhary
@ 2022-08-29 20:02 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2022-08-29 20:02 UTC (permalink / raw)
To: Jayesh Choudhary
Cc: linux-kernel, linux-crypto, krzysztof.kozlowski+dt, davem,
devicetree, robh+dt, herbert, j-keerthy
On Fri, 26 Aug 2022 14:41:42 +0530, Jayesh Choudhary wrote:
> crypto driver itself is not dma-coherent. It is the dmaengine
> that moves data and the buffers are to be mapped to the
> dmaengine provider. So this property should be dropped.
>
> Fixes: 2ce9a7299bf6 ('dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation')
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> ---
>
> Resending the patch as it got ACK-ed but did not get MERGED.
> (https://lore.kernel.org/all/2935fd8e-ceda-fec9-db47-65d3ec142e32@linaro.org/)
> We get some warnings which are expected. I will post the dt-node
> fixes once this patch gets merged.
>
> .../devicetree/bindings/crypto/ti,sa2ul.yaml | 13 -------------
> 1 file changed, 13 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-29 20:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-26 9:11 [RESEND PATCH] dt-bindings: crypto: ti,sa2ul: drop dma-coherent property Jayesh Choudhary
2022-08-29 20:02 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).