* [PATCH v2] arm64: dts: meson-s4: include meson-s4-gpio.h
@ 2022-08-26 12:23 Huqiang Qin
2022-08-26 17:40 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Huqiang Qin @ 2022-08-26 12:23 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, narmstrong, khilman, jbrunet,
martin.blumenstingl
Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel, Huqiang Qin
In the future, meson-s4.dtsi will have some nodes that need
to use the meson-s4-gpio.h file.
e.g.
* Bluetooth enable pin:
bt_en-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
* Audio mute pin:
spk_mute-gpios = <&gpio GPIOH_8 GPIO_ACTIVE_LOW>;
* ...
Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
---
arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
index ad50cba42d19..44cce8b0fcef 100644
--- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
@@ -6,6 +6,7 @@
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/gpio/meson-s4-gpio.h>
/ {
cpus {
--
2.37.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: meson-s4: include meson-s4-gpio.h
2022-08-26 12:23 [PATCH v2] arm64: dts: meson-s4: include meson-s4-gpio.h Huqiang Qin
@ 2022-08-26 17:40 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-26 17:40 UTC (permalink / raw)
To: Huqiang Qin, robh+dt, krzysztof.kozlowski+dt, narmstrong,
khilman, jbrunet, martin.blumenstingl
Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
On 26/08/2022 15:23, Huqiang Qin wrote:
> In the future, meson-s4.dtsi will have some nodes that need
> to use the meson-s4-gpio.h file.
>
> e.g.
> * Bluetooth enable pin:
> bt_en-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
> * Audio mute pin:
> spk_mute-gpios = <&gpio GPIOH_8 GPIO_ACTIVE_LOW>;
> * ...
Then the header should be added when the need is implemented. Do not add
unused headers to files.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: meson-s4: include meson-s4-gpio.h
@ 2022-08-29 4:35 Huqiang Qin
0 siblings, 0 replies; 3+ messages in thread
From: Huqiang Qin @ 2022-08-29 4:35 UTC (permalink / raw)
To: Krzysztof Kozlowski, robh+dt, krzysztof.kozlowski+dt, narmstrong,
khilman, jbrunet, martin.blumenstingl
Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Hi Krzysztof,
On 2022/8/27 1:40, Krzysztof Kozlowski wrote:
> Then the header should be added when the need is implemented. Do not add
> unused headers to files.
I understand, thank you very much.
Best regards,
Huqiang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-29 4:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-26 12:23 [PATCH v2] arm64: dts: meson-s4: include meson-s4-gpio.h Huqiang Qin
2022-08-26 17:40 ` Krzysztof Kozlowski
2022-08-29 4:35 Huqiang Qin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).