* [PATCH] virt: sev-guest: fix kconfig warnings
@ 2022-08-28 19:52 Randy Dunlap
2022-11-03 6:23 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2022-08-28 19:52 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, stable, Brijesh Singh,
Paul Gazzillo, Necip Fazil Yildiran, Borislav Petkov,
Tom Lendacky, linux-crypto
Fix the SEV_GUEST Kconfig block to eliminate kconfig unmet
dependency warnings:
WARNING: unmet direct dependencies detected for CRYPTO_GCM
Depends on [n]: CRYPTO [=n]
Selected by [y]:
- SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
Depends on [n]: CRYPTO [=n]
Selected by [y]:
- SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: stable@vger.kernel.org
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Paul Gazzillo <paul@pgazz.com>
Cc: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: linux-crypto@vger.kernel.org
---
drivers/virt/coco/sev-guest/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/virt/coco/sev-guest/Kconfig
+++ b/drivers/virt/coco/sev-guest/Kconfig
@@ -2,6 +2,7 @@ config SEV_GUEST
tristate "AMD SEV Guest driver"
default m
depends on AMD_MEM_ENCRYPT
+ select CRYPTO
select CRYPTO_AEAD2
select CRYPTO_GCM
help
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] virt: sev-guest: fix kconfig warnings
2022-08-28 19:52 [PATCH] virt: sev-guest: fix kconfig warnings Randy Dunlap
@ 2022-11-03 6:23 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2022-11-03 6:23 UTC (permalink / raw)
To: linux-kernel
Cc: kernel test robot, stable, Brijesh Singh, Paul Gazzillo,
Necip Fazil Yildiran, Borislav Petkov, Tom Lendacky,
linux-crypto
ping. I have verified (on linux-next-20221103) that this
patch is still needed.
Thanks.
On 8/28/22 12:52, Randy Dunlap wrote:
> Fix the SEV_GUEST Kconfig block to eliminate kconfig unmet
> dependency warnings:
>
> WARNING: unmet direct dependencies detected for CRYPTO_GCM
> Depends on [n]: CRYPTO [=n]
> Selected by [y]:
> - SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
>
> WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
> Depends on [n]: CRYPTO [=n]
> Selected by [y]:
> - SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
>
> Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: stable@vger.kernel.org
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Paul Gazzillo <paul@pgazz.com>
> Cc: Necip Fazil Yildiran <fazilyildiran@gmail.com>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: linux-crypto@vger.kernel.org
> ---
> drivers/virt/coco/sev-guest/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/virt/coco/sev-guest/Kconfig
> +++ b/drivers/virt/coco/sev-guest/Kconfig
> @@ -2,6 +2,7 @@ config SEV_GUEST
> tristate "AMD SEV Guest driver"
> default m
> depends on AMD_MEM_ENCRYPT
> + select CRYPTO
> select CRYPTO_AEAD2
> select CRYPTO_GCM
> help
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] virt: sev-guest: fix kconfig warnings
@ 2023-05-29 23:13 Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-05-29 23:13 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, Brijesh Singh, Paul Gazzillo,
Necip Fazil Yildiran, Tom Lendacky, linux-crypto, Herbert Xu,
David S. Miller
kconfig complains about unmet dependencies for SEV_GUEST
whenever CRYPTO is not set/enabled, so also select CRYPTO
when selecting other crypto kconfig options to silence the
warnings.
Quietens these warnings:
WARNING: unmet direct dependencies detected for CRYPTO_GCM
Depends on [n]: CRYPTO [=n]
Selected by [y]:
- SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
Depends on [n]: CRYPTO [=n]
Selected by [y]:
- SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Link: lore.kernel.org/r/202305300557.PJ5ao694-lkp@intel.com
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Paul Gazzillo <paul@pgazz.com>
Cc: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: linux-crypto@vger.kernel.org
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
---
drivers/virt/coco/sev-guest/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -- a/drivers/virt/coco/sev-guest/Kconfig b/drivers/virt/coco/sev-guest/Kconfig
--- a/drivers/virt/coco/sev-guest/Kconfig
+++ b/drivers/virt/coco/sev-guest/Kconfig
@@ -2,6 +2,7 @@ config SEV_GUEST
tristate "AMD SEV Guest driver"
default m
depends on AMD_MEM_ENCRYPT
+ select CRYPTO
select CRYPTO_AEAD2
select CRYPTO_GCM
help
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-29 23:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-28 19:52 [PATCH] virt: sev-guest: fix kconfig warnings Randy Dunlap
2022-11-03 6:23 ` Randy Dunlap
2023-05-29 23:13 Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).