* [PATCH -next 1/2] xfs: replace unnecessary seq_printf with seq_puts
@ 2022-08-29 3:42 Zeng Heng
2022-08-29 14:47 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Zeng Heng @ 2022-08-29 3:42 UTC (permalink / raw)
To: djwong; +Cc: linux-xfs, linux-kernel, zengheng4
Replace seq_printf with seq_puts when const string
in reference, which would avoid to deal with
unnecessary string format.
Signed-off-by: Zeng Heng <zengheng4@huawei.com>
---
fs/xfs/xfs_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_stats.c b/fs/xfs/xfs_stats.c
index 20e0534a772c..70d38b77682b 100644
--- a/fs/xfs/xfs_stats.c
+++ b/fs/xfs/xfs_stats.c
@@ -125,7 +125,7 @@ static int xqmstat_proc_show(struct seq_file *m, void *v)
{
int j;
- seq_printf(m, "qm");
+ seq_puts(m, "qm");
for (j = XFSSTAT_START_XQMSTAT; j < XFSSTAT_END_XQMSTAT; j++)
seq_printf(m, " %u", counter_val(xfsstats.xs_stats, j));
seq_putc(m, '\n');
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next 1/2] xfs: replace unnecessary seq_printf with seq_puts
2022-08-29 3:42 [PATCH -next 1/2] xfs: replace unnecessary seq_printf with seq_puts Zeng Heng
@ 2022-08-29 14:47 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2022-08-29 14:47 UTC (permalink / raw)
To: Zeng Heng; +Cc: linux-xfs, linux-kernel
On Mon, Aug 29, 2022 at 11:42:17AM +0800, Zeng Heng wrote:
> Replace seq_printf with seq_puts when const string
> in reference, which would avoid to deal with
> unnecessary string format.
>
> Signed-off-by: Zeng Heng <zengheng4@huawei.com>
Looks ok,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_stats.c b/fs/xfs/xfs_stats.c
> index 20e0534a772c..70d38b77682b 100644
> --- a/fs/xfs/xfs_stats.c
> +++ b/fs/xfs/xfs_stats.c
> @@ -125,7 +125,7 @@ static int xqmstat_proc_show(struct seq_file *m, void *v)
> {
> int j;
>
> - seq_printf(m, "qm");
> + seq_puts(m, "qm");
> for (j = XFSSTAT_START_XQMSTAT; j < XFSSTAT_END_XQMSTAT; j++)
> seq_printf(m, " %u", counter_val(xfsstats.xs_stats, j));
> seq_putc(m, '\n');
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-29 14:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-29 3:42 [PATCH -next 1/2] xfs: replace unnecessary seq_printf with seq_puts Zeng Heng
2022-08-29 14:47 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).