* linux-next: build warning after merge of the usb.current tree
@ 2022-08-31 5:24 Stephen Rothwell
2022-08-31 14:25 ` Alan Stern
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2022-08-31 5:24 UTC (permalink / raw)
To: Greg KH
Cc: Alan Stern, Greg Kroah-Hartman, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 360 bytes --]
Hi all,
After merging the usb.current tree, today's linux-next build (htmldocs)
produced this warning:
Documentation/driver-api/usb/usb:176: /home/sfr/next/next/drivers/usb/core/hub.c:6040: WARNING: Unknown target name: "pre".
Introduced by commit
9c6d778800b9 ("USB: core: Prevent nested device-reset calls")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: build warning after merge of the usb.current tree
2022-08-31 5:24 linux-next: build warning after merge of the usb.current tree Stephen Rothwell
@ 2022-08-31 14:25 ` Alan Stern
2022-08-31 21:50 ` Stephen Rothwell
0 siblings, 1 reply; 7+ messages in thread
From: Alan Stern @ 2022-08-31 14:25 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Greg KH, Greg Kroah-Hartman, Linux Kernel Mailing List,
Linux Next Mailing List
On Wed, Aug 31, 2022 at 03:24:58PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the usb.current tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/driver-api/usb/usb:176: /home/sfr/next/next/drivers/usb/core/hub.c:6040: WARNING: Unknown target name: "pre".
>
> Introduced by commit
>
> 9c6d778800b9 ("USB: core: Prevent nested device-reset calls")
I don't fully understand this bug report. Would it be fixed by changing
"pre_" to "pre_reset()" in the kerneldoc?
Alan Stern
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: build warning after merge of the usb.current tree
2022-08-31 14:25 ` Alan Stern
@ 2022-08-31 21:50 ` Stephen Rothwell
2022-09-01 14:36 ` [PATCH] USB: core: Fix RST error in hub.c Alan Stern
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2022-08-31 21:50 UTC (permalink / raw)
To: Alan Stern
Cc: Greg KH, Greg Kroah-Hartman, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
Hi Alan,
On Wed, 31 Aug 2022 10:25:37 -0400 Alan Stern <stern@rowland.harvard.edu> wrote:
>
> On Wed, Aug 31, 2022 at 03:24:58PM +1000, Stephen Rothwell wrote:
> >
> > After merging the usb.current tree, today's linux-next build (htmldocs)
> > produced this warning:
> >
> > Documentation/driver-api/usb/usb:176: /home/sfr/next/next/drivers/usb/core/hub.c:6040: WARNING: Unknown target name: "pre".
> >
> > Introduced by commit
> >
> > 9c6d778800b9 ("USB: core: Prevent nested device-reset calls")
>
> I don't fully understand this bug report. Would it be fixed by changing
> "pre_" to "pre_reset()" in the kerneldoc?
I would presume so.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] USB: core: Fix RST error in hub.c
2022-08-31 21:50 ` Stephen Rothwell
@ 2022-09-01 14:36 ` Alan Stern
2022-09-05 3:13 ` Bagas Sanjaya
0 siblings, 1 reply; 7+ messages in thread
From: Alan Stern @ 2022-09-01 14:36 UTC (permalink / raw)
To: Greg KH, Stephen Rothwell
Cc: USB mailing list, Linux Kernel Mailing List, Linux Next Mailing List
A recent commit added an invalid RST expression to a kerneldoc comment
in hub.c. The fix is trivial.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Fixes: 9c6d778800b9 ("USB: core: Prevent nested device-reset calls")
Cc: <stable@vger.kernel.org>
---
[as1987]
drivers/usb/core/hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: usb-devel/drivers/usb/core/hub.c
===================================================================
--- usb-devel.orig/drivers/usb/core/hub.c
+++ usb-devel/drivers/usb/core/hub.c
@@ -6039,7 +6039,7 @@ re_enumerate:
*
* Return: The same as for usb_reset_and_verify_device().
* However, if a reset is already in progress (for instance, if a
- * driver doesn't have pre_ or post_reset() callbacks, and while
+ * driver doesn't have pre_reset() or post_reset() callbacks, and while
* being unbound or re-bound during the ongoing reset its disconnect()
* or probe() routine tries to perform a second, nested reset), the
* routine returns -EINPROGRESS.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] USB: core: Fix RST error in hub.c
2022-09-01 14:36 ` [PATCH] USB: core: Fix RST error in hub.c Alan Stern
@ 2022-09-05 3:13 ` Bagas Sanjaya
0 siblings, 0 replies; 7+ messages in thread
From: Bagas Sanjaya @ 2022-09-05 3:13 UTC (permalink / raw)
To: Alan Stern, Greg KH, Stephen Rothwell
Cc: USB mailing list, Linux Kernel Mailing List, Linux Next Mailing List
On 9/1/22 21:36, Alan Stern wrote:
> A recent commit added an invalid RST expression to a kerneldoc comment
> in hub.c. The fix is trivial.
>
htmldocs warning at that file successfully fixed, thanks!
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: build warning after merge of the usb.current tree
2012-01-25 0:20 linux-next: build warning after merge of the usb.current tree Stephen Rothwell
@ 2012-01-25 0:33 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2012-01-25 0:33 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Fabio Estevam
On Wed, Jan 25, 2012 at 11:20:23AM +1100, Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the usb.current tree, today's linux-next build (x86_64_allmodconfig)
> produced this warning:
>
> drivers/usb/host/Kconfig:559:error: recursive dependency detected!
> drivers/usb/host/Kconfig:559: symbol USB_HWA_HCD depends on UWB
> drivers/uwb/Kconfig:5: symbol UWB is selected by USB_WUSB
> drivers/usb/wusbcore/Kconfig:4: symbol USB_WUSB is selected by USB_HWA_HCD
>
> Introduced by commit 0dd2b62ada6f ("drivers: usb: Fix dependency for
> USB_HWA_HCD").
Yeah, I just reverted that about 30 minutes, you must have pulled before
I pushed that change out.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* linux-next: build warning after merge of the usb.current tree
@ 2012-01-25 0:20 Stephen Rothwell
2012-01-25 0:33 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2012-01-25 0:20 UTC (permalink / raw)
To: Greg KH; +Cc: linux-next, linux-kernel, Fabio Estevam
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
Hi Greg,
After merging the usb.current tree, today's linux-next build (x86_64_allmodconfig)
produced this warning:
drivers/usb/host/Kconfig:559:error: recursive dependency detected!
drivers/usb/host/Kconfig:559: symbol USB_HWA_HCD depends on UWB
drivers/uwb/Kconfig:5: symbol UWB is selected by USB_WUSB
drivers/usb/wusbcore/Kconfig:4: symbol USB_WUSB is selected by USB_HWA_HCD
Introduced by commit 0dd2b62ada6f ("drivers: usb: Fix dependency for
USB_HWA_HCD").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-09-05 3:13 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-31 5:24 linux-next: build warning after merge of the usb.current tree Stephen Rothwell
2022-08-31 14:25 ` Alan Stern
2022-08-31 21:50 ` Stephen Rothwell
2022-09-01 14:36 ` [PATCH] USB: core: Fix RST error in hub.c Alan Stern
2022-09-05 3:13 ` Bagas Sanjaya
-- strict thread matches above, loose matches on Subject: below --
2012-01-25 0:20 linux-next: build warning after merge of the usb.current tree Stephen Rothwell
2012-01-25 0:33 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).