* [PATCH v3 1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360
@ 2022-09-01 2:49 Yunlong Jia
2022-09-01 2:49 ` [PATCH v3 2/2] arm64: dts: qcom: Add sc7180-pazquel360 Yunlong Jia
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Yunlong Jia @ 2022-09-01 2:49 UTC (permalink / raw)
To: LKML
Cc: Bob Moragues, Douglas Anderson, Henry Sun, Yunlong Jia,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski,
Rob Herring, devicetree, linux-arm-msm
pazquel360 is an extension project based on pazquel.
We create 3 sku on pazquel360:
sku 20 for LTE with physical SIM _and_ eSIM and WiFi
sku 21 for WiFi only
sku 22 for LTE with only a physical SIM
Both sku20 and sku22 are LTE SKUs.
One has the eSIM stuffed and one doesn't.
There is a single shared device tree for the two.
Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v3:
1. Adjust the format of the changelog.
---
Documentation/devicetree/bindings/arm/qcom.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index fb1d00bcc847..851cf5edb582 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -459,6 +459,17 @@ properties:
- const: google,pazquel-sku2
- const: qcom,sc7180
+ - description: Google Pazquel360 with LTE (newest rev)
+ items:
+ - const: google,pazquel-sku22
+ - const: google,pazquel-sku20
+ - const: qcom,sc7180
+
+ - description: Google Pazquel360 with WiFi (newest rev)
+ items:
+ - const: google,pazquel-sku21
+ - const: qcom,sc7180
+
- description: Sharp Dynabook Chromebook C1 (rev1)
items:
- const: google,pompom-rev1
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v3 2/2] arm64: dts: qcom: Add sc7180-pazquel360 2022-09-01 2:49 [PATCH v3 1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 Yunlong Jia @ 2022-09-01 2:49 ` Yunlong Jia 2022-09-06 22:26 ` [PATCH v3 1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 Doug Anderson 2022-10-18 3:15 ` (subset) " Bjorn Andersson 2 siblings, 0 replies; 5+ messages in thread From: Yunlong Jia @ 2022-09-01 2:49 UTC (permalink / raw) To: LKML Cc: Bob Moragues, Douglas Anderson, Henry Sun, Yunlong Jia, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm Create first version device tree for pazquel360 pazquel360 is convertible and the pazquel it is based on is clamshell. sku 20 for lte & wifi sku 21 for wifi only sku 22 for lte w/o esim & wifi Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com> Reviewed-by: Douglas Anderson <dianders@chromium.org> --- (no changes since v2) Changes in v2: 1. Remove the touchscreen setting, as a follow-up patch --- arch/arm64/boot/dts/qcom/Makefile | 2 + .../qcom/sc7180-trogdor-pazquel360-lte.dts | 22 ++++++++ .../qcom/sc7180-trogdor-pazquel360-wifi.dts | 17 +++++++ .../dts/qcom/sc7180-trogdor-pazquel360.dtsi | 50 +++++++++++++++++++ 4 files changed, 91 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-lte.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-wifi.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 1d86a33de528..9f736702e06f 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -84,6 +84,8 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel-lte-parade.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel-lte-ti.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel-parade.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel-ti.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel360-lte.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel360-wifi.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r1.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r1-lte.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r2.dtb diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-lte.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-lte.dts new file mode 100644 index 000000000000..021bcafcf815 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-lte.dts @@ -0,0 +1,22 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Google Pazquel board device tree source + * + * Copyright 2021 Google LLC. + */ + +/dts-v1/; + +#include "sc7180-trogdor.dtsi" +#include "sc7180-trogdor-parade-ps8640.dtsi" +#include "sc7180-trogdor-pazquel360.dtsi" +#include "sc7180-trogdor-lte-sku.dtsi" + +/ { + model = "Google Pazquel (Parade,LTE)"; + compatible = "google,pazquel-sku22", "google,pazquel-sku20", "qcom,sc7180"; +}; + +&ap_sar_sensor_i2c { + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-wifi.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-wifi.dts new file mode 100644 index 000000000000..defd84c5354a --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-wifi.dts @@ -0,0 +1,17 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Google Pazquel board device tree source + * + * Copyright 2022 Google LLC. + */ + +/dts-v1/; + +#include "sc7180-trogdor.dtsi" +#include "sc7180-trogdor-parade-ps8640.dtsi" +#include "sc7180-trogdor-pazquel360.dtsi" + +/ { + model = "Google Pazquel (Parade,WIFI-only)"; + compatible = "google,pazquel-sku21", "qcom,sc7180"; +}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi new file mode 100644 index 000000000000..5702325d0c7b --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi @@ -0,0 +1,50 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Google Pazquel board device tree source + * + * Copyright 2021 Google LLC. + */ + +/* This file must be included after sc7180-trogdor.dtsi */ +#include "sc7180-trogdor-pazquel.dtsi" + +&alc5682 { + compatible = "realtek,rt5682s"; + realtek,dmic1-clk-pin = <2>; + realtek,dmic-clk-rate-hz = <2048000>; +}; + +&keyboard_controller { + function-row-physmap = < + MATRIX_KEY(0x00, 0x02, 0) /* T1 */ + MATRIX_KEY(0x03, 0x02, 0) /* T2 */ + MATRIX_KEY(0x02, 0x02, 0) /* T3 */ + MATRIX_KEY(0x01, 0x02, 0) /* T4 */ + MATRIX_KEY(0x03, 0x04, 0) /* T5 */ + MATRIX_KEY(0x02, 0x04, 0) /* T6 */ + MATRIX_KEY(0x01, 0x04, 0) /* T7 */ + MATRIX_KEY(0x02, 0x09, 0) /* T8 */ + MATRIX_KEY(0x01, 0x09, 0) /* T9 */ + MATRIX_KEY(0x00, 0x04, 0) /* T10 */ + MATRIX_KEY(0x03, 0x09, 0) /* T11 */ + >; + linux,keymap = < + MATRIX_KEY(0x00, 0x02, KEY_BACK) + MATRIX_KEY(0x03, 0x02, KEY_REFRESH) + MATRIX_KEY(0x02, 0x02, KEY_ZOOM) + MATRIX_KEY(0x01, 0x02, KEY_SCALE) + MATRIX_KEY(0x03, 0x04, KEY_SYSRQ) + MATRIX_KEY(0x02, 0x04, KEY_BRIGHTNESSDOWN) + MATRIX_KEY(0x01, 0x04, KEY_BRIGHTNESSUP) + MATRIX_KEY(0x02, 0x09, KEY_MUTE) + MATRIX_KEY(0x01, 0x09, KEY_VOLUMEDOWN) + MATRIX_KEY(0x00, 0x04, KEY_VOLUMEUP) + MATRIX_KEY(0x03, 0x09, KEY_SLEEP) + CROS_STD_MAIN_KEYMAP + >; +}; + +&sound { + compatible = "google,sc7180-trogdor"; + model = "sc7180-rt5682s-max98357a-1mic"; +}; -- 2.17.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 2022-09-01 2:49 [PATCH v3 1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 Yunlong Jia 2022-09-01 2:49 ` [PATCH v3 2/2] arm64: dts: qcom: Add sc7180-pazquel360 Yunlong Jia @ 2022-09-06 22:26 ` Doug Anderson 2022-10-18 3:15 ` (subset) " Bjorn Andersson 2 siblings, 0 replies; 5+ messages in thread From: Doug Anderson @ 2022-09-06 22:26 UTC (permalink / raw) To: Yunlong Jia, Bjorn Andersson Cc: LKML, Bob Moragues, Henry Sun, Andy Gross, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-arm-msm Bjorn, On Wed, Aug 31, 2022 at 7:50 PM Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com> wrote: > > pazquel360 is an extension project based on pazquel. > We create 3 sku on pazquel360: > sku 20 for LTE with physical SIM _and_ eSIM and WiFi > sku 21 for WiFi only > sku 22 for LTE with only a physical SIM > Both sku20 and sku22 are LTE SKUs. > One has the eSIM stuffed and one doesn't. > There is a single shared device tree for the two. > > Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Douglas Anderson <dianders@chromium.org> > > --- > > Changes in v3: > 1. Adjust the format of the changelog. > > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) I think these two patches are ready to land if now is a good time. Thanks! -Doug ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: (subset) [PATCH v3 1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 2022-09-01 2:49 [PATCH v3 1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 Yunlong Jia 2022-09-01 2:49 ` [PATCH v3 2/2] arm64: dts: qcom: Add sc7180-pazquel360 Yunlong Jia 2022-09-06 22:26 ` [PATCH v3 1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 Doug Anderson @ 2022-10-18 3:15 ` Bjorn Andersson 2022-10-20 22:36 ` Doug Anderson 2 siblings, 1 reply; 5+ messages in thread From: Bjorn Andersson @ 2022-10-18 3:15 UTC (permalink / raw) To: LKML, yunlong.jia Cc: henrysun, devicetree, moragues, agross, Douglas Anderson, robh+dt, linux-arm-msm, Krzysztof Kozlowski, Konrad Dybcio On Thu, 1 Sep 2022 02:49:57 +0000, Yunlong Jia wrote: > pazquel360 is an extension project based on pazquel. > We create 3 sku on pazquel360: > sku 20 for LTE with physical SIM _and_ eSIM and WiFi > sku 21 for WiFi only > sku 22 for LTE with only a physical SIM > Both sku20 and sku22 are LTE SKUs. > One has the eSIM stuffed and one doesn't. > There is a single shared device tree for the two. > > [...] Applied, thanks! [1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 commit: 185d192d0a7b565a24b3f7456a2f84f169ab087a [2/2] arm64: dts: qcom: Add sc7180-pazquel360 commit: 2f72a4f54cdb4fd0ebea9a2dea65756d3e676be2 Best regards, -- Bjorn Andersson <andersson@kernel.org> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: (subset) [PATCH v3 1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 2022-10-18 3:15 ` (subset) " Bjorn Andersson @ 2022-10-20 22:36 ` Doug Anderson 0 siblings, 0 replies; 5+ messages in thread From: Doug Anderson @ 2022-10-20 22:36 UTC (permalink / raw) To: Bjorn Andersson Cc: LKML, yunlong.jia, henrysun, devicetree, moragues, agross, robh+dt, linux-arm-msm, Krzysztof Kozlowski, Konrad Dybcio Hi, On Mon, Oct 17, 2022 at 8:15 PM Bjorn Andersson <andersson@kernel.org> wrote: > > On Thu, 1 Sep 2022 02:49:57 +0000, Yunlong Jia wrote: > > pazquel360 is an extension project based on pazquel. > > We create 3 sku on pazquel360: > > sku 20 for LTE with physical SIM _and_ eSIM and WiFi > > sku 21 for WiFi only > > sku 22 for LTE with only a physical SIM > > Both sku20 and sku22 are LTE SKUs. > > One has the eSIM stuffed and one doesn't. > > There is a single shared device tree for the two. > > > > [...] > > Applied, thanks! > > [1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 > commit: 185d192d0a7b565a24b3f7456a2f84f169ab087a > [2/2] arm64: dts: qcom: Add sc7180-pazquel360 > commit: 2f72a4f54cdb4fd0ebea9a2dea65756d3e676be2 FWIW, it looks like you landed v3 instead of v5. See: https://lore.kernel.org/r/20220923083657.v5.3.Iea2d2918adfff2825b87d428b5732717425c196f@changeid/ Presumably something about your process got confused because Yunlong changed the email address they were sending it from (I think someone requested not to use an "corp-partner" email address). The other difference between v3 and v5 is the touchscreen. Presumably Yunlong can send a followup patch to add the touchscreen atop what you've landed. -Doug ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-10-20 22:38 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-09-01 2:49 [PATCH v3 1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 Yunlong Jia 2022-09-01 2:49 ` [PATCH v3 2/2] arm64: dts: qcom: Add sc7180-pazquel360 Yunlong Jia 2022-09-06 22:26 ` [PATCH v3 1/2] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 Doug Anderson 2022-10-18 3:15 ` (subset) " Bjorn Andersson 2022-10-20 22:36 ` Doug Anderson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).