* [PATCH v2] arm64: dts: qcom: sc7180: Configure USB as wakeup source @ 2022-09-01 17:29 Matthias Kaehlcke 2022-09-06 18:33 ` Doug Anderson 2022-10-18 3:06 ` Bjorn Andersson 0 siblings, 2 replies; 6+ messages in thread From: Matthias Kaehlcke @ 2022-09-01 17:29 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski Cc: Douglas Anderson, linux-arm-msm, Krishna Kurapati, linux-kernel, devicetree, Matthias Kaehlcke The dwc3 USB controller of the sc7180 supports USB remote wakeup, configure it as a wakeup source. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- Changes in v2: - use qcom/arm64-for-6.1 as base, v1 was unintendedly based on a downstream branch that was used for testing arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index e8debb0da411..af5bab27eaf3 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -2782,6 +2782,8 @@ usb_1: usb@a6f8800 { <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3 0>; interconnect-names = "usb-ddr", "apps-usb"; + wakeup-source; + usb_1_dwc3: usb@a600000 { compatible = "snps,dwc3"; reg = <0 0x0a600000 0 0xe000>; -- 2.37.2.789.g6183377224-goog ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sc7180: Configure USB as wakeup source 2022-09-01 17:29 [PATCH v2] arm64: dts: qcom: sc7180: Configure USB as wakeup source Matthias Kaehlcke @ 2022-09-06 18:33 ` Doug Anderson 2022-09-06 19:04 ` Matthias Kaehlcke 2022-10-18 3:06 ` Bjorn Andersson 1 sibling, 1 reply; 6+ messages in thread From: Doug Anderson @ 2022-09-06 18:33 UTC (permalink / raw) To: Matthias Kaehlcke Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, Krishna Kurapati, LKML, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS Hi, On Thu, Sep 1, 2022 at 10:29 AM Matthias Kaehlcke <mka@chromium.org> wrote: > > The dwc3 USB controller of the sc7180 supports USB remote > wakeup, configure it as a wakeup source. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- > > Changes in v2: > - use qcom/arm64-for-6.1 as base, v1 was unintendedly based on a > downstream branch that was used for testing > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index e8debb0da411..af5bab27eaf3 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -2782,6 +2782,8 @@ usb_1: usb@a6f8800 { > <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3 0>; > interconnect-names = "usb-ddr", "apps-usb"; > > + wakeup-source; > + The patch documenting this property has landed in commit 416b61893860 ("dt-bindings: usb: qcom,dwc3: add wakeup-source property"). I guess the only question is whether this should be in the general sc7180 device tree file or just for trogdor. Any chance it could cause problems for devices that aren't designed like trogdor? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sc7180: Configure USB as wakeup source 2022-09-06 18:33 ` Doug Anderson @ 2022-09-06 19:04 ` Matthias Kaehlcke 2022-09-06 19:22 ` Doug Anderson 0 siblings, 1 reply; 6+ messages in thread From: Matthias Kaehlcke @ 2022-09-06 19:04 UTC (permalink / raw) To: Doug Anderson Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, Krishna Kurapati, LKML, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS Hi Doug, On Tue, Sep 06, 2022 at 11:33:56AM -0700, Doug Anderson wrote: > Hi, > > On Thu, Sep 1, 2022 at 10:29 AM Matthias Kaehlcke <mka@chromium.org> wrote: > > > > The dwc3 USB controller of the sc7180 supports USB remote > > wakeup, configure it as a wakeup source. > > > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > > --- > > > > Changes in v2: > > - use qcom/arm64-for-6.1 as base, v1 was unintendedly based on a > > downstream branch that was used for testing > > > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > index e8debb0da411..af5bab27eaf3 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > @@ -2782,6 +2782,8 @@ usb_1: usb@a6f8800 { > > <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3 0>; > > interconnect-names = "usb-ddr", "apps-usb"; > > > > + wakeup-source; > > + > > The patch documenting this property has landed in commit 416b61893860 > ("dt-bindings: usb: qcom,dwc3: add wakeup-source property"). I guess > the only question is whether this should be in the general sc7180 > device tree file or just for trogdor. I had a similar comment on the patch for sc7280 [1], there the rationale for putting the property into the .dtsi of the SoC was that the wakeup capability is provided by the SoC. For sc8280xp.dtsi the property is also in the .dtsi of the SoC: https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/tree/arch/arm64/boot/dts/qcom/sc8280xp.dtsi?h=arm64-for-6.1#n1315 > Any chance it could cause problems for devices that aren't designed like > trogdor? Probably not in a functional sense, however power consumption during system suspend is slightly higher (2-3 mW) when USB wakeup is enabled. Boards can disable wakeup by deleting the property in their .dtsi file, though it is not necessarily evident that this is an option to reduce power consumption. [1] https://patchwork.kernel.org/project/linux-arm-msm/patch/1649321104-31322-7-git-send-email-quic_c_sanm@quicinc.com/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sc7180: Configure USB as wakeup source 2022-09-06 19:04 ` Matthias Kaehlcke @ 2022-09-06 19:22 ` Doug Anderson 2022-09-28 19:24 ` Matthias Kaehlcke 0 siblings, 1 reply; 6+ messages in thread From: Doug Anderson @ 2022-09-06 19:22 UTC (permalink / raw) To: Matthias Kaehlcke Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, Krishna Kurapati, LKML, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Bjorn Andersson Hi, On Tue, Sep 6, 2022 at 12:04 PM Matthias Kaehlcke <mka@chromium.org> wrote: > > Hi Doug, > > On Tue, Sep 06, 2022 at 11:33:56AM -0700, Doug Anderson wrote: > > Hi, > > > > On Thu, Sep 1, 2022 at 10:29 AM Matthias Kaehlcke <mka@chromium.org> wrote: > > > > > > The dwc3 USB controller of the sc7180 supports USB remote > > > wakeup, configure it as a wakeup source. > > > > > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > > > --- > > > > > > Changes in v2: > > > - use qcom/arm64-for-6.1 as base, v1 was unintendedly based on a > > > downstream branch that was used for testing > > > > > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > index e8debb0da411..af5bab27eaf3 100644 > > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > @@ -2782,6 +2782,8 @@ usb_1: usb@a6f8800 { > > > <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3 0>; > > > interconnect-names = "usb-ddr", "apps-usb"; > > > > > > + wakeup-source; > > > + > > > > The patch documenting this property has landed in commit 416b61893860 > > ("dt-bindings: usb: qcom,dwc3: add wakeup-source property"). I guess > > the only question is whether this should be in the general sc7180 > > device tree file or just for trogdor. > > I had a similar comment on the patch for sc7280 [1], there the rationale > for putting the property into the .dtsi of the SoC was that the wakeup > capability is provided by the SoC. > > For sc8280xp.dtsi the property is also in the .dtsi of the SoC: > > https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/tree/arch/arm64/boot/dts/qcom/sc8280xp.dtsi?h=arm64-for-6.1#n1315 > > > Any chance it could cause problems for devices that aren't designed like > > trogdor? > > Probably not in a functional sense, however power consumption during system > suspend is slightly higher (2-3 mW) when USB wakeup is enabled. Boards can > disable wakeup by deleting the property in their .dtsi file, though it > is not necessarily evident that this is an option to reduce power > consumption. > > [1] https://patchwork.kernel.org/project/linux-arm-msm/patch/1649321104-31322-7-git-send-email-quic_c_sanm@quicinc.com/ OK then. Reviewed-by: Douglas Anderson <dianders@chromium.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sc7180: Configure USB as wakeup source 2022-09-06 19:22 ` Doug Anderson @ 2022-09-28 19:24 ` Matthias Kaehlcke 0 siblings, 0 replies; 6+ messages in thread From: Matthias Kaehlcke @ 2022-09-28 19:24 UTC (permalink / raw) To: Doug Anderson Cc: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, Krishna Kurapati, LKML, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Bjorn Andersson Hi Bjorn, This patch should be ready for landing, could you pick it? Thanks Matthias On Tue, Sep 06, 2022 at 12:22:42PM -0700, Doug Anderson wrote: > Hi, > > On Tue, Sep 6, 2022 at 12:04 PM Matthias Kaehlcke <mka@chromium.org> wrote: > > > > Hi Doug, > > > > On Tue, Sep 06, 2022 at 11:33:56AM -0700, Doug Anderson wrote: > > > Hi, > > > > > > On Thu, Sep 1, 2022 at 10:29 AM Matthias Kaehlcke <mka@chromium.org> wrote: > > > > > > > > The dwc3 USB controller of the sc7180 supports USB remote > > > > wakeup, configure it as a wakeup source. > > > > > > > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > > > > --- > > > > > > > > Changes in v2: > > > > - use qcom/arm64-for-6.1 as base, v1 was unintendedly based on a > > > > downstream branch that was used for testing > > > > > > > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > > index e8debb0da411..af5bab27eaf3 100644 > > > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > > @@ -2782,6 +2782,8 @@ usb_1: usb@a6f8800 { > > > > <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3 0>; > > > > interconnect-names = "usb-ddr", "apps-usb"; > > > > > > > > + wakeup-source; > > > > + > > > > > > The patch documenting this property has landed in commit 416b61893860 > > > ("dt-bindings: usb: qcom,dwc3: add wakeup-source property"). I guess > > > the only question is whether this should be in the general sc7180 > > > device tree file or just for trogdor. > > > > I had a similar comment on the patch for sc7280 [1], there the rationale > > for putting the property into the .dtsi of the SoC was that the wakeup > > capability is provided by the SoC. > > > > For sc8280xp.dtsi the property is also in the .dtsi of the SoC: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/tree/arch/arm64/boot/dts/qcom/sc8280xp.dtsi?h=arm64-for-6.1#n1315 > > > > > Any chance it could cause problems for devices that aren't designed like > > > trogdor? > > > > Probably not in a functional sense, however power consumption during system > > suspend is slightly higher (2-3 mW) when USB wakeup is enabled. Boards can > > disable wakeup by deleting the property in their .dtsi file, though it > > is not necessarily evident that this is an option to reduce power > > consumption. > > > > [1] https://patchwork.kernel.org/project/linux-arm-msm/patch/1649321104-31322-7-git-send-email-quic_c_sanm@quicinc.com/ > > OK then. > > Reviewed-by: Douglas Anderson <dianders@chromium.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sc7180: Configure USB as wakeup source 2022-09-01 17:29 [PATCH v2] arm64: dts: qcom: sc7180: Configure USB as wakeup source Matthias Kaehlcke 2022-09-06 18:33 ` Doug Anderson @ 2022-10-18 3:06 ` Bjorn Andersson 1 sibling, 0 replies; 6+ messages in thread From: Bjorn Andersson @ 2022-10-18 3:06 UTC (permalink / raw) To: Bjorn Andersson, Matthias Kaehlcke, robh+dt, agross, Krzysztof Kozlowski, Konrad Dybcio Cc: devicetree, linux-kernel, Douglas Anderson, quic_kriskura, linux-arm-msm On Thu, 1 Sep 2022 10:29:50 -0700, Matthias Kaehlcke wrote: > The dwc3 USB controller of the sc7180 supports USB remote > wakeup, configure it as a wakeup source. > > Applied, thanks! [1/1] arm64: dts: qcom: sc7180: Configure USB as wakeup source commit: c50e30b7e2614d140929280377337ec01bdbdc84 Best regards, -- Bjorn Andersson <andersson@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-18 3:12 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-09-01 17:29 [PATCH v2] arm64: dts: qcom: sc7180: Configure USB as wakeup source Matthias Kaehlcke 2022-09-06 18:33 ` Doug Anderson 2022-09-06 19:04 ` Matthias Kaehlcke 2022-09-06 19:22 ` Doug Anderson 2022-09-28 19:24 ` Matthias Kaehlcke 2022-10-18 3:06 ` Bjorn Andersson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).