* [PATCH 2/2] virt: vbox: Remove unproper information
@ 2022-09-01 13:15 Jiasheng Jiang
0 siblings, 0 replies; 3+ messages in thread
From: Jiasheng Jiang @ 2022-09-01 13:15 UTC (permalink / raw)
To: gregkh; +Cc: hdegoede, arnd, linux-kernel, Jiasheng Jiang
When drivers are working properly, they are quiet.
Therefore, the vbg_info() should be removed.
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/virt/vboxguest/vboxguest_linux.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c
index 6fc81347ae72..c47e62dc55da 100644
--- a/drivers/virt/vboxguest/vboxguest_linux.c
+++ b/drivers/virt/vboxguest/vboxguest_linux.c
@@ -398,10 +398,6 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
pci_set_drvdata(pci, gdev);
- vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %pap (size %pap)\n",
- gdev->misc_device.minor, pci->irq, gdev->io_port,
- &mmio, &mmio_len);
-
return 0;
err_unregister_misc_device_user:
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] virt: vbox: Remove unproper information
2022-09-01 9:18 Jiasheng Jiang
@ 2022-09-01 9:40 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2022-09-01 9:40 UTC (permalink / raw)
To: Jiasheng Jiang; +Cc: hdegoede, arnd, linux-kernel
On Thu, Sep 01, 2022 at 05:18:15PM +0800, Jiasheng Jiang wrote:
> When drivers are working properly, they are quiet.
> Therefore, the vbg_info() should be removed.
>
> Fixes: 0ba002bc4393 ("virt: Add vboxguest driver for Virtual Box Guest integration")
This is not a bug to be fixed, so this line is not needed.
And where is the "Suggested-by:" line?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] virt: vbox: Remove unproper information
@ 2022-09-01 9:18 Jiasheng Jiang
2022-09-01 9:40 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Jiasheng Jiang @ 2022-09-01 9:18 UTC (permalink / raw)
To: gregkh; +Cc: hdegoede, arnd, linux-kernel, Jiasheng Jiang
When drivers are working properly, they are quiet.
Therefore, the vbg_info() should be removed.
Fixes: 0ba002bc4393 ("virt: Add vboxguest driver for Virtual Box Guest integration")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/virt/vboxguest/vboxguest_linux.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c
index 2fb9a6d91b53..2c484c3a9c09 100644
--- a/drivers/virt/vboxguest/vboxguest_linux.c
+++ b/drivers/virt/vboxguest/vboxguest_linux.c
@@ -398,10 +398,6 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
if (ret)
goto err_remove_file_features;
- vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %pap (size %pap)\n",
- gdev->misc_device.minor, pci->irq, gdev->io_port,
- &mmio, &mmio_len);
-
return 0;
err_remove_file_features:
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-01 13:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-01 13:15 [PATCH 2/2] virt: vbox: Remove unproper information Jiasheng Jiang
-- strict thread matches above, loose matches on Subject: below --
2022-09-01 9:18 Jiasheng Jiang
2022-09-01 9:40 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).