linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, rafael@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>
Subject: [PATCH v3 18/30] thermal/of: Remove of_thermal_is_trip_valid()
Date: Tue,  6 Sep 2022 18:47:08 +0200	[thread overview]
Message-ID: <20220906164720.330701-19-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20220906164720.330701-1-daniel.lezcano@linaro.org>

There is no benefit with the of_thermal_is_trip_valid() function as it
does the check the thermal_zone_get_trip() is already doing for the
sake of getting the trip point.

As all the calls have been replaced by thermal_zone_get_trip(), there
is no more users of of_thermal_is_trip_valid().

Remove the function.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/thermal/thermal_core.h | 10 ----------
 drivers/thermal/thermal_of.c   | 19 -------------------
 2 files changed, 29 deletions(-)

diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
index 0139bc1e4f87..4d1af11a6eb4 100644
--- a/drivers/thermal/thermal_core.h
+++ b/drivers/thermal/thermal_core.h
@@ -136,16 +136,6 @@ thermal_cooling_device_stats_update(struct thermal_cooling_device *cdev,
 #endif /* CONFIG_THERMAL_STATISTICS */
 
 /* device tree support */
-#ifdef CONFIG_THERMAL_OF
-bool of_thermal_is_trip_valid(struct thermal_zone_device *, int);
-#else
-static inline bool of_thermal_is_trip_valid(struct thermal_zone_device *tz,
-					    int trip)
-{
-	return false;
-}
-#endif
-
 int thermal_zone_device_is_enabled(struct thermal_zone_device *tz);
 
 #endif /* __THERMAL_CORE_H__ */
diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
index 89afa59c4915..4e54d62720dc 100644
--- a/drivers/thermal/thermal_of.c
+++ b/drivers/thermal/thermal_of.c
@@ -19,25 +19,6 @@
 
 #include "thermal_core.h"
 
-/**
- * of_thermal_is_trip_valid - function to check if trip point is valid
- *
- * @tz:	pointer to a thermal zone
- * @trip:	trip point to evaluate
- *
- * This function is responsible for checking if passed trip point is valid
- *
- * Return: true if trip point is valid, false otherwise
- */
-bool of_thermal_is_trip_valid(struct thermal_zone_device *tz, int trip)
-{
-	if (trip >= tz->num_trips || trip < 0)
-		return false;
-
-	return true;
-}
-EXPORT_SYMBOL_GPL(of_thermal_is_trip_valid);
-
 static int of_thermal_set_trip_hyst(struct thermal_zone_device *tz, int trip,
 				    int hyst)
 {
-- 
2.34.1


  parent reply	other threads:[~2022-09-06 17:02 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06 16:46 [PATCH v3 00/30] Rework the trip points creation Daniel Lezcano
2022-09-06 16:46 ` [PATCH v3 01/30] thermal/core: Add a generic thermal_zone_get_trip() function Daniel Lezcano
2022-09-06 16:46 ` [PATCH v3 02/30] thermal/sysfs: Do not make get_trip_hyst optional Daniel Lezcano
2022-09-06 16:46 ` [PATCH v3 03/30] thermal/core: Add a generic thermal_zone_set_trip() function Daniel Lezcano
2022-09-06 16:46 ` [PATCH v3 04/30] thermal/core: Add a generic thermal_zone_get_crit_temp() function Daniel Lezcano
2022-09-06 16:46 ` [PATCH v3 05/30] thermal/core/governors: Use thermal_zone_get_trip() instead of ops functions Daniel Lezcano
2022-09-06 16:46 ` [PATCH v3 06/30] thermal/of: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-09-06 16:46 ` [PATCH v3 07/30] thermal/of: Remove unused functions Daniel Lezcano
2022-09-06 16:46 ` [PATCH v3 08/30] thermal/drivers/exynos: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-09-07 11:06   ` Krzysztof Kozlowski
2022-09-06 16:46 ` [PATCH v3 09/30] thermal/drivers/exynos: of_thermal_get_ntrips() Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 10/30] thermal/drivers/exynos: Replace of_thermal_is_trip_valid() by thermal_zone_get_trip() Daniel Lezcano
2022-09-07 11:07   ` Krzysztof Kozlowski
2022-09-06 16:47 ` [PATCH v3 11/30] thermal/drivers/tegra: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-09-16 16:56   ` Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 12/30] thermal/drivers/uniphier: " Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 13/30] thermal/drivers/hisi: " Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 14/30] thermal/drivers/qcom: " Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 15/30] thermal/drivers/armada: " Daniel Lezcano
2022-09-16 17:00   ` Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 16/30] thermal/drivers/rcar_gen3: Use the generic function to get the number of trips Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 17/30] thermal/of: Remove of_thermal_get_ntrips() Daniel Lezcano
2022-09-06 16:47 ` Daniel Lezcano [this message]
2022-09-06 16:47 ` [PATCH v3 19/30] thermal/of: Remove of_thermal_set_trip_hyst() Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 20/30] thermal/of: Remove of_thermal_get_crit_temp() Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 21/30] thermal/drivers/st: Use generic trip points Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 22/30] thermal/drivers/imx: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-09-16 17:02   ` Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 23/30] thermal/drivers/rcar: " Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 24/30] thermal/drivers/broadcom: " Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 25/30] thermal/drivers/da9062: " Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 26/30] thermal/drivers/ti: Remove unused macros ti_thermal_get_trip_value() / ti_thermal_trip_is_valid() Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 27/30] thermal/drivers/acerhdf: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 28/30] thermal/drivers/cxgb4: " Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 29/30] thermal/intel/int340x: Replace parameter to simplify Daniel Lezcano
2022-09-24 17:36   ` Rafael J. Wysocki
2022-09-24 17:44     ` Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 30/30] thermal/drivers/intel: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-09-16 17:06   ` Daniel Lezcano
2022-09-19  6:54     ` srinivas pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220906164720.330701-19-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=amitk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).