From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Antoine Tenart <atenart@kernel.org>
Subject: Re: [PATCH v3 29/30] thermal/intel/int340x: Replace parameter to simplify
Date: Sat, 24 Sep 2022 19:44:59 +0200 [thread overview]
Message-ID: <499d1aca-940b-bf0a-75ce-c3c2b2fe66fb@linaro.org> (raw)
In-Reply-To: <CAJZ5v0j+2UM9zONBZpLW=X2KKQU5mDd8r=o9DqTq3rqoigBqrw@mail.gmail.com>
On 24/09/2022 19:36, Rafael J. Wysocki wrote:
> On Tue, Sep 6, 2022 at 6:48 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>>
>> In the process of replacing the get_trip_* ops by the generic trip
>> points, the current code has an 'override' property to add another
>> indirection to a different ops.
>>
>> Rework this approach to prevent this indirection and make the code
>> ready for the generic trip points conversion.
>>
>> Actually the get_temp() is different regarding the platform, so it is
>> pointless to add a new set of ops but just create dynamically the ops
>> at init time.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>
> A fix has been posted for this one already:
>
> https://patchwork.kernel.org/project/linux-pm/patch/20220923152009.1721739-1-nathan@kernel.org/
Thanks I'll pick it up in the series.
I'm currently fixing a locking issue in the thermal linux-next branch
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2022-09-24 17:45 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 16:46 [PATCH v3 00/30] Rework the trip points creation Daniel Lezcano
2022-09-06 16:46 ` [PATCH v3 01/30] thermal/core: Add a generic thermal_zone_get_trip() function Daniel Lezcano
2022-09-06 16:46 ` [PATCH v3 02/30] thermal/sysfs: Do not make get_trip_hyst optional Daniel Lezcano
2022-09-06 16:46 ` [PATCH v3 03/30] thermal/core: Add a generic thermal_zone_set_trip() function Daniel Lezcano
2022-09-06 16:46 ` [PATCH v3 04/30] thermal/core: Add a generic thermal_zone_get_crit_temp() function Daniel Lezcano
2022-09-06 16:46 ` [PATCH v3 05/30] thermal/core/governors: Use thermal_zone_get_trip() instead of ops functions Daniel Lezcano
2022-09-06 16:46 ` [PATCH v3 06/30] thermal/of: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-09-06 16:46 ` [PATCH v3 07/30] thermal/of: Remove unused functions Daniel Lezcano
2022-09-06 16:46 ` [PATCH v3 08/30] thermal/drivers/exynos: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-09-07 11:06 ` Krzysztof Kozlowski
2022-09-06 16:46 ` [PATCH v3 09/30] thermal/drivers/exynos: of_thermal_get_ntrips() Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 10/30] thermal/drivers/exynos: Replace of_thermal_is_trip_valid() by thermal_zone_get_trip() Daniel Lezcano
2022-09-07 11:07 ` Krzysztof Kozlowski
2022-09-06 16:47 ` [PATCH v3 11/30] thermal/drivers/tegra: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-09-16 16:56 ` Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 12/30] thermal/drivers/uniphier: " Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 13/30] thermal/drivers/hisi: " Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 14/30] thermal/drivers/qcom: " Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 15/30] thermal/drivers/armada: " Daniel Lezcano
2022-09-16 17:00 ` Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 16/30] thermal/drivers/rcar_gen3: Use the generic function to get the number of trips Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 17/30] thermal/of: Remove of_thermal_get_ntrips() Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 18/30] thermal/of: Remove of_thermal_is_trip_valid() Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 19/30] thermal/of: Remove of_thermal_set_trip_hyst() Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 20/30] thermal/of: Remove of_thermal_get_crit_temp() Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 21/30] thermal/drivers/st: Use generic trip points Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 22/30] thermal/drivers/imx: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-09-16 17:02 ` Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 23/30] thermal/drivers/rcar: " Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 24/30] thermal/drivers/broadcom: " Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 25/30] thermal/drivers/da9062: " Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 26/30] thermal/drivers/ti: Remove unused macros ti_thermal_get_trip_value() / ti_thermal_trip_is_valid() Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 27/30] thermal/drivers/acerhdf: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 28/30] thermal/drivers/cxgb4: " Daniel Lezcano
2022-09-06 16:47 ` [PATCH v3 29/30] thermal/intel/int340x: Replace parameter to simplify Daniel Lezcano
2022-09-24 17:36 ` Rafael J. Wysocki
2022-09-24 17:44 ` Daniel Lezcano [this message]
2022-09-06 16:47 ` [PATCH v3 30/30] thermal/drivers/intel: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-09-16 17:06 ` Daniel Lezcano
2022-09-19 6:54 ` srinivas pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499d1aca-940b-bf0a-75ce-c3c2b2fe66fb@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=atenart@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).