* [PATCH] fsi: check ida_simple_get() return value
@ 2022-09-07 8:16 Bo Liu
0 siblings, 0 replies; only message in thread
From: Bo Liu @ 2022-09-07 8:16 UTC (permalink / raw)
To: jk, joel, alistair, eajames; +Cc: linux-fsi, linux-kernel, Bo Liu
As ida_simple_get() can fail, we should check the return value.
Signed-off-by: Bo Liu <liubo03@inspur.com>
---
drivers/fsi/fsi-core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
index 0d11a17c53a0..c009c9b30ba1 100644
--- a/drivers/fsi/fsi-core.c
+++ b/drivers/fsi/fsi-core.c
@@ -1313,7 +1313,10 @@ int fsi_master_register(struct fsi_master *master)
struct device_node *np;
mutex_init(&master->scan_lock);
- master->idx = ida_simple_get(&master_ida, 0, INT_MAX, GFP_KERNEL);
+ rc = ida_simple_get(&master_ida, 0, INT_MAX, GFP_KERNEL);
+ if (rc < 0)
+ return rc;
+ master->idx = rc;
dev_set_name(&master->dev, "fsi%d", master->idx);
master->dev.class = &fsi_master_class;
--
2.27.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-09-07 8:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-07 8:16 [PATCH] fsi: check ida_simple_get() return value Bo Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).