From: Michael Walle <michael@walle.cc>
To: Divya.Koppera@microchip.com
Cc: andrew@lunn.ch, UNGLinuxDriver@microchip.com,
davem@davemloft.net, edumazet@google.com, hkallweit1@gmail.com,
kuba@kernel.org, linux-kernel@vger.kernel.org,
linux@armlinux.org.uk, netdev@vger.kernel.org, pabeni@redhat.com,
Oleksij Rempel <o.rempel@pengutronix.de>,
Michael Walle <michael@walle.cc>
Subject: Re: [PATCH v2 net-next] net: phy: micrel: Adding SQI support for lan8814 phy
Date: Wed, 7 Sep 2022 11:07:50 +0200 [thread overview]
Message-ID: <20220907090750.2937889-1-michael@walle.cc> (raw)
In-Reply-To: <YxX1I6wBFjzID2Ls@lunn.ch>
> On Mon, Sep 05, 2022 at 03:47:30PM +0530, Divya Koppera wrote:
>> Supports SQI(Signal Quality Index) for lan8814 phy, where
>> it has SQI index of 0-7 values and this indicator can be used
>> for cable integrity diagnostic and investigating other noise
>> sources. It is not supported for 10Mbps speed
>>
>> Signed-off-by: Divya Koppera <Divya.Koppera@microchip.com>
>> ---
>> v1 -> v2
>> - Given SQI support for all pairs of wires in 1000/100 base-T phy's
>> uAPI may run through all instances in future. At present returning
>> only first instance as uAPI supports for only 1 pair.
>> - SQI is not supported for 10Mbps speed, handled accordingly.
>
> I would prefer you solve the problem of returning all pairs.
>
> I'm not sure how useful the current implementation is, especially at
> 100Mbps, where pair 0 could actually be the transmit pair. Does it
> give a sensible value in that case?
It is good practice to CC the patches to the ones who gave feedback
on the previous versions. Not everyone is subscribed to all the
high traffic mailinglist.
Thanks,
-michael
next prev parent reply other threads:[~2022-09-07 9:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 10:17 [PATCH v2 net-next] net: phy: micrel: Adding SQI support for lan8814 phy Divya Koppera
2022-09-05 13:09 ` Andrew Lunn
2022-09-06 10:41 ` Divya.Koppera
2022-09-06 14:02 ` Andrew Lunn
2022-09-07 9:30 ` Oleksij Rempel
2022-09-07 10:52 ` Divya.Koppera
2022-09-07 9:07 ` Michael Walle [this message]
2022-09-07 9:24 ` Divya.Koppera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220907090750.2937889-1-michael@walle.cc \
--to=michael@walle.cc \
--cc=Divya.Koppera@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).