From: Andrew Lunn <andrew@lunn.ch>
To: Divya Koppera <Divya.Koppera@microchip.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v2 net-next] net: phy: micrel: Adding SQI support for lan8814 phy
Date: Mon, 5 Sep 2022 15:09:55 +0200 [thread overview]
Message-ID: <YxX1I6wBFjzID2Ls@lunn.ch> (raw)
In-Reply-To: <20220905101730.29951-1-Divya.Koppera@microchip.com>
On Mon, Sep 05, 2022 at 03:47:30PM +0530, Divya Koppera wrote:
> Supports SQI(Signal Quality Index) for lan8814 phy, where
> it has SQI index of 0-7 values and this indicator can be used
> for cable integrity diagnostic and investigating other noise
> sources. It is not supported for 10Mbps speed
>
> Signed-off-by: Divya Koppera <Divya.Koppera@microchip.com>
> ---
> v1 -> v2
> - Given SQI support for all pairs of wires in 1000/100 base-T phy's
> uAPI may run through all instances in future. At present returning
> only first instance as uAPI supports for only 1 pair.
> - SQI is not supported for 10Mbps speed, handled accordingly.
I would prefer you solve the problem of returning all pairs.
I'm not sure how useful the current implementation is, especially at
100Mbps, where pair 0 could actually be the transmit pair. Does it
give a sensible value in that case?
> +static int lan8814_get_sqi(struct phy_device *phydev)
> +{
> + int ret, val, pair;
> + int sqi_val[4];
> +
> + if (phydev->speed == SPEED_10)
> + return -EOPNOTSUPP;
> +
> + for (pair = 0; pair < 4; pair++) {
> + val = lanphy_read_page_reg(phydev, 1, LAN8814_DCQ_CTRL);
> + if (val < 0)
> + return val;
> +
> + val &= ~LAN8814_DCQ_CTRL_CHANNEL_MASK;
> + val |= pair;
> + val |= LAN8814_DCQ_CTRL_READ_CAPTURE_;
> + ret = lanphy_write_page_reg(phydev, 1, LAN8814_DCQ_CTRL, val);
> + if (ret < 0)
> + return ret;
> +
> + ret = lanphy_read_page_reg(phydev, 1, LAN8814_DCQ_SQI);
> + if (ret < 0)
> + return ret;
> +
> + sqi_val[pair] = FIELD_GET(LAN8814_DCQ_SQI_VAL_MASK, ret);
> + }
> +
> + return *sqi_val;
How is this going to work in the future? sqi_val is on the stack. You
cannot return a pointer to it. So this function is going to need
modifications.
If you really want to prepare for a future implementation which could
return all four, i would probably make this a helper which takes a
pair number. And then have a function call it once for pair 0.
Andrew
next prev parent reply other threads:[~2022-09-05 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 10:17 [PATCH v2 net-next] net: phy: micrel: Adding SQI support for lan8814 phy Divya Koppera
2022-09-05 13:09 ` Andrew Lunn [this message]
2022-09-06 10:41 ` Divya.Koppera
2022-09-06 14:02 ` Andrew Lunn
2022-09-07 9:30 ` Oleksij Rempel
2022-09-07 10:52 ` Divya.Koppera
2022-09-07 9:07 ` Michael Walle
2022-09-07 9:24 ` Divya.Koppera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxX1I6wBFjzID2Ls@lunn.ch \
--to=andrew@lunn.ch \
--cc=Divya.Koppera@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).