* [PATCH] sched/fair: fix a -Wmissing-prototypes warning
@ 2022-09-07 9:51 chen zhang
0 siblings, 0 replies; 2+ messages in thread
From: chen zhang @ 2022-09-07 9:51 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman, bristot, vschneid
Cc: chenzhang_0901, linux-kernel, chen zhang
We get a warning when building kernel with W=1:
kernel/sched/fair.c:11510:6: warning: no previous prototype for ‘task_vruntime_update’ [-Werror=missing-prototypes]
Add the missing declaration in head file to fix this. And remove
the unnecessary declaration in kernel/sched/core.c.
Signed-off-by: chen zhang <chenzhang@kylinos.cn>
---
kernel/sched/core.c | 2 --
kernel/sched/sched.h | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index b60422300af6..5a354b4bcd0c 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5874,8 +5874,6 @@ static inline struct task_struct *pick_task(struct rq *rq)
BUG(); /* The idle class should always have a runnable task. */
}
-extern void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi);
-
static void queue_core_balance(struct rq *rq);
static struct task_struct *
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index f616e0cec20c..ae8554356108 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -2268,6 +2268,8 @@ static inline bool sched_fair_runnable(struct rq *rq)
extern struct task_struct *pick_next_task_fair(struct rq *rq, struct task_struct *prev, struct rq_flags *rf);
extern struct task_struct *pick_next_task_idle(struct rq *rq);
+extern void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi);
+
#define SCA_CHECK 0x01
#define SCA_MIGRATE_DISABLE 0x02
#define SCA_MIGRATE_ENABLE 0x04
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] sched/fair: fix a -Wmissing-prototypes warning
@ 2022-09-07 9:23 chen zhang
0 siblings, 0 replies; 2+ messages in thread
From: chen zhang @ 2022-09-07 9:23 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman, bristot, vschneid
Cc: chenzhang_0901, linux-kernel, chen zhang
We get a warning when building kernel with W=1:
kernel/sched/fair.c:11510:6: warning: no previous prototype for ‘task_vruntime_update’ [-Werror=missing-prototypes]
Add the missing declaration in head file to fix this. And remove
the unnecessary declaration in kernel/sched/core.c.
Signed-off-by: chen zhang <chenzhang@kylinos.cn>
---
kernel/sched/core.c | 2 --
kernel/sched/sched.h | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index b60422300af6..5a354b4bcd0c 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5874,8 +5874,6 @@ static inline struct task_struct *pick_task(struct rq *rq)
BUG(); /* The idle class should always have a runnable task. */
}
-extern void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi);
-
static void queue_core_balance(struct rq *rq);
static struct task_struct *
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index f616e0cec20c..ae8554356108 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -2268,6 +2268,8 @@ static inline bool sched_fair_runnable(struct rq *rq)
extern struct task_struct *pick_next_task_fair(struct rq *rq, struct task_struct *prev, struct rq_flags *rf);
extern struct task_struct *pick_next_task_idle(struct rq *rq);
+extern void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi);
+
#define SCA_CHECK 0x01
#define SCA_MIGRATE_DISABLE 0x02
#define SCA_MIGRATE_ENABLE 0x04
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-07 10:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-07 9:51 [PATCH] sched/fair: fix a -Wmissing-prototypes warning chen zhang
-- strict thread matches above, loose matches on Subject: below --
2022-09-07 9:23 chen zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).