From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v2 04/14] arm64: dts: qcom: msm8996: fix APR services nodes
Date: Wed, 7 Sep 2022 12:15:46 +0200 [thread overview]
Message-ID: <20220907101556.37394-5-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20220907101556.37394-1-krzysztof.kozlowski@linaro.org>
DT schema expects APR services node names to be "service" and to have an
unit address (as it has a "reg" property):
qcom/msm8996-xiaomi-gemini.dtb: apr: 'power-domains', 'q6adm', 'q6afe', 'q6asm', 'qcom,smd-channels' do not match any of the regexes: '^service@[1-9a-d]$', 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 1e6b70582866..abc17c905bfe 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -3389,12 +3389,12 @@ apr {
#address-cells = <1>;
#size-cells = <0>;
- q6core {
+ service@3 {
reg = <APR_SVC_ADSP_CORE>;
compatible = "qcom,q6core";
};
- q6afe: q6afe {
+ q6afe: service@4 {
compatible = "qcom,q6afe";
reg = <APR_SVC_AFE>;
q6afedai: dais {
@@ -3408,7 +3408,7 @@ hdmi@1 {
};
};
- q6asm: q6asm {
+ q6asm: service@7 {
compatible = "qcom,q6asm";
reg = <APR_SVC_ASM>;
q6asmdai: dais {
@@ -3420,7 +3420,7 @@ q6asmdai: dais {
};
};
- q6adm: q6adm {
+ q6adm: service@8 {
compatible = "qcom,q6adm";
reg = <APR_SVC_ADM>;
q6routing: routing {
--
2.34.1
next prev parent reply other threads:[~2022-09-07 10:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 10:15 [PATCH v2 00/14] ASoC/qcom/arm64: Qualcomm ADSP DTS and binding fixes Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 01/14] arm64: dts: qcom: sdm630: align APR services node names with dtschema Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 02/14] arm64: dts: qcom: sdm845: " Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 03/14] arm64: dts: qcom: sm8250: " Krzysztof Kozlowski
2022-09-07 10:15 ` Krzysztof Kozlowski [this message]
2022-09-07 10:15 ` [PATCH v2 05/14] arm64: dts: qcom: sdm845: align dai " Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 06/14] arm64: dts: qcom: msm8996: " Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 07/14] arm64: dts: qcom: qrb5165-rb5: " Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 08/14] arm64: dts: qcom: sm8250: use generic name for LPASS clock controller Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 09/14] ASoC: dt-bindings:: qcom,q6asm: convert to dtschema Krzysztof Kozlowski
2022-09-07 17:57 ` Rob Herring
2022-09-08 9:05 ` Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 10/14] dt-bindings: soc: qcom: apr: correct service children Krzysztof Kozlowski
2022-09-07 18:01 ` Rob Herring
2022-09-07 10:15 ` [PATCH v2 11/14] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: cleanup example Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 12/14] ASoC: dt-bindings: qcom,q6dsp-lpass-clocks: " Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 13/14] ASoC: dt-bindings: qcom,q6apm-dai: adjust indentation in example Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 14/14] dt-bindings: soc: qcom: apr: add missing properties Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220907101556.37394-5-krzysztof.kozlowski@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).