From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 09/14] ASoC: dt-bindings:: qcom,q6asm: convert to dtschema
Date: Thu, 8 Sep 2022 11:05:47 +0200 [thread overview]
Message-ID: <ee9b8346-b0fc-8ca5-5858-26534d322362@linaro.org> (raw)
In-Reply-To: <20220907175759.GA3791463-robh@kernel.org>
On 07/09/2022 19:57, Rob Herring wrote:
> On Wed, Sep 07, 2022 at 12:15:51PM +0200, Krzysztof Kozlowski wrote:
>> Convert Qualcomm Audio Stream Manager (Q6ASM) bindings to DT schema.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Expected warning because the qcom,apr.yaml is being fixed in next commit:
>>
>> Documentation/devicetree/bindings/sound/qcom,q6asm.example.dtb: apr: service@7: 'dais' does not match any of the regexes: '^.*@[0-9a-f]+$', 'pinctrl-[0-9]+'
>> From schema: /home/krzk/dev/linux/linux/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml
>>
>> Changes since v1:
>> 1. New patch.
>> ---
>> .../devicetree/bindings/sound/qcom,q6asm.txt | 70 -----------
>> .../devicetree/bindings/sound/qcom,q6asm.yaml | 112 ++++++++++++++++++
>> 2 files changed, 112 insertions(+), 70 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm.txt
>> create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm.yaml
>
> Should be qcom,q6asm-dais.yaml or you need to add qcom,q6asm compatible?
Right, it should be -dais.
>
>>
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6asm.txt b/Documentation/devicetree/bindings/sound/qcom,q6asm.txt
>> deleted file mode 100644
>> index 0d0075125243..000000000000
>> --- a/Documentation/devicetree/bindings/sound/qcom,q6asm.txt
>> +++ /dev/null
>> @@ -1,70 +0,0 @@
>> -Qualcomm Audio Stream Manager (Q6ASM) binding
>> -
>> -Q6ASM is one of the APR audio service on Q6DSP.
>> -Please refer to qcom,apr.txt for details of the common apr service bindings
>> -used by the apr service device.
>> -
>> -- but must contain the following property:
>> -
>> -- compatible:
>> - Usage: required
>> - Value type: <stringlist>
>> - Definition: must be "qcom,q6asm-v<MAJOR-NUMBER>.<MINOR-NUMBER>".
>> - Or "qcom,q6asm" where the version number can be queried
>> - from DSP.
>> - example "qcom,q6asm-v2.0"
>
> Where is this compatible handled now?
The "qcom,q6asm" is handled in:
Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml
The "qcom,q6asm-v<MAJOR-NUMBER>.<MINOR-NUMBER>" is not handled because
it seems it is not used anywhere. I did not find such usage also in
downstream sources, so it seems version can be always auto-detected (I
did not confirm it with datasheet, though).
I'll explain this in commit msg.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-08 9:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 10:15 [PATCH v2 00/14] ASoC/qcom/arm64: Qualcomm ADSP DTS and binding fixes Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 01/14] arm64: dts: qcom: sdm630: align APR services node names with dtschema Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 02/14] arm64: dts: qcom: sdm845: " Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 03/14] arm64: dts: qcom: sm8250: " Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 04/14] arm64: dts: qcom: msm8996: fix APR services nodes Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 05/14] arm64: dts: qcom: sdm845: align dai node names with dtschema Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 06/14] arm64: dts: qcom: msm8996: " Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 07/14] arm64: dts: qcom: qrb5165-rb5: " Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 08/14] arm64: dts: qcom: sm8250: use generic name for LPASS clock controller Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 09/14] ASoC: dt-bindings:: qcom,q6asm: convert to dtschema Krzysztof Kozlowski
2022-09-07 17:57 ` Rob Herring
2022-09-08 9:05 ` Krzysztof Kozlowski [this message]
2022-09-07 10:15 ` [PATCH v2 10/14] dt-bindings: soc: qcom: apr: correct service children Krzysztof Kozlowski
2022-09-07 18:01 ` Rob Herring
2022-09-07 10:15 ` [PATCH v2 11/14] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: cleanup example Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 12/14] ASoC: dt-bindings: qcom,q6dsp-lpass-clocks: " Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 13/14] ASoC: dt-bindings: qcom,q6apm-dai: adjust indentation in example Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 14/14] dt-bindings: soc: qcom: apr: add missing properties Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee9b8346-b0fc-8ca5-5858-26534d322362@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).