* [PATCH] drm/doc: Custom Kconfig for KUnit is no longer needed
@ 2022-09-05 18:47 Michał Winiarski
2022-09-06 1:37 ` Bagas Sanjaya
2022-09-07 17:12 ` José Expósito
0 siblings, 2 replies; 5+ messages in thread
From: Michał Winiarski @ 2022-09-05 18:47 UTC (permalink / raw)
To: dri-devel, linux-doc, linux-kernel
Cc: David Airlie, Daniel Vetter, Maxime Ripard, David Gow,
Javier Martinez Canillas, Maarten Lankhorst, Thomas Zimmermann,
Jonathan Corbet, José Expósito, Michał Winiarski
When built for UML, KUnit provides virtio/PCI, which means that the
DMA/IOMEM UML emulation needed by DRM is already present and does not
need to be manually added with --kconfig_add.
References: commit 6fc3a8636a7b ("kunit: tool: Enable virtio/PCI by default on UML")
Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
---
Documentation/gpu/drm-internals.rst | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/Documentation/gpu/drm-internals.rst b/Documentation/gpu/drm-internals.rst
index 5fd20a306718..c264a9587d21 100644
--- a/Documentation/gpu/drm-internals.rst
+++ b/Documentation/gpu/drm-internals.rst
@@ -228,16 +228,11 @@ follows:
.. code-block:: bash
- $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests \
- --kconfig_add CONFIG_VIRTIO_UML=y \
- --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y
+ $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests
.. note::
The configuration included in ``.kunitconfig`` should be as generic as
possible.
- ``CONFIG_VIRTIO_UML`` and ``CONFIG_UML_PCI_OVER_VIRTIO`` are not
- included in it because they are only required for User Mode Linux.
-
Legacy Support Code
===================
--
2.37.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/doc: Custom Kconfig for KUnit is no longer needed
2022-09-05 18:47 [PATCH] drm/doc: Custom Kconfig for KUnit is no longer needed Michał Winiarski
@ 2022-09-06 1:37 ` Bagas Sanjaya
2022-09-06 8:12 ` Michał Winiarski
2022-09-07 17:12 ` José Expósito
1 sibling, 1 reply; 5+ messages in thread
From: Bagas Sanjaya @ 2022-09-06 1:37 UTC (permalink / raw)
To: Michał Winiarski, dri-devel, linux-doc, linux-kernel
Cc: David Airlie, Daniel Vetter, Maxime Ripard, David Gow,
Javier Martinez Canillas, Maarten Lankhorst, Thomas Zimmermann,
Jonathan Corbet, José Expósito
On 9/6/22 01:47, Michał Winiarski wrote:
> References: commit 6fc3a8636a7b ("kunit: tool: Enable virtio/PCI by default on UML")
Use Fixes: tag for bugfix patches instead.
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/doc: Custom Kconfig for KUnit is no longer needed
2022-09-06 1:37 ` Bagas Sanjaya
@ 2022-09-06 8:12 ` Michał Winiarski
2022-09-06 8:53 ` Jonathan Corbet
0 siblings, 1 reply; 5+ messages in thread
From: Michał Winiarski @ 2022-09-06 8:12 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: dri-devel, linux-doc, linux-kernel, David Airlie, Daniel Vetter,
Maxime Ripard, David Gow, Javier Martinez Canillas,
Maarten Lankhorst, Thomas Zimmermann, Jonathan Corbet,
José Expósito
On Tue, Sep 06, 2022 at 08:37:00AM +0700, Bagas Sanjaya wrote:
> On 9/6/22 01:47, Michał Winiarski wrote:
> > References: commit 6fc3a8636a7b ("kunit: tool: Enable virtio/PCI by default on UML")
>
> Use Fixes: tag for bugfix patches instead.
Can documentation update (when the referenced patch didn't touch the docs)
really be treated as a bugfix?
Or is it just a reference, validating the reasoning behind this patch?
-Michał
>
> --
> An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/doc: Custom Kconfig for KUnit is no longer needed
2022-09-06 8:12 ` Michał Winiarski
@ 2022-09-06 8:53 ` Jonathan Corbet
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Corbet @ 2022-09-06 8:53 UTC (permalink / raw)
To: Michał Winiarski, Bagas Sanjaya
Cc: dri-devel, linux-doc, linux-kernel, David Airlie, Daniel Vetter,
Maxime Ripard, David Gow, Javier Martinez Canillas,
Maarten Lankhorst, Thomas Zimmermann, José Expósito
Michał Winiarski <michal.winiarski@intel.com> writes:
> On Tue, Sep 06, 2022 at 08:37:00AM +0700, Bagas Sanjaya wrote:
>> On 9/6/22 01:47, Michał Winiarski wrote:
>> > References: commit 6fc3a8636a7b ("kunit: tool: Enable virtio/PCI by default on UML")
>>
>> Use Fixes: tag for bugfix patches instead.
>
> Can documentation update (when the referenced patch didn't touch the docs)
> really be treated as a bugfix?
> Or is it just a reference, validating the reasoning behind this patch?
I kind of agree; I'm not sure that a Fixes tag is really warranted here.
Thanks,
jon
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/doc: Custom Kconfig for KUnit is no longer needed
2022-09-05 18:47 [PATCH] drm/doc: Custom Kconfig for KUnit is no longer needed Michał Winiarski
2022-09-06 1:37 ` Bagas Sanjaya
@ 2022-09-07 17:12 ` José Expósito
1 sibling, 0 replies; 5+ messages in thread
From: José Expósito @ 2022-09-07 17:12 UTC (permalink / raw)
To: Michał Winiarski
Cc: dri-devel, linux-doc, linux-kernel, David Airlie, Daniel Vetter,
Maxime Ripard, David Gow, Javier Martinez Canillas,
Maarten Lankhorst, Thomas Zimmermann, Jonathan Corbet
Hi Michał,
On Mon, Sep 05, 2022 at 08:47:11PM +0200, Michał Winiarski wrote:
> When built for UML, KUnit provides virtio/PCI, which means that the
> DMA/IOMEM UML emulation needed by DRM is already present and does not
> need to be manually added with --kconfig_add.
>
> References: commit 6fc3a8636a7b ("kunit: tool: Enable virtio/PCI by default on UML")
> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
> ---
> Documentation/gpu/drm-internals.rst | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/Documentation/gpu/drm-internals.rst b/Documentation/gpu/drm-internals.rst
> index 5fd20a306718..c264a9587d21 100644
> --- a/Documentation/gpu/drm-internals.rst
> +++ b/Documentation/gpu/drm-internals.rst
> @@ -228,16 +228,11 @@ follows:
>
> .. code-block:: bash
>
> - $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests \
> - --kconfig_add CONFIG_VIRTIO_UML=y \
> - --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y
> + $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests
>
> .. note::
> The configuration included in ``.kunitconfig`` should be as generic as
> possible.
> - ``CONFIG_VIRTIO_UML`` and ``CONFIG_UML_PCI_OVER_VIRTIO`` are not
> - included in it because they are only required for User Mode Linux.
> -
>
> Legacy Support Code
> ===================
> --
> 2.37.3
>
Thanks for the patch. This was in my ToDo list and I was waiting until
6fc3a8636a7b was merged in the DRM tree, but since you already fixed it
I can mark it as done.
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-07 17:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-05 18:47 [PATCH] drm/doc: Custom Kconfig for KUnit is no longer needed Michał Winiarski
2022-09-06 1:37 ` Bagas Sanjaya
2022-09-06 8:12 ` Michał Winiarski
2022-09-06 8:53 ` Jonathan Corbet
2022-09-07 17:12 ` José Expósito
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).