* [PATCH 0/2] Remove unused declarations
@ 2022-09-09 4:45 Gaosheng Cui
2022-09-09 4:45 ` [PATCH 1/2] perf sort: remove hist_entry__sort_list and sort__first_dimension declaration Gaosheng Cui
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Gaosheng Cui @ 2022-09-09 4:45 UTC (permalink / raw)
To: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa,
namhyung, atrajeev, eranian, cuigaosheng1
Cc: linux-perf-users, linux-kernel
This series contains a few cleanup patches, to remove unused
declarations which have been removed. Thanks!
Gaosheng Cui (2):
perf sort: remove hist_entry__sort_list and sort__first_dimension
declaration
perf tools: remove perf_pmu_lex declaration
tools/perf/util/pmu.y | 2 --
tools/perf/util/sort.h | 2 --
2 files changed, 4 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] perf sort: remove hist_entry__sort_list and sort__first_dimension declaration
2022-09-09 4:45 [PATCH 0/2] Remove unused declarations Gaosheng Cui
@ 2022-09-09 4:45 ` Gaosheng Cui
2022-09-09 4:45 ` [PATCH 2/2] perf tools: remove perf_pmu_lex declaration Gaosheng Cui
2022-09-09 13:30 ` [PATCH 0/2] Remove unused declarations Arnaldo Carvalho de Melo
2 siblings, 0 replies; 7+ messages in thread
From: Gaosheng Cui @ 2022-09-09 4:45 UTC (permalink / raw)
To: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa,
namhyung, atrajeev, eranian, cuigaosheng1
Cc: linux-perf-users, linux-kernel
hist_entry__sort_list and sort__first_dimension have been removed
since commit cfaa154b2335 ("perf tools: Get rid of obsolete
hist_entry__sort_list"), so remove it.
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
tools/perf/util/sort.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h
index 2ddc00d1c464..af14eb46c2b6 100644
--- a/tools/perf/util/sort.h
+++ b/tools/perf/util/sort.h
@@ -34,7 +34,6 @@ extern struct sort_entry sort_dso_to;
extern struct sort_entry sort_sym_from;
extern struct sort_entry sort_sym_to;
extern struct sort_entry sort_srcline;
-extern enum sort_type sort__first_dimension;
extern const char default_mem_sort_order[];
struct res_sample {
@@ -295,7 +294,6 @@ struct block_hist {
};
extern struct sort_entry sort_thread;
-extern struct list_head hist_entry__sort_list;
struct evlist;
struct tep_handle;
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] perf tools: remove perf_pmu_lex declaration
2022-09-09 4:45 [PATCH 0/2] Remove unused declarations Gaosheng Cui
2022-09-09 4:45 ` [PATCH 1/2] perf sort: remove hist_entry__sort_list and sort__first_dimension declaration Gaosheng Cui
@ 2022-09-09 4:45 ` Gaosheng Cui
2022-09-09 10:29 ` James Clark
2022-09-09 13:30 ` [PATCH 0/2] Remove unused declarations Arnaldo Carvalho de Melo
2 siblings, 1 reply; 7+ messages in thread
From: Gaosheng Cui @ 2022-09-09 4:45 UTC (permalink / raw)
To: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa,
namhyung, atrajeev, eranian, cuigaosheng1
Cc: linux-perf-users, linux-kernel
perf_pmu_lex has been removed since
commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
so remove it.
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
tools/perf/util/pmu.y | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/perf/util/pmu.y b/tools/perf/util/pmu.y
index bfd7e8509869..0dab0ec2eff7 100644
--- a/tools/perf/util/pmu.y
+++ b/tools/perf/util/pmu.y
@@ -10,8 +10,6 @@
#include <string.h>
#include "pmu.h"
-extern int perf_pmu_lex (void);
-
#define ABORT_ON(val) \
do { \
if (val) \
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] perf tools: remove perf_pmu_lex declaration
2022-09-09 4:45 ` [PATCH 2/2] perf tools: remove perf_pmu_lex declaration Gaosheng Cui
@ 2022-09-09 10:29 ` James Clark
2022-09-09 13:43 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 7+ messages in thread
From: James Clark @ 2022-09-09 10:29 UTC (permalink / raw)
To: Gaosheng Cui
Cc: linux-perf-users, linux-kernel, peterz, mingo, acme,
mark.rutland, alexander.shishkin, jolsa, namhyung, atrajeev,
eranian
On 09/09/2022 05:45, Gaosheng Cui wrote:
> perf_pmu_lex has been removed since
> commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
> so remove it.
Not 100% sure if that is the right commit to reference because it didn't
touch pmu.y.
perf_pmu_lex is still used and there are plenty of references to it, but
maybe the extern declaration isn't needed anymore because it still
builds for me with this change.
>
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
> tools/perf/util/pmu.y | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/perf/util/pmu.y b/tools/perf/util/pmu.y
> index bfd7e8509869..0dab0ec2eff7 100644
> --- a/tools/perf/util/pmu.y
> +++ b/tools/perf/util/pmu.y
> @@ -10,8 +10,6 @@
> #include <string.h>
> #include "pmu.h"
>
> -extern int perf_pmu_lex (void);
> -
> #define ABORT_ON(val) \
> do { \
> if (val) \
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] Remove unused declarations
2022-09-09 4:45 [PATCH 0/2] Remove unused declarations Gaosheng Cui
2022-09-09 4:45 ` [PATCH 1/2] perf sort: remove hist_entry__sort_list and sort__first_dimension declaration Gaosheng Cui
2022-09-09 4:45 ` [PATCH 2/2] perf tools: remove perf_pmu_lex declaration Gaosheng Cui
@ 2022-09-09 13:30 ` Arnaldo Carvalho de Melo
2 siblings, 0 replies; 7+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-09-09 13:30 UTC (permalink / raw)
To: Gaosheng Cui
Cc: peterz, mingo, mark.rutland, alexander.shishkin, jolsa, namhyung,
atrajeev, eranian, linux-perf-users, linux-kernel
Em Fri, Sep 09, 2022 at 12:45:40PM +0800, Gaosheng Cui escreveu:
> This series contains a few cleanup patches, to remove unused
> declarations which have been removed. Thanks!
Thanks, applied.
- Arnaldo
> Gaosheng Cui (2):
> perf sort: remove hist_entry__sort_list and sort__first_dimension
> declaration
> perf tools: remove perf_pmu_lex declaration
>
> tools/perf/util/pmu.y | 2 --
> tools/perf/util/sort.h | 2 --
> 2 files changed, 4 deletions(-)
>
> --
> 2.25.1
--
- Arnaldo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] perf tools: remove perf_pmu_lex declaration
2022-09-09 10:29 ` James Clark
@ 2022-09-09 13:43 ` Arnaldo Carvalho de Melo
2022-09-09 13:46 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 7+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-09-09 13:43 UTC (permalink / raw)
To: James Clark
Cc: Gaosheng Cui, linux-perf-users, linux-kernel, peterz, mingo,
mark.rutland, alexander.shishkin, jolsa, namhyung, atrajeev,
eranian
Em Fri, Sep 09, 2022 at 11:29:43AM +0100, James Clark escreveu:
>
>
> On 09/09/2022 05:45, Gaosheng Cui wrote:
> > perf_pmu_lex has been removed since
> > commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
> > so remove it.
>
> Not 100% sure if that is the right commit to reference because it didn't
> touch pmu.y.
Yeah, indeed, unsure if at that time the declaration was needed.
> perf_pmu_lex is still used and there are plenty of references to it, but
> maybe the extern declaration isn't needed anymore because it still
> builds for me with this change.
Ditto here, I'll remove the reference and rewrite the cset log a bit.
- Arnaldo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] perf tools: remove perf_pmu_lex declaration
2022-09-09 13:43 ` Arnaldo Carvalho de Melo
@ 2022-09-09 13:46 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 7+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-09-09 13:46 UTC (permalink / raw)
To: James Clark
Cc: Gaosheng Cui, linux-perf-users, linux-kernel, peterz, mingo,
mark.rutland, alexander.shishkin, jolsa, namhyung, atrajeev,
eranian
Em Fri, Sep 09, 2022 at 10:43:52AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Sep 09, 2022 at 11:29:43AM +0100, James Clark escreveu:
> >
> >
> > On 09/09/2022 05:45, Gaosheng Cui wrote:
> > > perf_pmu_lex has been removed since
> > > commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
> > > so remove it.
> >
> > Not 100% sure if that is the right commit to reference because it didn't
> > touch pmu.y.
>
> Yeah, indeed, unsure if at that time the declaration was needed.
>
> > perf_pmu_lex is still used and there are plenty of references to it, but
> > maybe the extern declaration isn't needed anymore because it still
> > builds for me with this change.
>
> Ditto here, I'll remove the reference and rewrite the cset log a bit.
I left it as:
perf pmu: Remove perf_pmu_lex() needless declaration
It builds without it, perhaps with some older combination of flex/bison
we needed this, clean it up a bit removing this.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-09-09 13:47 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-09 4:45 [PATCH 0/2] Remove unused declarations Gaosheng Cui
2022-09-09 4:45 ` [PATCH 1/2] perf sort: remove hist_entry__sort_list and sort__first_dimension declaration Gaosheng Cui
2022-09-09 4:45 ` [PATCH 2/2] perf tools: remove perf_pmu_lex declaration Gaosheng Cui
2022-09-09 10:29 ` James Clark
2022-09-09 13:43 ` Arnaldo Carvalho de Melo
2022-09-09 13:46 ` Arnaldo Carvalho de Melo
2022-09-09 13:30 ` [PATCH 0/2] Remove unused declarations Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).