* [PATCH v2 10/13] iommu/rockchip: Constrain return value of ->attach_dev()
@ 2022-09-14 5:15 Nicolin Chen
0 siblings, 0 replies; only message in thread
From: Nicolin Chen @ 2022-09-14 5:15 UTC (permalink / raw)
To: joro, will, robin.murphy, heiko
Cc: jgg, kevin.tian, iommu, linux-arm-kernel, linux-rockchip, linux-kernel
Ensure attach_dev() callback functions only return errno values expected
from the attach_dev() op.
Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
---
drivers/iommu/rockchip-iommu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c
index ab57c4b8fade..de483b5532ed 100644
--- a/drivers/iommu/rockchip-iommu.c
+++ b/drivers/iommu/rockchip-iommu.c
@@ -1051,8 +1051,10 @@ static int rk_iommu_attach_device(struct iommu_domain *domain,
return 0;
ret = rk_iommu_enable(iommu);
- if (ret)
+ if (ret) {
rk_iommu_detach_device(iommu->domain, dev);
+ ret = -ENODEV;
+ }
pm_runtime_put(iommu->dev);
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-09-14 5:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-14 5:15 [PATCH v2 10/13] iommu/rockchip: Constrain return value of ->attach_dev() Nicolin Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).