* [PATCH v2] interconnect: qcom: Kconfig: Make INTERCONNECT_QCOM tristate
@ 2022-09-14 6:41 Huang Yiwei
2022-09-14 14:24 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Huang Yiwei @ 2022-09-14 6:41 UTC (permalink / raw)
To: djakov, agross, konrad.dybcio
Cc: dmitry.baryshkov, leo.yan, linux-arm-msm, linux-pm, linux-kernel,
Huang Yiwei
Make INTERCONNECT_QCOM tristate so that icc-common.c can be
compiled as a module.
Signed-off-by: Huang Yiwei <quic_hyiwei@quicinc.com>
---
drivers/interconnect/qcom/Kconfig | 2 +-
drivers/interconnect/qcom/icc-common.c | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qcom/Kconfig
index 25d5b4baf6f6..1a1c941635a2 100644
--- a/drivers/interconnect/qcom/Kconfig
+++ b/drivers/interconnect/qcom/Kconfig
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config INTERCONNECT_QCOM
- bool "Qualcomm Network-on-Chip interconnect drivers"
+ tristate "Qualcomm Network-on-Chip interconnect drivers"
depends on ARCH_QCOM
help
Support for Qualcomm's Network-on-Chip interconnect hardware.
diff --git a/drivers/interconnect/qcom/icc-common.c b/drivers/interconnect/qcom/icc-common.c
index 0822ce207b5d..f27f4fdc4531 100644
--- a/drivers/interconnect/qcom/icc-common.c
+++ b/drivers/interconnect/qcom/icc-common.c
@@ -5,6 +5,7 @@
#include <linux/of.h>
#include <linux/slab.h>
+#include <linux/module.h>
#include "icc-common.h"
@@ -32,3 +33,5 @@ struct icc_node_data *qcom_icc_xlate_extended(struct of_phandle_args *spec, void
return ndata;
}
EXPORT_SYMBOL_GPL(qcom_icc_xlate_extended);
+
+MODULE_LICENSE("GPL");
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] interconnect: qcom: Kconfig: Make INTERCONNECT_QCOM tristate
2022-09-14 6:41 [PATCH v2] interconnect: qcom: Kconfig: Make INTERCONNECT_QCOM tristate Huang Yiwei
@ 2022-09-14 14:24 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2022-09-14 14:24 UTC (permalink / raw)
To: Huang Yiwei
Cc: djakov, agross, konrad.dybcio, dmitry.baryshkov, leo.yan,
linux-arm-msm, linux-pm, linux-kernel
On Wed, Sep 14, 2022 at 02:41:22PM +0800, Huang Yiwei wrote:
> Make INTERCONNECT_QCOM tristate so that icc-common.c can be
> compiled as a module.
>
> Signed-off-by: Huang Yiwei <quic_hyiwei@quicinc.com>
Looks like this could be useful to other platforms that need of_xlate
with tags, so we should be able to push this helper into the
interconnect core and get rid of icc-common.c.
But in the meantime, I like your change.
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Regards,
Bjorn
> ---
> drivers/interconnect/qcom/Kconfig | 2 +-
> drivers/interconnect/qcom/icc-common.c | 3 +++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qcom/Kconfig
> index 25d5b4baf6f6..1a1c941635a2 100644
> --- a/drivers/interconnect/qcom/Kconfig
> +++ b/drivers/interconnect/qcom/Kconfig
> @@ -1,6 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config INTERCONNECT_QCOM
> - bool "Qualcomm Network-on-Chip interconnect drivers"
> + tristate "Qualcomm Network-on-Chip interconnect drivers"
> depends on ARCH_QCOM
> help
> Support for Qualcomm's Network-on-Chip interconnect hardware.
> diff --git a/drivers/interconnect/qcom/icc-common.c b/drivers/interconnect/qcom/icc-common.c
> index 0822ce207b5d..f27f4fdc4531 100644
> --- a/drivers/interconnect/qcom/icc-common.c
> +++ b/drivers/interconnect/qcom/icc-common.c
> @@ -5,6 +5,7 @@
>
> #include <linux/of.h>
> #include <linux/slab.h>
> +#include <linux/module.h>
>
> #include "icc-common.h"
>
> @@ -32,3 +33,5 @@ struct icc_node_data *qcom_icc_xlate_extended(struct of_phandle_args *spec, void
> return ndata;
> }
> EXPORT_SYMBOL_GPL(qcom_icc_xlate_extended);
> +
> +MODULE_LICENSE("GPL");
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-14 14:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-14 6:41 [PATCH v2] interconnect: qcom: Kconfig: Make INTERCONNECT_QCOM tristate Huang Yiwei
2022-09-14 14:24 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).