* [PATCH] of: device: fix repeated words in comments
@ 2022-09-18 9:49 Jilin Yuan
2022-09-26 18:58 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Jilin Yuan @ 2022-09-18 9:49 UTC (permalink / raw)
To: robh+dt, frowand.list; +Cc: devicetree, linux-kernel, Jilin Yuan
Delete the redundant word 'of'.
Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
drivers/of/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/device.c b/drivers/of/device.c
index 75b6cbffa755..6158173b92ad 100644
--- a/drivers/of/device.c
+++ b/drivers/of/device.c
@@ -19,7 +19,7 @@
/**
* of_match_device - Tell if a struct device matches an of_device_id list
- * @matches: array of of device match structures to search in
+ * @matches: array of device match structures to search in
* @dev: the of device structure to match against
*
* Used by a driver to check whether an platform_device present in the
--
2.36.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] of: device: fix repeated words in comments
2022-09-18 9:49 [PATCH] of: device: fix repeated words in comments Jilin Yuan
@ 2022-09-26 18:58 ` Rob Herring
2022-09-27 2:04 ` Bagas Sanjaya
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2022-09-26 18:58 UTC (permalink / raw)
To: Jilin Yuan; +Cc: frowand.list, devicetree, linux-kernel
On Sun, Sep 18, 2022 at 05:49:15PM +0800, Jilin Yuan wrote:
> Delete the redundant word 'of'.
Again? Sigh.
Please read:
https://lore.kernel.org/all/CAL_JsqL4GvgFYzGUfhW5pvm4wYGrFaj6gHOYZjnOMuk2zCz67w@mail.gmail.com/
>
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
Are you sure you are the author?
> ---
> drivers/of/device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/device.c b/drivers/of/device.c
> index 75b6cbffa755..6158173b92ad 100644
> --- a/drivers/of/device.c
> +++ b/drivers/of/device.c
> @@ -19,7 +19,7 @@
>
> /**
> * of_match_device - Tell if a struct device matches an of_device_id list
> - * @matches: array of of device match structures to search in
> + * @matches: array of device match structures to search in
> * @dev: the of device structure to match against
> *
> * Used by a driver to check whether an platform_device present in the
> --
> 2.36.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] of: device: fix repeated words in comments
2022-09-26 18:58 ` Rob Herring
@ 2022-09-27 2:04 ` Bagas Sanjaya
2022-09-27 12:29 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Bagas Sanjaya @ 2022-09-27 2:04 UTC (permalink / raw)
To: Rob Herring; +Cc: Jilin Yuan, frowand.list, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]
On Mon, Sep 26, 2022 at 01:58:52PM -0500, Rob Herring wrote:
> On Sun, Sep 18, 2022 at 05:49:15PM +0800, Jilin Yuan wrote:
> > Delete the redundant word 'of'.
>
> Again? Sigh.
>
> Please read:
>
> https://lore.kernel.org/all/CAL_JsqL4GvgFYzGUfhW5pvm4wYGrFaj6gHOYZjnOMuk2zCz67w@mail.gmail.com/
>
> >
> > Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
>
> Are you sure you are the author?
>
Hi Rob,
Some reviewers sent comments for similar patches from @cdjrlc.com
people (including myself at [1]), with some of them requesting changes.
However, there are never any responses to these reviews from @cdjrlc.com
people, just like ZTE developers sending through cgel.zte ignored
review comments [2] (try searching `f:"cdjrlc.com" AND s:"Re:"`, it returns
nothing for now).
Thanks.
[1]: https://lore.kernel.org/lkml/YyclQlws9d7vheDk@debian.me/
[2]: https://lore.kernel.org/lkml/878rn1dd8l.fsf@intel.com/
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] of: device: fix repeated words in comments
2022-09-27 2:04 ` Bagas Sanjaya
@ 2022-09-27 12:29 ` Rob Herring
2022-09-27 12:47 ` Bagas Sanjaya
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2022-09-27 12:29 UTC (permalink / raw)
To: Bagas Sanjaya; +Cc: Jilin Yuan, frowand.list, devicetree, linux-kernel
On Mon, Sep 26, 2022 at 9:04 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On Mon, Sep 26, 2022 at 01:58:52PM -0500, Rob Herring wrote:
> > On Sun, Sep 18, 2022 at 05:49:15PM +0800, Jilin Yuan wrote:
> > > Delete the redundant word 'of'.
> >
> > Again? Sigh.
> >
> > Please read:
> >
> > https://lore.kernel.org/all/CAL_JsqL4GvgFYzGUfhW5pvm4wYGrFaj6gHOYZjnOMuk2zCz67w@mail.gmail.com/
> >
> > >
> > > Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> >
> > Are you sure you are the author?
> >
>
> Hi Rob,
>
> Some reviewers sent comments for similar patches from @cdjrlc.com
> people (including myself at [1]), with some of them requesting changes.
> However, there are never any responses to these reviews from @cdjrlc.com
> people, just like ZTE developers sending through cgel.zte ignored
> review comments [2] (try searching `f:"cdjrlc.com" AND s:"Re:"`, it returns
> nothing for now).
I can't decide whether to fix it correctly myself or leave it to see
how many times I can get the same patch. :)
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] of: device: fix repeated words in comments
2022-09-27 12:29 ` Rob Herring
@ 2022-09-27 12:47 ` Bagas Sanjaya
2022-09-27 14:07 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Bagas Sanjaya @ 2022-09-27 12:47 UTC (permalink / raw)
To: Rob Herring; +Cc: Jilin Yuan, frowand.list, devicetree, linux-kernel
On 9/27/22 19:29, Rob Herring wrote:
>> Hi Rob,
>>
>> Some reviewers sent comments for similar patches from @cdjrlc.com
>> people (including myself at [1]), with some of them requesting changes.
>> However, there are never any responses to these reviews from @cdjrlc.com
>> people, just like ZTE developers sending through cgel.zte ignored
>> review comments [2] (try searching `f:"cdjrlc.com" AND s:"Re:"`, it returns
>> nothing for now).
>
> I can't decide whether to fix it correctly myself or leave it to see
> how many times I can get the same patch. :)
>
Hi Rob,
I'm not talking about whether this patch should be picked up or not, but
rather I'm pointing out the ignoring review behavior of @cdjrlc.com people.
Thanks.
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] of: device: fix repeated words in comments
2022-09-27 12:47 ` Bagas Sanjaya
@ 2022-09-27 14:07 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-09-27 14:07 UTC (permalink / raw)
To: Bagas Sanjaya; +Cc: Jilin Yuan, frowand.list, devicetree, linux-kernel
On Tue, Sep 27, 2022 at 7:47 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On 9/27/22 19:29, Rob Herring wrote:
> >> Hi Rob,
> >>
> >> Some reviewers sent comments for similar patches from @cdjrlc.com
> >> people (including myself at [1]), with some of them requesting changes.
> >> However, there are never any responses to these reviews from @cdjrlc.com
> >> people, just like ZTE developers sending through cgel.zte ignored
> >> review comments [2] (try searching `f:"cdjrlc.com" AND s:"Re:"`, it returns
> >> nothing for now).
> >
> > I can't decide whether to fix it correctly myself or leave it to see
> > how many times I can get the same patch. :)
> >
>
> Hi Rob,
>
> I'm not talking about whether this patch should be picked up or not, but
> rather I'm pointing out the ignoring review behavior of @cdjrlc.com people.
Yes, I get that. Not responding seems to be a growing behavior not
just on these trivial type patches. (Though replying with 'ok' to
every review comment is equally annoying.) I suppose there could be
some filtering happening such that replies are never received.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-27 14:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-18 9:49 [PATCH] of: device: fix repeated words in comments Jilin Yuan
2022-09-26 18:58 ` Rob Herring
2022-09-27 2:04 ` Bagas Sanjaya
2022-09-27 12:29 ` Rob Herring
2022-09-27 12:47 ` Bagas Sanjaya
2022-09-27 14:07 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).