* [PATCH 0/2] Mediatek ethernet patchs for mt8188 @ 2022-09-19 8:04 Jianguo Zhang 2022-09-19 8:04 ` [PATCH 1/2] stmmac: dwmac-mediatek: add support " Jianguo Zhang 2022-09-19 8:04 ` [PATCH 2/2] net: dt-bindings: dwmac: " Jianguo Zhang 0 siblings, 2 replies; 12+ messages in thread From: Jianguo Zhang @ 2022-09-19 8:04 UTC (permalink / raw) To: David S . Miller, Rob Herring Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Krzysztof Kozlowski, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger, Biao Huang, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-mediatek, Jianguo Zhang This series includes 2 patchs: 1. add ethenet driver entry for mt8188 2. add binding document for the ethernet on mt8188 Jianguo Zhang (2): stmmac: dwmac-mediatek: add support for mt8188 net: dt-bindings: dwmac: add support for mt8188 Documentation/devicetree/bindings/net/mediatek-dwmac.yaml | 6 ++++-- drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) -- 2.25.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/2] stmmac: dwmac-mediatek: add support for mt8188 2022-09-19 8:04 [PATCH 0/2] Mediatek ethernet patchs for mt8188 Jianguo Zhang @ 2022-09-19 8:04 ` Jianguo Zhang 2022-09-19 8:19 ` Krzysztof Kozlowski 2022-09-19 8:04 ` [PATCH 2/2] net: dt-bindings: dwmac: " Jianguo Zhang 1 sibling, 1 reply; 12+ messages in thread From: Jianguo Zhang @ 2022-09-19 8:04 UTC (permalink / raw) To: David S . Miller, Rob Herring Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Krzysztof Kozlowski, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger, Biao Huang, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-mediatek, Jianguo Zhang Add ethernet support for MediaTek SoCs from mt8188 family. As mt8188 and mt8195 have same ethernet design, so private data "mt8195_gmac_variant" can be reused for mt8188. Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c index d42e1afb6521..f45be440b6d0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c @@ -720,6 +720,8 @@ static const struct of_device_id mediatek_dwmac_match[] = { .data = &mt2712_gmac_variant }, { .compatible = "mediatek,mt8195-gmac", .data = &mt8195_gmac_variant }, + { .compatible = "mediatek,mt8188-gmac", + .data = &mt8195_gmac_variant }, { } }; -- 2.25.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] stmmac: dwmac-mediatek: add support for mt8188 2022-09-19 8:04 ` [PATCH 1/2] stmmac: dwmac-mediatek: add support " Jianguo Zhang @ 2022-09-19 8:19 ` Krzysztof Kozlowski 2022-09-19 8:37 ` Jianguo Zhang 0 siblings, 1 reply; 12+ messages in thread From: Krzysztof Kozlowski @ 2022-09-19 8:19 UTC (permalink / raw) To: Jianguo Zhang, David S . Miller, Rob Herring Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Krzysztof Kozlowski, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger, Biao Huang, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-mediatek On 19/09/2022 10:04, Jianguo Zhang wrote: > Add ethernet support for MediaTek SoCs from mt8188 family. > As mt8188 and mt8195 have same ethernet design, so private data > "mt8195_gmac_variant" can be reused for mt8188. > > Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c > index d42e1afb6521..f45be440b6d0 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c > @@ -720,6 +720,8 @@ static const struct of_device_id mediatek_dwmac_match[] = { > .data = &mt2712_gmac_variant }, > { .compatible = "mediatek,mt8195-gmac", > .data = &mt8195_gmac_variant }, > + { .compatible = "mediatek,mt8188-gmac", > + .data = &mt8195_gmac_variant }, It's the same. No need for new entry. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] stmmac: dwmac-mediatek: add support for mt8188 2022-09-19 8:19 ` Krzysztof Kozlowski @ 2022-09-19 8:37 ` Jianguo Zhang 2022-09-19 9:27 ` Krzysztof Kozlowski 0 siblings, 1 reply; 12+ messages in thread From: Jianguo Zhang @ 2022-09-19 8:37 UTC (permalink / raw) To: Krzysztof Kozlowski, David S . Miller, Rob Herring Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Krzysztof Kozlowski, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger, Biao Huang, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-mediatek Dear Krzysztof, Thanks for your comments. On Mon, 2022-09-19 at 10:19 +0200, Krzysztof Kozlowski wrote: > On 19/09/2022 10:04, Jianguo Zhang wrote: > > Add ethernet support for MediaTek SoCs from mt8188 family. > > As mt8188 and mt8195 have same ethernet design, so private data > > "mt8195_gmac_variant" can be reused for mt8188. > > > > Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> > > --- > > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c > > b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c > > index d42e1afb6521..f45be440b6d0 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c > > @@ -720,6 +720,8 @@ static const struct of_device_id > > mediatek_dwmac_match[] = { > > .data = &mt2712_gmac_variant }, > > { .compatible = "mediatek,mt8195-gmac", > > .data = &mt8195_gmac_variant }, > > + { .compatible = "mediatek,mt8188-gmac", > > + .data = &mt8195_gmac_variant }, > > It's the same. No need for new entry. > mt8188 and mt8195 are different SoCs and we need to distinguish mt8188 from mt8195, so I think a new entry is needed for mt8188 with the specific "compatiable". On the other hand, mt8188 and mt8195 have same ethernet design, so the private data "mt8195_gmac_variant" can be resued to reduce redundant info in driver. > > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] stmmac: dwmac-mediatek: add support for mt8188 2022-09-19 8:37 ` Jianguo Zhang @ 2022-09-19 9:27 ` Krzysztof Kozlowski 2022-09-19 9:56 ` Jianguo Zhang 0 siblings, 1 reply; 12+ messages in thread From: Krzysztof Kozlowski @ 2022-09-19 9:27 UTC (permalink / raw) To: Jianguo Zhang, David S . Miller, Rob Herring Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Krzysztof Kozlowski, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger, Biao Huang, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-mediatek On 19/09/2022 10:37, Jianguo Zhang wrote: > Dear Krzysztof, > > Thanks for your comments. > > > On Mon, 2022-09-19 at 10:19 +0200, Krzysztof Kozlowski wrote: >> On 19/09/2022 10:04, Jianguo Zhang wrote: >>> Add ethernet support for MediaTek SoCs from mt8188 family. >>> As mt8188 and mt8195 have same ethernet design, so private data >>> "mt8195_gmac_variant" can be reused for mt8188. >>> >>> Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> >>> --- >>> drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c >>> b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c >>> index d42e1afb6521..f45be440b6d0 100644 >>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c >>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c >>> @@ -720,6 +720,8 @@ static const struct of_device_id >>> mediatek_dwmac_match[] = { >>> .data = &mt2712_gmac_variant }, >>> { .compatible = "mediatek,mt8195-gmac", >>> .data = &mt8195_gmac_variant }, >>> + { .compatible = "mediatek,mt8188-gmac", >>> + .data = &mt8195_gmac_variant }, >> >> It's the same. No need for new entry. >> > mt8188 and mt8195 are different SoCs and we need to distinguish mt8188 > from mt8195, so I think a new entry is needed for mt8188 with the > specific "compatiable". No, this does not justify new entry. You need specific compatible, but not new entry. > On the other hand, mt8188 and mt8195 have same ethernet design, so the > private data "mt8195_gmac_variant" can be resued to reduce redundant > info in driver. And you do not need new entry in the driver. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] stmmac: dwmac-mediatek: add support for mt8188 2022-09-19 9:27 ` Krzysztof Kozlowski @ 2022-09-19 9:56 ` Jianguo Zhang 2022-09-19 10:06 ` Krzysztof Kozlowski 0 siblings, 1 reply; 12+ messages in thread From: Jianguo Zhang @ 2022-09-19 9:56 UTC (permalink / raw) To: Krzysztof Kozlowski, David S . Miller, Rob Herring Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Krzysztof Kozlowski, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger, Biao Huang, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-mediatek Dear Krzysztof, On Mon, 2022-09-19 at 11:27 +0200, Krzysztof Kozlowski wrote: > On 19/09/2022 10:37, Jianguo Zhang wrote: > > Dear Krzysztof, > > > > Thanks for your comments. > > > > > > On Mon, 2022-09-19 at 10:19 +0200, Krzysztof Kozlowski wrote: > > > On 19/09/2022 10:04, Jianguo Zhang wrote: > > > > Add ethernet support for MediaTek SoCs from mt8188 family. > > > > As mt8188 and mt8195 have same ethernet design, so private data > > > > "mt8195_gmac_variant" can be reused for mt8188. > > > > > > > > Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> > > > > --- > > > > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac- > > > > mediatek.c > > > > b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c > > > > index d42e1afb6521..f45be440b6d0 100644 > > > > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c > > > > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c > > > > @@ -720,6 +720,8 @@ static const struct of_device_id > > > > mediatek_dwmac_match[] = { > > > > .data = &mt2712_gmac_variant }, > > > > { .compatible = "mediatek,mt8195-gmac", > > > > .data = &mt8195_gmac_variant }, > > > > + { .compatible = "mediatek,mt8188-gmac", > > > > + .data = &mt8195_gmac_variant }, > > > > > > It's the same. No need for new entry. > > > > > > > mt8188 and mt8195 are different SoCs and we need to distinguish > > mt8188 > > from mt8195, so I think a new entry is needed for mt8188 with the > > specific "compatiable". > > No, this does not justify new entry. You need specific compatible, > but > not new entry. > > > On the other hand, mt8188 and mt8195 have same ethernet design, so > > the > > private data "mt8195_gmac_variant" can be resued to reduce > > redundant > > info in driver. > > And you do not need new entry in the driver. Do you mean that I can use "mediatek,mt8195-gmac" as compatible for ethernet in mt8188 DTS file? > > Best regards, > Krzysztof BRS Jianguo ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] stmmac: dwmac-mediatek: add support for mt8188 2022-09-19 9:56 ` Jianguo Zhang @ 2022-09-19 10:06 ` Krzysztof Kozlowski 2022-09-20 2:33 ` Jianguo Zhang 0 siblings, 1 reply; 12+ messages in thread From: Krzysztof Kozlowski @ 2022-09-19 10:06 UTC (permalink / raw) To: Jianguo Zhang, David S . Miller, Rob Herring Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Krzysztof Kozlowski, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger, Biao Huang, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-mediatek On 19/09/2022 11:56, Jianguo Zhang wrote: >> No, this does not justify new entry. You need specific compatible, >> but >> not new entry. >> >>> On the other hand, mt8188 and mt8195 have same ethernet design, so >>> the >>> private data "mt8195_gmac_variant" can be resued to reduce >>> redundant >>> info in driver. >> >> And you do not need new entry in the driver. > Do you mean that I can use "mediatek,mt8195-gmac" as compatible for > ethernet in mt8188 DTS file? Yes, as a fallback. Example schema describes such case. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] stmmac: dwmac-mediatek: add support for mt8188 2022-09-19 10:06 ` Krzysztof Kozlowski @ 2022-09-20 2:33 ` Jianguo Zhang 0 siblings, 0 replies; 12+ messages in thread From: Jianguo Zhang @ 2022-09-20 2:33 UTC (permalink / raw) To: Krzysztof Kozlowski, David S . Miller, Rob Herring Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Krzysztof Kozlowski, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger, Biao Huang, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-mediatek Dear Krzysztof, Thanks for your comment. On Mon, 2022-09-19 at 12:06 +0200, Krzysztof Kozlowski wrote: > On 19/09/2022 11:56, Jianguo Zhang wrote: > > > No, this does not justify new entry. You need specific > > > compatible, > > > but > > > not new entry. > > > > > > > On the other hand, mt8188 and mt8195 have same ethernet design, > > > > so > > > > the > > > > private data "mt8195_gmac_variant" can be resued to reduce > > > > redundant > > > > info in driver. > > > > > > And you do not need new entry in the driver. > > > > Do you mean that I can use "mediatek,mt8195-gmac" as compatible for > > ethernet in mt8188 DTS file? > > Yes, as a fallback. Example schema describes such case. > OK, we will drop the changes in patch #1 and add MT8188 related info in binding document in next version patches. > Best regards, > Krzysztof > BRS Jianguo ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/2] net: dt-bindings: dwmac: add support for mt8188 2022-09-19 8:04 [PATCH 0/2] Mediatek ethernet patchs for mt8188 Jianguo Zhang 2022-09-19 8:04 ` [PATCH 1/2] stmmac: dwmac-mediatek: add support " Jianguo Zhang @ 2022-09-19 8:04 ` Jianguo Zhang 2022-09-19 8:20 ` Krzysztof Kozlowski 2022-09-19 16:24 ` Krzysztof Kozlowski 1 sibling, 2 replies; 12+ messages in thread From: Jianguo Zhang @ 2022-09-19 8:04 UTC (permalink / raw) To: David S . Miller, Rob Herring Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Krzysztof Kozlowski, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger, Biao Huang, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-mediatek, Jianguo Zhang Add binding document for the ethernet on mt8188 Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> --- Documentation/devicetree/bindings/net/mediatek-dwmac.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml index 61b2fb9e141b..b7d4f956f92e 100644 --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml @@ -20,6 +20,7 @@ select: enum: - mediatek,mt2712-gmac - mediatek,mt8195-gmac + - mediatek,mt8188-gmac required: - compatible @@ -36,6 +37,7 @@ properties: - items: - enum: - mediatek,mt8195-gmac + - mediatek,mt8188-gmac - const: snps,dwmac-5.10a clocks: @@ -74,7 +76,7 @@ properties: or will round down. Range 0~31*170. For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550, or will round down. Range 0~31*550. - For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290, + For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290, or will round down. Range 0~31*290. mediatek,rx-delay-ps: @@ -84,7 +86,7 @@ properties: or will round down. Range 0~31*170. For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550, or will round down. Range 0~31*550. - For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple + For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290, or will round down. Range 0~31*290. mediatek,rmii-rxc: -- 2.25.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] net: dt-bindings: dwmac: add support for mt8188 2022-09-19 8:04 ` [PATCH 2/2] net: dt-bindings: dwmac: " Jianguo Zhang @ 2022-09-19 8:20 ` Krzysztof Kozlowski 2022-09-19 16:24 ` Krzysztof Kozlowski 1 sibling, 0 replies; 12+ messages in thread From: Krzysztof Kozlowski @ 2022-09-19 8:20 UTC (permalink / raw) To: Jianguo Zhang, David S . Miller, Rob Herring Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Krzysztof Kozlowski, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger, Biao Huang, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-mediatek On 19/09/2022 10:04, Jianguo Zhang wrote: > Add binding document for the ethernet on mt8188 > > Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> > --- > Documentation/devicetree/bindings/net/mediatek-dwmac.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > index 61b2fb9e141b..b7d4f956f92e 100644 > --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > @@ -20,6 +20,7 @@ select: > enum: > - mediatek,mt2712-gmac > - mediatek,mt8195-gmac > + - mediatek,mt8188-gmac Won't be needed after comment below. > required: > - compatible > > @@ -36,6 +37,7 @@ properties: > - items: > - enum: > - mediatek,mt8195-gmac > + - mediatek,mt8188-gmac That's not what your driver change is saying. They are the same or compatible according to your patch #1. > - const: snps,dwmac-5.10a Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] net: dt-bindings: dwmac: add support for mt8188 2022-09-19 8:04 ` [PATCH 2/2] net: dt-bindings: dwmac: " Jianguo Zhang 2022-09-19 8:20 ` Krzysztof Kozlowski @ 2022-09-19 16:24 ` Krzysztof Kozlowski 2022-09-20 2:41 ` Jianguo Zhang 1 sibling, 1 reply; 12+ messages in thread From: Krzysztof Kozlowski @ 2022-09-19 16:24 UTC (permalink / raw) To: Jianguo Zhang Cc: netdev, Alexandre Torgue, Krzysztof Kozlowski, Biao Huang, devicetree, linux-mediatek, Jakub Kicinski, Paolo Abeni, David S . Miller, Matthias Brugger, linux-arm-kernel, linux-stm32, Jose Abreu, Rob Herring, Maxime Coquelin, linux-kernel, Giuseppe Cavallaro, Eric Dumazet On Mon, 19 Sep 2022 16:04:10 +0800, Jianguo Zhang wrote: > Add binding document for the ethernet on mt8188 > > Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> > --- > Documentation/devicetree/bindings/net/mediatek-dwmac.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ ethernet@1101c000: Unevaluated properties are not allowed ('clk_csr' was unexpected) arch/arm64/boot/dts/mediatek/mt2712-evb.dtb ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] net: dt-bindings: dwmac: add support for mt8188 2022-09-19 16:24 ` Krzysztof Kozlowski @ 2022-09-20 2:41 ` Jianguo Zhang 0 siblings, 0 replies; 12+ messages in thread From: Jianguo Zhang @ 2022-09-20 2:41 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: netdev, Alexandre Torgue, Krzysztof Kozlowski, Biao Huang, devicetree, linux-mediatek, Jakub Kicinski, Paolo Abeni, David S . Miller, Matthias Brugger, linux-arm-kernel, linux-stm32, Jose Abreu, Rob Herring, Maxime Coquelin, linux-kernel, Giuseppe Cavallaro, Eric Dumazet Dear Krzysztof, Thanks for your comment. On Mon, 2022-09-19 at 18:24 +0200, Krzysztof Kozlowski wrote: > 'clk_csr' 'clk_csr' properity is parsed in driver, but it is not documented in bingings for now. We will push a patch to describe 'clk_csr' in snps,dwmac.yaml file in next version patches. BRS Jianguo ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-09-20 2:42 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-09-19 8:04 [PATCH 0/2] Mediatek ethernet patchs for mt8188 Jianguo Zhang 2022-09-19 8:04 ` [PATCH 1/2] stmmac: dwmac-mediatek: add support " Jianguo Zhang 2022-09-19 8:19 ` Krzysztof Kozlowski 2022-09-19 8:37 ` Jianguo Zhang 2022-09-19 9:27 ` Krzysztof Kozlowski 2022-09-19 9:56 ` Jianguo Zhang 2022-09-19 10:06 ` Krzysztof Kozlowski 2022-09-20 2:33 ` Jianguo Zhang 2022-09-19 8:04 ` [PATCH 2/2] net: dt-bindings: dwmac: " Jianguo Zhang 2022-09-19 8:20 ` Krzysztof Kozlowski 2022-09-19 16:24 ` Krzysztof Kozlowski 2022-09-20 2:41 ` Jianguo Zhang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).