From: Bjorn Helgaas <helgaas@kernel.org>
To: Krishna chaitanya chundru <quic_krichai@quicinc.com>
Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, mka@chromium.org,
quic_vbadigan@quicinc.com, quic_hemantk@quicinc.com,
quic_nitegupt@quicinc.com, quic_skananth@quicinc.com,
quic_ramkri@quicinc.com, manivannan.sadhasivam@linaro.org,
swboyd@chromium.org, dmitry.baryshkov@linaro.org,
svarbanov@mm-sol.com, agross@kernel.org, andersson@kernel.org,
konrad.dybcio@somainline.org, lpieralisi@kernel.org,
robh@kernel.org, kw@linux.com, bhelgaas@google.com,
linux-phy@lists.infradead.org, vkoul@kernel.org, kishon@ti.com,
mturquette@baylibre.com, linux-clk@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH v7 1/5] PCI: qcom: Add system suspend and resume support
Date: Tue, 20 Sep 2022 13:16:37 -0500 [thread overview]
Message-ID: <20220920181637.GA1121154@bhelgaas> (raw)
In-Reply-To: <1663669347-29308-2-git-send-email-quic_krichai@quicinc.com>
On Tue, Sep 20, 2022 at 03:52:23PM +0530, Krishna chaitanya chundru wrote:
> Add suspend and resume syscore ops.
>
> Few PCIe endpoints like NVMe and WLANs are always expecting the device
> to be in D0 state and the link to be active (or in l1ss) all the time
> (including in S3 state).
What does this have to do with the patch? I don't see any NVMe or
WLAN patches here.
> In qcom platform PCIe resources( clocks, phy etc..) can released
> when the link is in L1ss to reduce the power consumption. So if the link
> is in L1ss, release the PCIe resources. And when the system resumes,
> enable the PCIe resources if they released in the suspend path.
What's the connection with L1.x? Links enter L1.x based on activity
and timing. That doesn't seem like a reliable indicator to turn PHYs
off and disable clocks.
> is_suspended flag indicates if the PCIe resources are released or not
> in the suspend path.
Why is "is_suspended" important for the commit log? It looks like
just a standard implementation detail.
> Its observed that access to Ep PCIe space to mask MSI/MSIX is happening
> at the very late stage of suspend path (access by affinity changes while
> making CPUs offline during suspend, this will happen after devices are
> suspended (after all phases of suspend ops)). If we turn off clocks in
> any PM callback, afterwards running into crashes due to un-clocked access
> due to above mentioned MSI/MSIx access.
> So, we are making use of syscore framework to turn off the PCIe clocks
> which will be called after making CPUs offline.
Add blank lines between paragraphs. Or rewrap into a single paragraph.
s/Its observed/It's observed/
s/MSIX/MSI-X/ throughout
s/MSIx/MSI-X/ throughout
Bjorn
next prev parent reply other threads:[~2022-09-20 18:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 10:22 [PATCH v7 0/5] PCI: qcom: Add system suspend & resume support Krishna chaitanya chundru
2022-09-20 10:22 ` [PATCH v7 1/5] PCI: qcom: Add system suspend and " Krishna chaitanya chundru
2022-09-20 18:16 ` Bjorn Helgaas [this message]
2022-09-21 9:53 ` Krishna Chaitanya Chundru
2022-09-21 16:56 ` Bjorn Helgaas
2022-09-22 15:39 ` Krishna Chaitanya Chundru
2022-09-22 18:42 ` Bjorn Helgaas
2022-09-23 1:59 ` Krishna Chaitanya Chundru
2022-09-23 14:26 ` Bjorn Helgaas
2022-09-25 1:53 ` Krishna Chaitanya Chundru
2022-09-28 14:32 ` Krishna Chaitanya Chundru
2022-09-26 15:30 ` Krishna Chaitanya Chundru
2022-09-29 18:53 ` Bjorn Helgaas
2022-10-03 12:10 ` Krishna Chaitanya Chundru
2022-10-05 21:13 ` Bjorn Helgaas
2022-10-12 14:06 ` Krishna Chaitanya Chundru
2022-10-13 0:44 ` Bjorn Helgaas
2022-09-20 21:58 ` Jeff Johnson
2022-09-20 10:22 ` [PATCH v7 2/5] PCI: qcom: Add retry logic for link to be stable in either L1.1 or L1.2 Krishna chaitanya chundru
2022-09-20 22:00 ` Jeff Johnson
2022-09-24 6:05 ` Vinod Koul
2022-09-25 1:51 ` Krishna Chaitanya Chundru
2022-09-20 10:22 ` [PATCH v7 3/5] phy: core: Add support for phy suspend & resume Krishna chaitanya chundru
2022-09-20 10:22 ` [PATCH v7 4/5] phy: qcom: Add power suspend & resume callbacks to PCIe phy Krishna chaitanya chundru
2022-09-20 10:22 ` [PATCH v7 5/5] clk: qcom: gcc-sc7280: Update the .pwrsts for PCIe GDSC Krishna chaitanya chundru
2022-09-27 3:23 ` (subset) [PATCH v7 0/5] PCI: qcom: Add system suspend & resume support Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920181637.GA1121154@bhelgaas \
--to=helgaas@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@ti.com \
--cc=konrad.dybcio@somainline.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mka@chromium.org \
--cc=mturquette@baylibre.com \
--cc=quic_hemantk@quicinc.com \
--cc=quic_krichai@quicinc.com \
--cc=quic_nitegupt@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_skananth@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh@kernel.org \
--cc=svarbanov@mm-sol.com \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).