* [PATCH] usb: dwc3: st: Fix node's child name
@ 2022-09-26 12:43 patrice.chotard
2022-09-26 13:52 ` Krzysztof Kozlowski
2022-09-27 15:15 ` Felipe Balbi
0 siblings, 2 replies; 4+ messages in thread
From: patrice.chotard @ 2022-09-26 12:43 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, Krzysztof Kozlowski,
Serge Semin, linux-arm-kernel, linux-usb, linux-kernel
Cc: patrice.chotard, Jerome Audu
From: Patrice Chotard <patrice.chotard@foss.st.com>
Update node's child name from "dwc3" to "usb", this fixes
the following issue:
[3.773852] usb-st-dwc3 8f94000.dwc3: failed to find dwc3 core node
Fixes: 3120910a099b ("ARM: dts: stih407-family: Harmonize DWC USB3 DT nodes name")
Reported-by: Jerome Audu <jerome.audu@st.com>
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
drivers/usb/dwc3/dwc3-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
index 166b5bde45cb..6c14a79279f9 100644
--- a/drivers/usb/dwc3/dwc3-st.c
+++ b/drivers/usb/dwc3/dwc3-st.c
@@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
/* Manage SoftReset */
reset_control_deassert(dwc3_data->rstc_rst);
- child = of_get_child_by_name(node, "dwc3");
+ child = of_get_child_by_name(node, "usb");
if (!child) {
dev_err(&pdev->dev, "failed to find dwc3 core node\n");
ret = -ENODEV;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: dwc3: st: Fix node's child name
2022-09-26 12:43 [PATCH] usb: dwc3: st: Fix node's child name patrice.chotard
@ 2022-09-26 13:52 ` Krzysztof Kozlowski
2022-09-27 15:15 ` Felipe Balbi
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 13:52 UTC (permalink / raw)
To: patrice.chotard, Felipe Balbi, Greg Kroah-Hartman, Serge Semin,
linux-arm-kernel, linux-usb, linux-kernel
Cc: Jerome Audu
On 26/09/2022 14:43, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
>
> Update node's child name from "dwc3" to "usb", this fixes
> the following issue:
>
> [3.773852] usb-st-dwc3 8f94000.dwc3: failed to find dwc3 core node
>
> Fixes: 3120910a099b ("ARM: dts: stih407-family: Harmonize DWC USB3 DT nodes name")
>
> Reported-by: Jerome Audu <jerome.audu@st.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
> drivers/usb/dwc3/dwc3-st.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
> index 166b5bde45cb..6c14a79279f9 100644
> --- a/drivers/usb/dwc3/dwc3-st.c
> +++ b/drivers/usb/dwc3/dwc3-st.c
> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
> /* Manage SoftReset */
> reset_control_deassert(dwc3_data->rstc_rst);
>
> - child = of_get_child_by_name(node, "dwc3");
> + child = of_get_child_by_name(node, "usb");
While this is a ok, the proper fix is not to rely on any other device
nodes or document it in the bindings.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: dwc3: st: Fix node's child name
2022-09-26 12:43 [PATCH] usb: dwc3: st: Fix node's child name patrice.chotard
2022-09-26 13:52 ` Krzysztof Kozlowski
@ 2022-09-27 15:15 ` Felipe Balbi
2022-09-28 6:45 ` Patrice CHOTARD
1 sibling, 1 reply; 4+ messages in thread
From: Felipe Balbi @ 2022-09-27 15:15 UTC (permalink / raw)
To: patrice.chotard
Cc: Greg Kroah-Hartman, Krzysztof Kozlowski, Serge Semin,
linux-arm-kernel, linux-usb, linux-kernel, Jerome Audu
<patrice.chotard@foss.st.com> writes:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
>
> Update node's child name from "dwc3" to "usb", this fixes
> the following issue:
>
> [3.773852] usb-st-dwc3 8f94000.dwc3: failed to find dwc3 core node
>
> Fixes: 3120910a099b ("ARM: dts: stih407-family: Harmonize DWC USB3 DT nodes name")
>
> Reported-by: Jerome Audu <jerome.audu@st.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
> drivers/usb/dwc3/dwc3-st.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
> index 166b5bde45cb..6c14a79279f9 100644
> --- a/drivers/usb/dwc3/dwc3-st.c
> +++ b/drivers/usb/dwc3/dwc3-st.c
> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
> /* Manage SoftReset */
> reset_control_deassert(dwc3_data->rstc_rst);
>
> - child = of_get_child_by_name(node, "dwc3");
> + child = of_get_child_by_name(node, "usb");
there could be DTBs in the wild which have `dwc3' as the child name. It
seems to me that you should try both names, instead.
--
balbi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: dwc3: st: Fix node's child name
2022-09-27 15:15 ` Felipe Balbi
@ 2022-09-28 6:45 ` Patrice CHOTARD
0 siblings, 0 replies; 4+ messages in thread
From: Patrice CHOTARD @ 2022-09-28 6:45 UTC (permalink / raw)
To: Felipe Balbi, Krzysztof Kozlowski
Cc: Greg Kroah-Hartman, Krzysztof Kozlowski, Serge Semin,
linux-arm-kernel, linux-usb, linux-kernel, Jerome Audu
Hi Felipe, Krzysztof
On 9/27/22 17:15, Felipe Balbi wrote:
>
> <patrice.chotard@foss.st.com> writes:
>
>> From: Patrice Chotard <patrice.chotard@foss.st.com>
>>
>> Update node's child name from "dwc3" to "usb", this fixes
>> the following issue:
>>
>> [3.773852] usb-st-dwc3 8f94000.dwc3: failed to find dwc3 core node
>>
>> Fixes: 3120910a099b ("ARM: dts: stih407-family: Harmonize DWC USB3 DT nodes name")
>>
>> Reported-by: Jerome Audu <jerome.audu@st.com>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> ---
>> drivers/usb/dwc3/dwc3-st.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
>> index 166b5bde45cb..6c14a79279f9 100644
>> --- a/drivers/usb/dwc3/dwc3-st.c
>> +++ b/drivers/usb/dwc3/dwc3-st.c
>> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
>> /* Manage SoftReset */
>> reset_control_deassert(dwc3_data->rstc_rst);
>>
>> - child = of_get_child_by_name(node, "dwc3");
>> + child = of_get_child_by_name(node, "usb");
>
> there could be DTBs in the wild which have `dwc3' as the child name. It
> seems to me that you should try both names, instead.
>
As this patch is already merged, i will submit an additional patch which will
rely on child's compatible string instead of child's node name, as done in other
dwc3 driver.
Thanks
Patrice
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-28 6:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 12:43 [PATCH] usb: dwc3: st: Fix node's child name patrice.chotard
2022-09-26 13:52 ` Krzysztof Kozlowski
2022-09-27 15:15 ` Felipe Balbi
2022-09-28 6:45 ` Patrice CHOTARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).