From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>, Jiri Olsa <jolsa@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Leo Yan <leo.yan@linaro.org>,
Zhengjun Xing <zhengjun.xing@linux.intel.com>
Subject: [PATCH 2/6] perf stat: Don't call perf_stat_evsel_id_init() repeatedly
Date: Mon, 26 Sep 2022 13:07:53 -0700 [thread overview]
Message-ID: <20220926200757.1161448-3-namhyung@kernel.org> (raw)
In-Reply-To: <20220926200757.1161448-1-namhyung@kernel.org>
The evsel__reset_stat_priv() is called more than once if user gave -r
option for multiple run. But it doesn't need to re-initialize the id.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/stat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
index 6bcd3dc32a71..e1d3152ce664 100644
--- a/tools/perf/util/stat.c
+++ b/tools/perf/util/stat.c
@@ -135,7 +135,6 @@ static void evsel__reset_stat_priv(struct evsel *evsel)
struct perf_stat_evsel *ps = evsel->stats;
init_stats(&ps->res_stats);
- perf_stat_evsel_id_init(evsel);
}
static int evsel__alloc_stat_priv(struct evsel *evsel)
@@ -143,6 +142,7 @@ static int evsel__alloc_stat_priv(struct evsel *evsel)
evsel->stats = zalloc(sizeof(struct perf_stat_evsel));
if (evsel->stats == NULL)
return -ENOMEM;
+ perf_stat_evsel_id_init(evsel);
evsel__reset_stat_priv(evsel);
return 0;
}
--
2.37.3.998.g577e59143f-goog
next prev parent reply other threads:[~2022-09-26 20:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 20:07 [PATCHSET 0/6] perf stat: Small random cleanups (v1) Namhyung Kim
2022-09-26 20:07 ` [PATCH 1/6] perf stat: Convert perf_stat_evsel.res_stats array Namhyung Kim
2022-09-28 10:33 ` James Clark
2022-09-26 20:07 ` Namhyung Kim [this message]
2022-09-28 10:41 ` [PATCH 2/6] perf stat: Don't call perf_stat_evsel_id_init() repeatedly James Clark
2022-09-26 20:07 ` [PATCH 3/6] perf stat: Rename saved_value->cpu_map_idx Namhyung Kim
2022-09-28 10:50 ` James Clark
2022-09-28 23:56 ` Namhyung Kim
2022-09-29 1:58 ` Ian Rogers
2022-09-26 20:07 ` [PATCH 4/6] perf stat: Use thread map index for shadow stat Namhyung Kim
2022-09-28 14:49 ` James Clark
2022-09-29 2:10 ` Ian Rogers
2022-09-29 4:55 ` Namhyung Kim
2022-09-26 20:07 ` [PATCH 5/6] perf stat: Kill unused per-thread runtime stats Namhyung Kim
2022-09-28 14:51 ` James Clark
2022-09-26 20:07 ` [PATCH 6/6] perf stat: Don't compare runtime stat for shadow stats Namhyung Kim
2022-09-28 14:52 ` James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220926200757.1161448-3-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).