From: James Clark <james.clark@arm.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Leo Yan <leo.yan@linaro.org>,
Zhengjun Xing <zhengjun.xing@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH 6/6] perf stat: Don't compare runtime stat for shadow stats
Date: Wed, 28 Sep 2022 15:52:15 +0100 [thread overview]
Message-ID: <ee88c7fa-67fa-1d96-1067-f0d87b96e653@arm.com> (raw)
In-Reply-To: <20220926200757.1161448-7-namhyung@kernel.org>
On 26/09/2022 21:07, Namhyung Kim wrote:
> Now it always uses the global rt_stat. Let's get rid of the field from
> the saved_value. When the both evsels are NULL, it'd return 0 so remove
> the block in the saved_value_cmp.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/util/stat-shadow.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
Reviewed-by: James Clark <james.clark@arm.com>
> diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
> index 99d05262055c..700563306637 100644
> --- a/tools/perf/util/stat-shadow.c
> +++ b/tools/perf/util/stat-shadow.c
> @@ -35,7 +35,6 @@ struct saved_value {
> int ctx;
> int map_idx;
> struct cgroup *cgrp;
> - struct runtime_stat *stat;
> struct stats stats;
> u64 metric_total;
> int metric_other;
> @@ -67,16 +66,6 @@ static int saved_value_cmp(struct rb_node *rb_node, const void *entry)
> if (a->cgrp != b->cgrp)
> return (char *)a->cgrp < (char *)b->cgrp ? -1 : +1;
>
> - if (a->evsel == NULL && b->evsel == NULL) {
> - if (a->stat == b->stat)
> - return 0;
> -
> - if ((char *)a->stat < (char *)b->stat)
> - return -1;
> -
> - return 1;
> - }
> -
> if (a->evsel == b->evsel)
> return 0;
> if ((char *)a->evsel < (char *)b->evsel)
> @@ -120,7 +109,6 @@ static struct saved_value *saved_value_lookup(struct evsel *evsel,
> .evsel = evsel,
> .type = type,
> .ctx = ctx,
> - .stat = st,
> .cgrp = cgrp,
> };
>
prev parent reply other threads:[~2022-09-28 14:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 20:07 [PATCHSET 0/6] perf stat: Small random cleanups (v1) Namhyung Kim
2022-09-26 20:07 ` [PATCH 1/6] perf stat: Convert perf_stat_evsel.res_stats array Namhyung Kim
2022-09-28 10:33 ` James Clark
2022-09-26 20:07 ` [PATCH 2/6] perf stat: Don't call perf_stat_evsel_id_init() repeatedly Namhyung Kim
2022-09-28 10:41 ` James Clark
2022-09-26 20:07 ` [PATCH 3/6] perf stat: Rename saved_value->cpu_map_idx Namhyung Kim
2022-09-28 10:50 ` James Clark
2022-09-28 23:56 ` Namhyung Kim
2022-09-29 1:58 ` Ian Rogers
2022-09-26 20:07 ` [PATCH 4/6] perf stat: Use thread map index for shadow stat Namhyung Kim
2022-09-28 14:49 ` James Clark
2022-09-29 2:10 ` Ian Rogers
2022-09-29 4:55 ` Namhyung Kim
2022-09-26 20:07 ` [PATCH 5/6] perf stat: Kill unused per-thread runtime stats Namhyung Kim
2022-09-28 14:51 ` James Clark
2022-09-26 20:07 ` [PATCH 6/6] perf stat: Don't compare runtime stat for shadow stats Namhyung Kim
2022-09-28 14:52 ` James Clark [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee88c7fa-67fa-1d96-1067-f0d87b96e653@arm.com \
--to=james.clark@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).