[PATCH -next] net: i82596: Add __init/__exit annotations to module init/exit funcs

[PATCH -next] net: i82596: Add __init/__exit annotations to module init/exit funcs

[ruanjinjie]

Add missing __init/__exit annotations to module init/exit funcs

Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
---
 drivers/net/ethernet/i825xx/sni_82596.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/i825xx/sni_82596.c b/drivers/net/ethernet/i825xx/sni_82596.c
index daec9ce04531..e6c6f28b1818 100644
--- a/drivers/net/ethernet/i825xx/sni_82596.c
+++ b/drivers/net/ethernet/i825xx/sni_82596.c
@@ -173,7 +173,7 @@ static struct platform_driver sni_82596_driver = {
 	},
 };
 
-static int sni_82596_init(void)
+static int __init sni_82596_init(void)
 {
 	printk(KERN_INFO SNI_82596_DRIVER_VERSION "\n");
 	return platform_driver_register(&sni_82596_driver);
-- 
2.25.1

Re: [PATCH -next] net: i82596: Add __init/__exit annotations to module init/exit funcs

[Jakub Kicinski]

On Mon, 26 Sep 2022 19:54:56 +0800 ruanjinjie wrote:
> Add missing __init/__exit annotations to module init/exit funcs

How many of these do you have? Do you use a tool to find the cases 
where the annotations can be used?

Please read Documentation/process/researcher-guidelines.rst
and make sure you comply with what is expected in the commit message.

Re: [PATCH -next] net: i82596: Add __init/__exit annotations to module init/exit funcs

[Ruan Jinjie]

On 2022/9/27 22:52, Jakub Kicinski wrote:
> On Mon, 26 Sep 2022 19:54:56 +0800 ruanjinjie wrote:
>> Add missing __init/__exit annotations to module init/exit funcs
> 
> How many of these do you have? Do you use a tool to find the cases 
> where the annotations can be used?
> 
I think Linux kernel drivers have many of these problems.I use grep
command to compare all the driver C files and find where the annotations
can be used.

> Please read Documentation/process/researcher-guidelines.rst
> and make sure you comply with what is expected in the commit message.

Thank you very much! Some key information is missing from the commit
message. Should I update the commit message and resubmit the patch?

Re: [PATCH -next] net: i82596: Add __init/__exit annotations to module init/exit funcs

[Jakub Kicinski]

On Wed, 28 Sep 2022 11:13:24 +0800 Ruan Jinjie wrote:
> On 2022/9/27 22:52, Jakub Kicinski wrote:
> > On Mon, 26 Sep 2022 19:54:56 +0800 ruanjinjie wrote:  
> >> Add missing __init/__exit annotations to module init/exit funcs  
> > 
> > How many of these do you have? Do you use a tool to find the cases 
> > where the annotations can be used?
> >   
> I think Linux kernel drivers have many of these problems.I use grep
> command to compare all the driver C files and find where the annotations
> can be used.
> 
> > Please read Documentation/process/researcher-guidelines.rst
> > and make sure you comply with what is expected in the commit message.  
> 
> Thank you very much! Some key information is missing from the commit
> message. Should I update the commit message and resubmit the patch?

TBH I don't think this is worth fixing. The functions which will be
discarded are tiny.