* [PATCH v4 0/2] Add LTE SKU for sc7280-evoker family @ 2022-09-27 11:23 Sheng-Liang Pan 2022-09-27 11:23 ` [PATCH v4 1/2] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker Sheng-Liang Pan 2022-09-27 11:23 ` [PATCH v4 2/2] arm64: dts: qcom: Add LTE SKU for sc7280-evoker family Sheng-Liang Pan 0 siblings, 2 replies; 7+ messages in thread From: Sheng-Liang Pan @ 2022-09-27 11:23 UTC (permalink / raw) To: LKML Cc: dianders, Sheng-Liang Pan, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm This patch add common dtsi and WIFI/LTE dts for evoker. Changes in v4: - fix typo in tittle and commit - remove change for trackpad and touchscreen - remove change for trackpad and touchscreen Changes in v3: - none Changes in v2: - none Sheng-Liang Pan (2): dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker arm64: dts: qcom: Add LTE SKU for sc7280-evoker family Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++ arch/arm64/boot/dts/qcom/Makefile | 3 ++- .../boot/dts/qcom/sc7280-herobrine-evoker-lte.dts | 14 ++++++++++++++ .../boot/dts/qcom/sc7280-herobrine-evoker.dts | 15 +++++++++++++++ ...evoker-r0.dts => sc7280-herobrine-evoker.dtsi} | 8 -------- 5 files changed, 36 insertions(+), 9 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts rename arch/arm64/boot/dts/qcom/{sc7280-herobrine-evoker-r0.dts => sc7280-herobrine-evoker.dtsi} (98%) -- 2.34.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v4 1/2] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker 2022-09-27 11:23 [PATCH v4 0/2] Add LTE SKU for sc7280-evoker family Sheng-Liang Pan @ 2022-09-27 11:23 ` Sheng-Liang Pan 2022-09-28 8:30 ` Krzysztof Kozlowski 2022-09-28 21:03 ` Doug Anderson 2022-09-27 11:23 ` [PATCH v4 2/2] arm64: dts: qcom: Add LTE SKU for sc7280-evoker family Sheng-Liang Pan 1 sibling, 2 replies; 7+ messages in thread From: Sheng-Liang Pan @ 2022-09-27 11:23 UTC (permalink / raw) To: LKML Cc: dianders, Sheng-Liang Pan, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm evoker will have WIFI/LTE SKU, separate it for each different setting. Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> --- Changes in v4: - fix typo in tittle and commit Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index b6257683a700c..065d9cc4421e0 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -575,6 +575,11 @@ properties: - const: google,evoker - const: qcom,sc7280 + - description: Google Evoker with LTE (newest rev) + items: + - const: google,evoker-sku512 + - const: qcom,sc7280 + - description: Google Herobrine (newest rev) items: - const: google,herobrine -- 2.34.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker 2022-09-27 11:23 ` [PATCH v4 1/2] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker Sheng-Liang Pan @ 2022-09-28 8:30 ` Krzysztof Kozlowski 2022-09-28 21:03 ` Doug Anderson 1 sibling, 0 replies; 7+ messages in thread From: Krzysztof Kozlowski @ 2022-09-28 8:30 UTC (permalink / raw) To: Sheng-Liang Pan, LKML Cc: dianders, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm On 27/09/2022 13:23, Sheng-Liang Pan wrote: > evoker will have WIFI/LTE SKU, separate it for each different setting. > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker 2022-09-27 11:23 ` [PATCH v4 1/2] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker Sheng-Liang Pan 2022-09-28 8:30 ` Krzysztof Kozlowski @ 2022-09-28 21:03 ` Doug Anderson 1 sibling, 0 replies; 7+ messages in thread From: Doug Anderson @ 2022-09-28 21:03 UTC (permalink / raw) To: Sheng-Liang Pan Cc: LKML, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-arm-msm Hi, On Tue, Sep 27, 2022 at 4:25 AM Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> wrote: > > evoker will have WIFI/LTE SKU, separate it for each different setting. > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> > --- > > Changes in v4: > - fix typo in tittle and commit > > Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++ > 1 file changed, 5 insertions(+) Reviewed-by: Douglas Anderson <dianders@chromium.org> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v4 2/2] arm64: dts: qcom: Add LTE SKU for sc7280-evoker family 2022-09-27 11:23 [PATCH v4 0/2] Add LTE SKU for sc7280-evoker family Sheng-Liang Pan 2022-09-27 11:23 ` [PATCH v4 1/2] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker Sheng-Liang Pan @ 2022-09-27 11:23 ` Sheng-Liang Pan 2022-09-28 21:04 ` Doug Anderson 1 sibling, 1 reply; 7+ messages in thread From: Sheng-Liang Pan @ 2022-09-27 11:23 UTC (permalink / raw) To: LKML Cc: dianders, Sheng-Liang Pan, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm evoker have wifi/lte sku, add different dts for each sku. Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> --- Changes in v4: - remove change for trackpad and touchscreen arch/arm64/boot/dts/qcom/Makefile | 3 ++- .../boot/dts/qcom/sc7280-herobrine-evoker-lte.dts | 14 ++++++++++++++ .../boot/dts/qcom/sc7280-herobrine-evoker.dts | 15 +++++++++++++++ ...evoker-r0.dts => sc7280-herobrine-evoker.dtsi} | 8 -------- 4 files changed, 31 insertions(+), 9 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts rename arch/arm64/boot/dts/qcom/{sc7280-herobrine-evoker-r0.dts => sc7280-herobrine-evoker.dtsi} (98%) diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index d7669a7cee9f7..76390301a76c0 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -104,7 +104,8 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1-lte.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-crd.dtb -dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-evoker-r0.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-evoker.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-evoker-lte.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-herobrine-r1.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r0.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r1.dtb diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts new file mode 100644 index 0000000000000..3af9224a7492e --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts @@ -0,0 +1,14 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Google Evoker board device tree source + * + * Copyright 2022 Google LLC. + */ + +#include "sc7280-herobrine-evoker.dts" +#include "sc7280-herobrine-lte-sku.dtsi" + +/ { + model = "Google Evoker with LTE"; + compatible = "google,evoker-sku512", "qcom,sc7280"; +}; diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts new file mode 100644 index 0000000000000..dcdd4eecfe670 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts @@ -0,0 +1,15 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Google Evoker board device tree source + * + * Copyright 2022 Google LLC. + */ + +/dts-v1/; + +#include "sc7280-herobrine-evoker.dtsi" + +/ { + model = "Google Evoker"; + compatible = "google,evoker", "qcom,sc7280"; +}; diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi similarity index 98% rename from arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts rename to arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi index ccbe50b6249ab..1b2ec95a289e9 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi @@ -5,15 +5,8 @@ * Copyright 2022 Google LLC. */ -/dts-v1/; - #include "sc7280-herobrine.dtsi" -/ { - model = "Google Evoker"; - compatible = "google,evoker", "qcom,sc7280"; -}; - /* * ADDITIONS TO FIXED REGULATORS DEFINED IN PARENT DEVICE TREE FILES * @@ -60,7 +53,6 @@ ap_ts: touchscreen@10 { interrupts = <55 IRQ_TYPE_LEVEL_LOW>; reset-gpios = <&tlmm 54 GPIO_ACTIVE_LOW>; - vcc33-supply = <&ts_avdd>; }; }; -- 2.34.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v4 2/2] arm64: dts: qcom: Add LTE SKU for sc7280-evoker family 2022-09-27 11:23 ` [PATCH v4 2/2] arm64: dts: qcom: Add LTE SKU for sc7280-evoker family Sheng-Liang Pan @ 2022-09-28 21:04 ` Doug Anderson 2022-09-28 21:07 ` Doug Anderson 0 siblings, 1 reply; 7+ messages in thread From: Doug Anderson @ 2022-09-28 21:04 UTC (permalink / raw) To: Sheng-Liang Pan Cc: LKML, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-arm-msm Hi, On Tue, Sep 27, 2022 at 4:25 AM Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> wrote: > > evoker have wifi/lte sku, add different dts for each sku. > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> > --- > > Changes in v4: > - remove change for trackpad and touchscreen > > arch/arm64/boot/dts/qcom/Makefile | 3 ++- > .../boot/dts/qcom/sc7280-herobrine-evoker-lte.dts | 14 ++++++++++++++ > .../boot/dts/qcom/sc7280-herobrine-evoker.dts | 15 +++++++++++++++ > ...evoker-r0.dts => sc7280-herobrine-evoker.dtsi} | 8 -------- > 4 files changed, 31 insertions(+), 9 deletions(-) > create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts > create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts > rename arch/arm64/boot/dts/qcom/{sc7280-herobrine-evoker-r0.dts => sc7280-herobrine-evoker.dtsi} (98%) > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index d7669a7cee9f7..76390301a76c0 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -104,7 +104,8 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1-lte.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-crd.dtb > -dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-evoker-r0.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-evoker.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-evoker-lte.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-herobrine-r1.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r0.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r1.dtb > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts > new file mode 100644 > index 0000000000000..3af9224a7492e > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts > @@ -0,0 +1,14 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Google Evoker board device tree source > + * > + * Copyright 2022 Google LLC. > + */ > + > +#include "sc7280-herobrine-evoker.dts" > +#include "sc7280-herobrine-lte-sku.dtsi" > + > +/ { > + model = "Google Evoker with LTE"; > + compatible = "google,evoker-sku512", "qcom,sc7280"; > +}; > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts > new file mode 100644 > index 0000000000000..dcdd4eecfe670 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts > @@ -0,0 +1,15 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Google Evoker board device tree source > + * > + * Copyright 2022 Google LLC. > + */ > + > +/dts-v1/; > + > +#include "sc7280-herobrine-evoker.dtsi" > + > +/ { > + model = "Google Evoker"; > + compatible = "google,evoker", "qcom,sc7280"; > +}; > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi > similarity index 98% > rename from arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts > rename to arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi > index ccbe50b6249ab..1b2ec95a289e9 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi > @@ -5,15 +5,8 @@ > * Copyright 2022 Google LLC. > */ > > -/dts-v1/; > - > #include "sc7280-herobrine.dtsi" > > -/ { > - model = "Google Evoker"; > - compatible = "google,evoker", "qcom,sc7280"; > -}; > - > /* > * ADDITIONS TO FIXED REGULATORS DEFINED IN PARENT DEVICE TREE FILES > * > @@ -60,7 +53,6 @@ ap_ts: touchscreen@10 { > interrupts = <55 IRQ_TYPE_LEVEL_LOW>; > > reset-gpios = <&tlmm 54 GPIO_ACTIVE_LOW>; > - > vcc33-supply = <&ts_avdd>; The above is an unrelated whitespace change and doesn't belong in this patch. Ideally you'd send a v5 where you didn't have that. In any case, it's not a huge deal to me, so with or without that fix: Reviewed-by: Douglas Anderson <dianders@chromium.org> If you do decide to send a v5, please make sure you carry my and Krzysztof's Reviewed-by tags on the bindings and my Reviewed-by tag on this patch. Thanks! ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4 2/2] arm64: dts: qcom: Add LTE SKU for sc7280-evoker family 2022-09-28 21:04 ` Doug Anderson @ 2022-09-28 21:07 ` Doug Anderson 0 siblings, 0 replies; 7+ messages in thread From: Doug Anderson @ 2022-09-28 21:07 UTC (permalink / raw) To: Sheng-Liang Pan, Bjorn Andersson Cc: LKML, Andy Gross, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-arm-msm Hi, On Wed, Sep 28, 2022 at 2:04 PM Doug Anderson <dianders@chromium.org> wrote: > > The above is an unrelated whitespace change and doesn't belong in this > patch. Ideally you'd send a v5 where you didn't have that. Actually you probably want to send a v5 anyway with Bjorn's proper email address. The fact that you have his old linaro address instead of his kernel.org address means you were probably need to update your git tree. Try something like: git remote add linux_qcom git://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git git fetch linux_qcom git checkout -b my_patch_series linux_qcom/for-next # then make your changes and post them up -Doug ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-09-28 21:15 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-09-27 11:23 [PATCH v4 0/2] Add LTE SKU for sc7280-evoker family Sheng-Liang Pan 2022-09-27 11:23 ` [PATCH v4 1/2] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker Sheng-Liang Pan 2022-09-28 8:30 ` Krzysztof Kozlowski 2022-09-28 21:03 ` Doug Anderson 2022-09-27 11:23 ` [PATCH v4 2/2] arm64: dts: qcom: Add LTE SKU for sc7280-evoker family Sheng-Liang Pan 2022-09-28 21:04 ` Doug Anderson 2022-09-28 21:07 ` Doug Anderson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).