From: Jakub Kicinski <kuba@kernel.org>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: tchornyi@marvell.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: prestera: acl: Add check for kmemdup
Date: Thu, 29 Sep 2022 09:15:27 -0700 [thread overview]
Message-ID: <20220929091527.370b39a4@kernel.org> (raw)
In-Reply-To: <20220928092024.6996-1-jiasheng@iscas.ac.cn>
On Wed, 28 Sep 2022 17:20:24 +0800 Jiasheng Jiang wrote:
> As the kemdup could return NULL, it should be better to check the return
> value and return error if fails.
> Moreover, the return value of prestera_acl_ruleset_keymask_set() should
> be checked by cascade.
>
> Fixes: 604ba230902d ("net: prestera: flower template support")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
You must CC the authors of patch you're fixing.
get_maintainer will do that for you I don't understand why people can't
simply run that script :/ You CC linux-kernel for no apparent reason
yet you don't CC the guy who wrote the original patch.
If you could please explain what is going on maybe we can improve the
tooling or something.
next prev parent reply other threads:[~2022-09-29 16:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 9:20 [PATCH] net: prestera: acl: Add check for kmemdup Jiasheng Jiang
2022-09-29 16:15 ` Jakub Kicinski [this message]
2022-09-30 4:48 Jiasheng Jiang
2022-09-30 9:20 ` Taras Chornyi
2022-10-03 11:40 ` patchwork-bot+netdevbpf
2022-09-30 5:03 Jiasheng Jiang
2022-09-30 14:29 ` Jakub Kicinski
2022-09-30 15:20 ` Joe Perches
2022-09-30 15:44 ` Jakub Kicinski
2022-09-30 16:43 ` Joe Perches
2022-09-30 16:58 ` Jakub Kicinski
2022-09-30 18:28 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929091527.370b39a4@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tchornyi@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).