From: Joe Perches <joe@perches.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
pabeni@redhat.com, davem@davemloft.net, tchornyi@marvell.com,
edumazet@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Volodymyr Mytnyk <vmytnyk@marvell.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] net: prestera: acl: Add check for kmemdup
Date: Fri, 30 Sep 2022 09:43:54 -0700 [thread overview]
Message-ID: <76e4463b9ea5946e7af045363d888b966ba5e209.camel@perches.com> (raw)
In-Reply-To: <20220930084431.508ce665@kernel.org>
On Fri, 2022-09-30 at 08:44 -0700, Jakub Kicinski wrote:
> On Fri, 30 Sep 2022 08:20:47 -0700 Joe Perches wrote:
> > IMO: If Volodymyr wants to be a maintainer here, he should put
> > his email as an entry in the MAINTAINERS file for the subsystem.
>
> It's about Fixes tags, unfortunately having everyone of note listed
> in MAINTAINERS is pretty much impossible. Even tho we are trying.
>
> > > > Maybe there is a problem of the script that misses one.
> >
> > I don't think so. Maybe you have more evidence...
>
> I'll CC you when I tell people to CC authors of patches under Fixes
> going forward, I don't have a list going back.
>
> > > > Anyway, I have already submitted the same patch and added
> > > > "vmytnyk@marvell.com" this time.
> > >
> > > Ha! So you do indeed use it in a way I wasn't expecting :S
> > > Thanks for the explanation.
> > >
> > > Joe, would you be okay to add a "big fat warning" to get_maintainer
> > > when people try to use the -f flag?
> >
> > No, not really. -f isn't required when the file is in git anyway.
>
> Ah. Yeah. I'd make it error out when run on a source file without -f :S
>
> > > Maybe we can also change the message
> > > that's displayed when the script is run without arguments to not
> > > mention -f?
> >
> > I think that's a poor idea as frequently the script isn't used
> > on patches but simply to identify the maintainers of a particular
> > file or subsystem.
>
> Identify the maintainers and report a bug, or something else? As a
> maintainer I can tell you that I don't see bug reports as often as I
> see trivial patches from noobs which miss CCs. And I personally don't
> think I ever used get_maintainer on anything else than a patch.
>
> > > We're getting quite a few fixes which don't CC author, I'm guessing
> > > Jiasheng's approach may be a common one.
> >
> > There's no great way to identify "author" or "original submitter"
> > and frequently the "original submitter" isn't a maintainer anyway.
>
> Confusing sentence. We want for people who s-o-b'd the commit under
> Fixes to be CCed.
If a file or a file modified by a patch is listed in the MAINTAINERS,
git history isn't used unless --git is specified.
For a patch, maybe the author and other SOBs of a commit specified
by a "Fixes:" line SHA-1 in the commit message could be added automatically.
next prev parent reply other threads:[~2022-09-30 16:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 5:03 Re: [PATCH] net: prestera: acl: Add check for kmemdup Jiasheng Jiang
2022-09-30 14:29 ` Jakub Kicinski
2022-09-30 15:20 ` Joe Perches
2022-09-30 15:44 ` Jakub Kicinski
2022-09-30 16:43 ` Joe Perches [this message]
2022-09-30 16:58 ` Jakub Kicinski
2022-09-30 18:28 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2022-09-30 4:48 Jiasheng Jiang
2022-09-30 9:20 ` Taras Chornyi
2022-10-03 11:40 ` patchwork-bot+netdevbpf
2022-09-28 9:20 Jiasheng Jiang
2022-09-29 16:15 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76e4463b9ea5946e7af045363d888b966ba5e209.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiasheng@iscas.ac.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tchornyi@marvell.com \
--cc=vmytnyk@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).