linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] Fix dp-pwr property in dp-connector binding
@ 2022-09-30 13:28 Rahul T R
  2022-09-30 13:28 ` [PATCH 1/2] dt-bindings: dp-connector: Fix the property name for dp pwr Rahul T R
  2022-09-30 13:28 ` [PATCH 2/2] arm64: dts: ti: k3-j721e-*: " Rahul T R
  0 siblings, 2 replies; 5+ messages in thread
From: Rahul T R @ 2022-09-30 13:28 UTC (permalink / raw)
  To: airlied, daniel, robh+dt, krzysztof.kozlowski+dt, tomi.valkeinen,
	dri-devel, nm, vigneshr
  Cc: kristo, linux-arm-kernel, devicetree, linux-kernel, Rahul T R

Fix the miss match in the binding and driver implementation for
dp power supply regulator property. Also fix it in the dp-connector
node instances in dt files

Rahul T R (2):
  dt-bindings: dp-connector: Fix the property name for dp pwr
  arm64: dts: ti: k3-j721e-*: Fix the property name for dp pwr

 .../devicetree/bindings/display/connector/dp-connector.yaml     | 2 +-
 arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts           | 2 +-
 arch/arm64/boot/dts/ti/k3-j721e-sk.dts                          | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.37.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] dt-bindings: dp-connector: Fix the property name for dp pwr
  2022-09-30 13:28 [PATCH 0/2] Fix dp-pwr property in dp-connector binding Rahul T R
@ 2022-09-30 13:28 ` Rahul T R
  2022-09-30 14:14   ` Rob Herring
  2022-09-30 13:28 ` [PATCH 2/2] arm64: dts: ti: k3-j721e-*: " Rahul T R
  1 sibling, 1 reply; 5+ messages in thread
From: Rahul T R @ 2022-09-30 13:28 UTC (permalink / raw)
  To: airlied, daniel, robh+dt, krzysztof.kozlowski+dt, tomi.valkeinen,
	dri-devel, nm, vigneshr
  Cc: kristo, linux-arm-kernel, devicetree, linux-kernel, Rahul T R

Property name for DisplayPort regulator is not matching in
the binding and the driver implementation. Fix the same
in the binding

Signed-off-by: Rahul T R <r-ravikumar@ti.com>
Reported-by: Nishanth Menon <nm@ti.com>
---
 .../devicetree/bindings/display/connector/dp-connector.yaml     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/display/connector/dp-connector.yaml b/Documentation/devicetree/bindings/display/connector/dp-connector.yaml
index 22792a79e7ce..529d3f11ac16 100644
--- a/Documentation/devicetree/bindings/display/connector/dp-connector.yaml
+++ b/Documentation/devicetree/bindings/display/connector/dp-connector.yaml
@@ -24,7 +24,7 @@ properties:
     description: A GPIO line connected to HPD
     maxItems: 1
 
-  dp-pwr-supply:
+  dp-pwr:
     description: Power supply for the DP_PWR pin
 
   port:
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] arm64: dts: ti: k3-j721e-*: Fix the property name for dp pwr
  2022-09-30 13:28 [PATCH 0/2] Fix dp-pwr property in dp-connector binding Rahul T R
  2022-09-30 13:28 ` [PATCH 1/2] dt-bindings: dp-connector: Fix the property name for dp pwr Rahul T R
@ 2022-09-30 13:28 ` Rahul T R
  1 sibling, 0 replies; 5+ messages in thread
From: Rahul T R @ 2022-09-30 13:28 UTC (permalink / raw)
  To: airlied, daniel, robh+dt, krzysztof.kozlowski+dt, tomi.valkeinen,
	dri-devel, nm, vigneshr
  Cc: kristo, linux-arm-kernel, devicetree, linux-kernel, Rahul T R

Fix the property name of displayport pwr in dp connector
nodes

Signed-off-by: Rahul T R <r-ravikumar@ti.com>
Reported-by: Nishanth Menon <nm@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 2 +-
 arch/arm64/boot/dts/ti/k3-j721e-sk.dts                | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
index b1691ac3442d..4cccb6653217 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
@@ -162,7 +162,7 @@ dp0: connector {
 		compatible = "dp-connector";
 		label = "DP0";
 		type = "full-size";
-		dp-pwr-supply = <&dp_pwr_3v3>;
+		dp-pwr = <&dp_pwr_3v3>;
 
 		port {
 			dp_connector_in: endpoint {
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
index 80358cba6954..0e295c661aab 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
@@ -217,7 +217,7 @@ dp0: connector {
 		compatible = "dp-connector";
 		label = "DP0";
 		type = "full-size";
-		dp-pwr-supply = <&dp_pwr_3v3>;
+		dp-pwr = <&dp_pwr_3v3>;
 
 		port {
 			dp_connector_in: endpoint {
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dt-bindings: dp-connector: Fix the property name for dp pwr
  2022-09-30 13:28 ` [PATCH 1/2] dt-bindings: dp-connector: Fix the property name for dp pwr Rahul T R
@ 2022-09-30 14:14   ` Rob Herring
  2022-09-30 14:27     ` Rahul T R
  0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2022-09-30 14:14 UTC (permalink / raw)
  To: Rahul T R
  Cc: airlied, daniel, krzysztof.kozlowski+dt, tomi.valkeinen,
	dri-devel, nm, vigneshr, kristo, linux-arm-kernel, devicetree,
	linux-kernel

On Fri, Sep 30, 2022 at 8:29 AM Rahul T R <r-ravikumar@ti.com> wrote:
>
> Property name for DisplayPort regulator is not matching in
> the binding and the driver implementation. Fix the same
> in the binding
>
> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> Reported-by: Nishanth Menon <nm@ti.com>
> ---
>  .../devicetree/bindings/display/connector/dp-connector.yaml     | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

NAK. The binding is correct.

Are you confused that the regulator framework appends '-supply' for you?

Rob

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dt-bindings: dp-connector: Fix the property name for dp pwr
  2022-09-30 14:14   ` Rob Herring
@ 2022-09-30 14:27     ` Rahul T R
  0 siblings, 0 replies; 5+ messages in thread
From: Rahul T R @ 2022-09-30 14:27 UTC (permalink / raw)
  To: Rob Herring
  Cc: airlied, daniel, krzysztof.kozlowski+dt, tomi.valkeinen,
	dri-devel, nm, vigneshr, kristo, linux-arm-kernel, devicetree,
	linux-kernel

Hi Rob,

On 09:14-20220930, Rob Herring wrote:
> On Fri, Sep 30, 2022 at 8:29 AM Rahul T R <r-ravikumar@ti.com> wrote:
> >
> > Property name for DisplayPort regulator is not matching in
> > the binding and the driver implementation. Fix the same
> > in the binding
> >
> > Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> > Reported-by: Nishanth Menon <nm@ti.com>
> > ---
> >  .../devicetree/bindings/display/connector/dp-connector.yaml     | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> NAK. The binding is correct.
> 
> Are you confused that the regulator framework appends '-supply' for you?
> 
> Rob

Thanks for pointing this out
I was confused about the difference in the property name
now I get it
Please ignore this set

Regards
Rahul T R

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-09-30 14:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-30 13:28 [PATCH 0/2] Fix dp-pwr property in dp-connector binding Rahul T R
2022-09-30 13:28 ` [PATCH 1/2] dt-bindings: dp-connector: Fix the property name for dp pwr Rahul T R
2022-09-30 14:14   ` Rob Herring
2022-09-30 14:27     ` Rahul T R
2022-09-30 13:28 ` [PATCH 2/2] arm64: dts: ti: k3-j721e-*: " Rahul T R

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).