* [net-next] net: ethernet: adi: adin1110: Add check in netdev_event
@ 2022-10-03 11:16 Alexandru Tachici
2022-10-06 4:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Alexandru Tachici @ 2022-10-03 11:16 UTC (permalink / raw)
To: linux-kernel; +Cc: andrew, linux, davem, edumazet, kuba, pabeni, netdev
Check whether this driver actually is the intended recipient of
upper change event.
Fixes: bc93e19d088b ("net: ethernet: adi: Add ADIN1110 support")
Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
---
drivers/net/ethernet/adi/adin1110.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/adi/adin1110.c b/drivers/net/ethernet/adi/adin1110.c
index aaee7c4248e6..1744d623999d 100644
--- a/drivers/net/ethernet/adi/adin1110.c
+++ b/drivers/net/ethernet/adi/adin1110.c
@@ -1169,6 +1169,11 @@ static int adin1110_port_bridge_leave(struct adin1110_port_priv *port_priv,
return ret;
}
+static bool adin1110_port_dev_check(const struct net_device *dev)
+{
+ return dev->netdev_ops == &adin1110_netdev_ops;
+}
+
static int adin1110_netdevice_event(struct notifier_block *unused,
unsigned long event, void *ptr)
{
@@ -1177,6 +1182,9 @@ static int adin1110_netdevice_event(struct notifier_block *unused,
struct netdev_notifier_changeupper_info *info = ptr;
int ret = 0;
+ if (!adin1110_port_dev_check(dev))
+ return NOTIFY_DONE;
+
switch (event) {
case NETDEV_CHANGEUPPER:
if (netif_is_bridge_master(info->upper_dev)) {
@@ -1202,11 +1210,6 @@ static void adin1110_disconnect_phy(void *data)
phy_disconnect(data);
}
-static bool adin1110_port_dev_check(const struct net_device *dev)
-{
- return dev->netdev_ops == &adin1110_netdev_ops;
-}
-
static int adin1110_port_set_forwarding_state(struct adin1110_port_priv *port_priv)
{
struct adin1110_priv *priv = port_priv->priv;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net-next] net: ethernet: adi: adin1110: Add check in netdev_event
2022-10-03 11:16 [net-next] net: ethernet: adi: adin1110: Add check in netdev_event Alexandru Tachici
@ 2022-10-06 4:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-10-06 4:00 UTC (permalink / raw)
To: Alexandru Tachici
Cc: linux-kernel, andrew, linux, davem, edumazet, kuba, pabeni, netdev
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 3 Oct 2022 14:16:36 +0300 you wrote:
> Check whether this driver actually is the intended recipient of
> upper change event.
>
> Fixes: bc93e19d088b ("net: ethernet: adi: Add ADIN1110 support")
> Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
> ---
> drivers/net/ethernet/adi/adin1110.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
Here is the summary with links:
- [net-next] net: ethernet: adi: adin1110: Add check in netdev_event
https://git.kernel.org/netdev/net/c/f93719351b0e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-06 4:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-03 11:16 [net-next] net: ethernet: adi: adin1110: Add check in netdev_event Alexandru Tachici
2022-10-06 4:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).