* [PATCH] Documentation/mm/page_owner.rst: update experimental data
@ 2022-08-25 17:29 Yixuan Cao
2022-08-25 18:09 ` Jonathan Corbet
0 siblings, 1 reply; 11+ messages in thread
From: Yixuan Cao @ 2022-08-25 17:29 UTC (permalink / raw)
To: akpm
Cc: corbet, yejiajian2018, skhan, akiyks, rppt, zhangyinan2019,
linux-doc, linux-kernel, Yixuan Cao
I noticed some experimental data need to be updated.
Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
---
Documentation/mm/page_owner.rst | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/mm/page_owner.rst b/Documentation/mm/page_owner.rst
index f18fd8907049..8e2545bb4e17 100644
--- a/Documentation/mm/page_owner.rst
+++ b/Documentation/mm/page_owner.rst
@@ -41,17 +41,17 @@ size change due to this facility.
- Without page owner::
text data bss dec hex filename
- 48392 2333 644 51369 c8a9 mm/page_alloc.o
+ 58581 3166 652 62399 f3bf mm/page_alloc.o
- With page owner::
text data bss dec hex filename
- 48800 2445 644 51889 cab1 mm/page_alloc.o
- 6662 108 29 6799 1a8f mm/page_owner.o
- 1025 8 8 1041 411 mm/page_ext.o
+ 59085 3294 652 63031 f637 mm/page_alloc.o
+ 7464 125 28 7617 1dc1 mm/page_owner.o
+ 1396 32 8 1436 59c mm/page_ext.o
-Although, roughly, 8 KB code is added in total, page_alloc.o increase by
-520 bytes and less than half of it is in hotpath. Building the kernel with
+Although, roughly, 9 KB code is added in total, page_alloc.o increase by
+632 bytes and less than half of it is in hotpath. Building the kernel with
page owner and turning it on if needed would be great option to debug
kernel memory problem.
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] Documentation/mm/page_owner.rst: update experimental data
2022-08-25 17:29 [PATCH] Documentation/mm/page_owner.rst: update experimental data Yixuan Cao
@ 2022-08-25 18:09 ` Jonathan Corbet
2022-08-26 2:30 ` Bagas Sanjaya
0 siblings, 1 reply; 11+ messages in thread
From: Jonathan Corbet @ 2022-08-25 18:09 UTC (permalink / raw)
To: Yixuan Cao, akpm
Cc: yejiajian2018, skhan, akiyks, rppt, zhangyinan2019, linux-doc,
linux-kernel, Yixuan Cao
Yixuan Cao <caoyixuan2019@email.szu.edu.cn> writes:
> I noticed some experimental data need to be updated.
>
> Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
> ---
> Documentation/mm/page_owner.rst | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/mm/page_owner.rst b/Documentation/mm/page_owner.rst
> index f18fd8907049..8e2545bb4e17 100644
> --- a/Documentation/mm/page_owner.rst
> +++ b/Documentation/mm/page_owner.rst
> @@ -41,17 +41,17 @@ size change due to this facility.
> - Without page owner::
>
> text data bss dec hex filename
> - 48392 2333 644 51369 c8a9 mm/page_alloc.o
> + 58581 3166 652 62399 f3bf mm/page_alloc.o
>
> - With page owner::
>
> text data bss dec hex filename
> - 48800 2445 644 51889 cab1 mm/page_alloc.o
> - 6662 108 29 6799 1a8f mm/page_owner.o
> - 1025 8 8 1041 411 mm/page_ext.o
> + 59085 3294 652 63031 f637 mm/page_alloc.o
> + 7464 125 28 7617 1dc1 mm/page_owner.o
> + 1396 32 8 1436 59c mm/page_ext.o
>
> -Although, roughly, 8 KB code is added in total, page_alloc.o increase by
> -520 bytes and less than half of it is in hotpath. Building the kernel with
> +Although, roughly, 9 KB code is added in total, page_alloc.o increase by
> +632 bytes and less than half of it is in hotpath. Building the kernel with
> page owner and turning it on if needed would be great option to debug
> kernel memory problem.
This seems like a fine patch...but I do have to wonder if it really
makes sense to maintain this information, which will surely be subject
to frequent change. Perhaps the whole thing is better replaced with a
line saying that enabling page owner adds ~9KB?
Thanks,
jon
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Documentation/mm/page_owner.rst: update experimental data
2022-08-25 18:09 ` Jonathan Corbet
@ 2022-08-26 2:30 ` Bagas Sanjaya
2022-08-26 4:16 ` Mike Rapoport
0 siblings, 1 reply; 11+ messages in thread
From: Bagas Sanjaya @ 2022-08-26 2:30 UTC (permalink / raw)
To: Jonathan Corbet
Cc: Yixuan Cao, akpm, yejiajian2018, skhan, akiyks, rppt,
zhangyinan2019, linux-doc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1732 bytes --]
On Thu, Aug 25, 2022 at 12:09:35PM -0600, Jonathan Corbet wrote:
> > - Without page owner::
> >
> > text data bss dec hex filename
> > - 48392 2333 644 51369 c8a9 mm/page_alloc.o
> > + 58581 3166 652 62399 f3bf mm/page_alloc.o
> >
> > - With page owner::
> >
> > text data bss dec hex filename
> > - 48800 2445 644 51889 cab1 mm/page_alloc.o
> > - 6662 108 29 6799 1a8f mm/page_owner.o
> > - 1025 8 8 1041 411 mm/page_ext.o
> > + 59085 3294 652 63031 f637 mm/page_alloc.o
> > + 7464 125 28 7617 1dc1 mm/page_owner.o
> > + 1396 32 8 1436 59c mm/page_ext.o
> >
> > -Although, roughly, 8 KB code is added in total, page_alloc.o increase by
> > -520 bytes and less than half of it is in hotpath. Building the kernel with
> > +Although, roughly, 9 KB code is added in total, page_alloc.o increase by
> > +632 bytes and less than half of it is in hotpath. Building the kernel with
> > page owner and turning it on if needed would be great option to debug
> > kernel memory problem.
>
> This seems like a fine patch...but I do have to wonder if it really
> makes sense to maintain this information, which will surely be subject
> to frequent change. Perhaps the whole thing is better replaced with a
> line saying that enabling page owner adds ~9KB?
>
The size figure above is from size(1) from binutils, for which the
command is run (maybe) against vmlinux.
So I would like to say "Enabling page owner increases vmlinux size by
several kilobytes."
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Documentation/mm/page_owner.rst: update experimental data
2022-08-26 2:30 ` Bagas Sanjaya
@ 2022-08-26 4:16 ` Mike Rapoport
2022-10-05 9:10 ` [PATCH v2] Documentation/mm/page_owner.rst: delete frequently changing " Yixuan Cao
0 siblings, 1 reply; 11+ messages in thread
From: Mike Rapoport @ 2022-08-26 4:16 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: Jonathan Corbet, Yixuan Cao, akpm, yejiajian2018, skhan, akiyks,
zhangyinan2019, linux-doc, linux-kernel
On Fri, Aug 26, 2022 at 09:30:46AM +0700, Bagas Sanjaya wrote:
> On Thu, Aug 25, 2022 at 12:09:35PM -0600, Jonathan Corbet wrote:
> > > - Without page owner::
> > >
> > > text data bss dec hex filename
> > > - 48392 2333 644 51369 c8a9 mm/page_alloc.o
> > > + 58581 3166 652 62399 f3bf mm/page_alloc.o
> > >
> > > - With page owner::
> > >
> > > text data bss dec hex filename
> > > - 48800 2445 644 51889 cab1 mm/page_alloc.o
> > > - 6662 108 29 6799 1a8f mm/page_owner.o
> > > - 1025 8 8 1041 411 mm/page_ext.o
> > > + 59085 3294 652 63031 f637 mm/page_alloc.o
> > > + 7464 125 28 7617 1dc1 mm/page_owner.o
> > > + 1396 32 8 1436 59c mm/page_ext.o
> > >
> > > -Although, roughly, 8 KB code is added in total, page_alloc.o increase by
> > > -520 bytes and less than half of it is in hotpath. Building the kernel with
> > > +Although, roughly, 9 KB code is added in total, page_alloc.o increase by
> > > +632 bytes and less than half of it is in hotpath. Building the kernel with
> > > page owner and turning it on if needed would be great option to debug
> > > kernel memory problem.
> >
> > This seems like a fine patch...but I do have to wonder if it really
> > makes sense to maintain this information, which will surely be subject
> > to frequent change. Perhaps the whole thing is better replaced with a
> > line saying that enabling page owner adds ~9KB?
> >
>
> The size figure above is from size(1) from binutils, for which the
> command is run (maybe) against vmlinux.
>
> So I would like to say "Enabling page owner increases vmlinux size by
> several kilobytes."
Looks like original text tried to emphasize that there is no significant
change to page allocator code, and I think it's worth keeping it. E.g.
leaving something like
"Although, enabling page owner increases kernel size by several kilobytes,
most of this code is outside page allocator and its hot path."
instead of size(1) output and the sentences before and after it.
> Thanks.
>
> --
> An old man doll... just what I always wanted! - Clara
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] Documentation/mm/page_owner.rst: delete frequently changing experimental data
2022-08-26 4:16 ` Mike Rapoport
@ 2022-10-05 9:10 ` Yixuan Cao
2022-10-05 9:32 ` Bagas Sanjaya
0 siblings, 1 reply; 11+ messages in thread
From: Yixuan Cao @ 2022-10-05 9:10 UTC (permalink / raw)
To: rppt
Cc: akiyks, akpm, bagasdotme, caoyixuan2019, corbet, linux-doc,
linux-kernel, skhan, yejiajian2018, zhangyinan2019
Thanks for Jonathan Corbet, Bagas Sanjaya and Mike Rapoport's
constructive suggestions. Notice that the size(1) output is
changing frequently, I remove the two tables and describe them
in a general way. Doing so avoids having to repeatedly maintain
the two tables due to kernel changes.
Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
---
Documentation/mm/page_owner.rst | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/Documentation/mm/page_owner.rst b/Documentation/mm/page_owner.rst
index f18fd8907049..1b661ad85647 100644
--- a/Documentation/mm/page_owner.rst
+++ b/Documentation/mm/page_owner.rst
@@ -38,22 +38,10 @@ not affect to allocation performance, especially if the static keys jump
label patching functionality is available. Following is the kernel's code
size change due to this facility.
-- Without page owner::
-
- text data bss dec hex filename
- 48392 2333 644 51369 c8a9 mm/page_alloc.o
-
-- With page owner::
-
- text data bss dec hex filename
- 48800 2445 644 51889 cab1 mm/page_alloc.o
- 6662 108 29 6799 1a8f mm/page_owner.o
- 1025 8 8 1041 411 mm/page_ext.o
-
-Although, roughly, 8 KB code is added in total, page_alloc.o increase by
-520 bytes and less than half of it is in hotpath. Building the kernel with
-page owner and turning it on if needed would be great option to debug
-kernel memory problem.
+Although, enabling page owner increases kernel size by several kilobytes,
+most of this code is outside page allocator and its hot path. Building
+the kernel with page owner and turning it on if needed would be great
+option to debug kernel memory problem.
There is one notice that is caused by implementation detail. page owner
stores information into the memory from struct page extension. This memory
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2] Documentation/mm/page_owner.rst: delete frequently changing experimental data
2022-10-05 9:10 ` [PATCH v2] Documentation/mm/page_owner.rst: delete frequently changing " Yixuan Cao
@ 2022-10-05 9:32 ` Bagas Sanjaya
2022-10-05 11:38 ` [PATCH v3] " Yixuan Cao
2022-10-05 14:55 ` [PATCH v4] " Yixuan Cao
0 siblings, 2 replies; 11+ messages in thread
From: Bagas Sanjaya @ 2022-10-05 9:32 UTC (permalink / raw)
To: Yixuan Cao, rppt
Cc: akiyks, akpm, corbet, linux-doc, linux-kernel, skhan,
yejiajian2018, zhangyinan2019
On 10/5/22 16:10, Yixuan Cao wrote:
> Thanks for Jonathan Corbet, Bagas Sanjaya and Mike Rapoport's
> constructive suggestions. Notice that the size(1) output is
> changing frequently, I remove the two tables and describe them
> in a general way. Doing so avoids having to repeatedly maintain
> the two tables due to kernel changes.
>
For the patch description, better write:
"The kernel size changes due to many factors, such as compiler
version, configuration, and the build environment. This makes
size comparison figures irrelevant to reader's setup.
Remove these figures and describe the effects of page owner
to the kernel size in general instead."
> Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
> ---
> Documentation/mm/page_owner.rst | 20 ++++----------------
> 1 file changed, 4 insertions(+), 16 deletions(-)
>
> diff --git a/Documentation/mm/page_owner.rst b/Documentation/mm/page_owner.rst
> index f18fd8907049..1b661ad85647 100644
> --- a/Documentation/mm/page_owner.rst
> +++ b/Documentation/mm/page_owner.rst
> @@ -38,22 +38,10 @@ not affect to allocation performance, especially if the static keys jump
> label patching functionality is available. Following is the kernel's code
> size change due to this facility.
>
> -- Without page owner::
> -
> - text data bss dec hex filename
> - 48392 2333 644 51369 c8a9 mm/page_alloc.o
> -
> -- With page owner::
> -
> - text data bss dec hex filename
> - 48800 2445 644 51889 cab1 mm/page_alloc.o
> - 6662 108 29 6799 1a8f mm/page_owner.o
> - 1025 8 8 1041 411 mm/page_ext.o
> -
> -Although, roughly, 8 KB code is added in total, page_alloc.o increase by
> -520 bytes and less than half of it is in hotpath. Building the kernel with
> -page owner and turning it on if needed would be great option to debug
> -kernel memory problem.
> +Although, enabling page owner increases kernel size by several kilobytes,
> +most of this code is outside page allocator and its hot path. Building
> +the kernel with page owner and turning it on if needed would be great
> +option to debug kernel memory problem.
>
s/Although,/Although/
Thanks for reviewing.
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3] Documentation/mm/page_owner.rst: delete frequently changing experimental data
2022-10-05 9:32 ` Bagas Sanjaya
@ 2022-10-05 11:38 ` Yixuan Cao
2022-10-05 14:55 ` [PATCH v4] " Yixuan Cao
1 sibling, 0 replies; 11+ messages in thread
From: Yixuan Cao @ 2022-10-05 11:38 UTC (permalink / raw)
To: bagasdotme
Cc: akiyks, akpm, caoyixuan2019, corbet, linux-doc, linux-kernel,
rppt, skhan, yejiajian2018, zhangyinan2019
The kernel size changes due to many factors, such as compiler
version, configuration, and the build environment. This makes
size comparison figures irrelevant to reader's setup.
Remove these figures and describe the effects of page owner
to the kernel size in general instead.
Thanks for Jonathan Corbet, Bagas Sanjaya, Mike Rapoport and
Bagas Sanjaya's constructive suggestions.
Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
---
Documentation/mm/page_owner.rst | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/Documentation/mm/page_owner.rst b/Documentation/mm/page_owner.rst
index f18fd8907049..127514955a5e 100644
--- a/Documentation/mm/page_owner.rst
+++ b/Documentation/mm/page_owner.rst
@@ -38,22 +38,10 @@ not affect to allocation performance, especially if the static keys jump
label patching functionality is available. Following is the kernel's code
size change due to this facility.
-- Without page owner::
-
- text data bss dec hex filename
- 48392 2333 644 51369 c8a9 mm/page_alloc.o
-
-- With page owner::
-
- text data bss dec hex filename
- 48800 2445 644 51889 cab1 mm/page_alloc.o
- 6662 108 29 6799 1a8f mm/page_owner.o
- 1025 8 8 1041 411 mm/page_ext.o
-
-Although, roughly, 8 KB code is added in total, page_alloc.o increase by
-520 bytes and less than half of it is in hotpath. Building the kernel with
-page owner and turning it on if needed would be great option to debug
-kernel memory problem.
+Although enabling page owner increases kernel size by several kilobytes,
+most of this code is outside page allocator and its hot path. Building
+the kernel with page owner and turning it on if needed would be great
+option to debug kernel memory problem.
There is one notice that is caused by implementation detail. page owner
stores information into the memory from struct page extension. This memory
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v4] Documentation/mm/page_owner.rst: delete frequently changing experimental data
2022-10-05 9:32 ` Bagas Sanjaya
2022-10-05 11:38 ` [PATCH v3] " Yixuan Cao
@ 2022-10-05 14:55 ` Yixuan Cao
2022-10-06 1:46 ` Bagas Sanjaya
2022-10-10 18:54 ` [PATCH v4] " Jonathan Corbet
1 sibling, 2 replies; 11+ messages in thread
From: Yixuan Cao @ 2022-10-05 14:55 UTC (permalink / raw)
To: akpm
Cc: akiyks, corbet, linux-doc, linux-kernel, rppt, skhan,
yejiajian2018, zhangyinan2019, Yixuan Cao
The kernel size changes due to many factors, such as compiler
version, configuration, and the build environment. This makes
size comparison figures irrelevant to reader's setup.
Remove these figures and describe the effects of page owner
to the kernel size in general instead.
Thanks for Jonathan Corbet, Bagas Sanjaya and Mike Rapoport's
constructive suggestions.
Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
---
Documentation/mm/page_owner.rst | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/Documentation/mm/page_owner.rst b/Documentation/mm/page_owner.rst
index f18fd8907049..127514955a5e 100644
--- a/Documentation/mm/page_owner.rst
+++ b/Documentation/mm/page_owner.rst
@@ -38,22 +38,10 @@ not affect to allocation performance, especially if the static keys jump
label patching functionality is available. Following is the kernel's code
size change due to this facility.
-- Without page owner::
-
- text data bss dec hex filename
- 48392 2333 644 51369 c8a9 mm/page_alloc.o
-
-- With page owner::
-
- text data bss dec hex filename
- 48800 2445 644 51889 cab1 mm/page_alloc.o
- 6662 108 29 6799 1a8f mm/page_owner.o
- 1025 8 8 1041 411 mm/page_ext.o
-
-Although, roughly, 8 KB code is added in total, page_alloc.o increase by
-520 bytes and less than half of it is in hotpath. Building the kernel with
-page owner and turning it on if needed would be great option to debug
-kernel memory problem.
+Although enabling page owner increases kernel size by several kilobytes,
+most of this code is outside page allocator and its hot path. Building
+the kernel with page owner and turning it on if needed would be great
+option to debug kernel memory problem.
There is one notice that is caused by implementation detail. page owner
stores information into the memory from struct page extension. This memory
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v4] Documentation/mm/page_owner.rst: delete frequently changing experimental data
2022-10-05 14:55 ` [PATCH v4] " Yixuan Cao
@ 2022-10-06 1:46 ` Bagas Sanjaya
2022-10-06 4:05 ` [PATCH v5] " Yixuan Cao
2022-10-10 18:54 ` [PATCH v4] " Jonathan Corbet
1 sibling, 1 reply; 11+ messages in thread
From: Bagas Sanjaya @ 2022-10-06 1:46 UTC (permalink / raw)
To: Yixuan Cao, akpm
Cc: akiyks, corbet, linux-doc, linux-kernel, rppt, skhan,
yejiajian2018, zhangyinan2019
On 10/5/22 21:55, Yixuan Cao wrote:
> The kernel size changes due to many factors, such as compiler
> version, configuration, and the build environment. This makes
> size comparison figures irrelevant to reader's setup.
>
> Remove these figures and describe the effects of page owner
> to the kernel size in general instead.
>
> Thanks for Jonathan Corbet, Bagas Sanjaya and Mike Rapoport's
> constructive suggestions.
>
The credits paragraph above can be removed (should be between
dash line and diffstat).
Otherwise LGTM.
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v5] Documentation/mm/page_owner.rst: delete frequently changing experimental data
2022-10-06 1:46 ` Bagas Sanjaya
@ 2022-10-06 4:05 ` Yixuan Cao
0 siblings, 0 replies; 11+ messages in thread
From: Yixuan Cao @ 2022-10-06 4:05 UTC (permalink / raw)
To: bagasdotme
Cc: akiyks, akpm, caoyixuan2019, corbet, linux-doc, linux-kernel,
rppt, skhan, yejiajian2018, zhangyinan2019
The kernel size changes due to many factors, such as compiler
version, configuration, and the build environment. This makes
size comparison figures irrelevant to reader's setup.
Remove these figures and describe the effects of page owner
to the kernel size in general instead.
Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
---
Documentation/mm/page_owner.rst | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/Documentation/mm/page_owner.rst b/Documentation/mm/page_owner.rst
index f18fd8907049..127514955a5e 100644
--- a/Documentation/mm/page_owner.rst
+++ b/Documentation/mm/page_owner.rst
@@ -38,22 +38,10 @@ not affect to allocation performance, especially if the static keys jump
label patching functionality is available. Following is the kernel's code
size change due to this facility.
-- Without page owner::
-
- text data bss dec hex filename
- 48392 2333 644 51369 c8a9 mm/page_alloc.o
-
-- With page owner::
-
- text data bss dec hex filename
- 48800 2445 644 51889 cab1 mm/page_alloc.o
- 6662 108 29 6799 1a8f mm/page_owner.o
- 1025 8 8 1041 411 mm/page_ext.o
-
-Although, roughly, 8 KB code is added in total, page_alloc.o increase by
-520 bytes and less than half of it is in hotpath. Building the kernel with
-page owner and turning it on if needed would be great option to debug
-kernel memory problem.
+Although enabling page owner increases kernel size by several kilobytes,
+most of this code is outside page allocator and its hot path. Building
+the kernel with page owner and turning it on if needed would be great
+option to debug kernel memory problem.
There is one notice that is caused by implementation detail. page owner
stores information into the memory from struct page extension. This memory
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v4] Documentation/mm/page_owner.rst: delete frequently changing experimental data
2022-10-05 14:55 ` [PATCH v4] " Yixuan Cao
2022-10-06 1:46 ` Bagas Sanjaya
@ 2022-10-10 18:54 ` Jonathan Corbet
1 sibling, 0 replies; 11+ messages in thread
From: Jonathan Corbet @ 2022-10-10 18:54 UTC (permalink / raw)
To: Yixuan Cao, akpm
Cc: akiyks, linux-doc, linux-kernel, rppt, skhan, yejiajian2018,
zhangyinan2019, Yixuan Cao
Yixuan Cao <caoyixuan2019@email.szu.edu.cn> writes:
> The kernel size changes due to many factors, such as compiler
> version, configuration, and the build environment. This makes
> size comparison figures irrelevant to reader's setup.
>
> Remove these figures and describe the effects of page owner
> to the kernel size in general instead.
>
> Thanks for Jonathan Corbet, Bagas Sanjaya and Mike Rapoport's
> constructive suggestions.
>
> Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
> ---
> Documentation/mm/page_owner.rst | 20 ++++----------------
> 1 file changed, 4 insertions(+), 16 deletions(-)
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-10-10 18:55 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-25 17:29 [PATCH] Documentation/mm/page_owner.rst: update experimental data Yixuan Cao
2022-08-25 18:09 ` Jonathan Corbet
2022-08-26 2:30 ` Bagas Sanjaya
2022-08-26 4:16 ` Mike Rapoport
2022-10-05 9:10 ` [PATCH v2] Documentation/mm/page_owner.rst: delete frequently changing " Yixuan Cao
2022-10-05 9:32 ` Bagas Sanjaya
2022-10-05 11:38 ` [PATCH v3] " Yixuan Cao
2022-10-05 14:55 ` [PATCH v4] " Yixuan Cao
2022-10-06 1:46 ` Bagas Sanjaya
2022-10-06 4:05 ` [PATCH v5] " Yixuan Cao
2022-10-10 18:54 ` [PATCH v4] " Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).