* [PATCH v6 0/1] Fixup instructions around mailing recipients
@ 2022-10-06 16:24 Bryan O'Donoghue
2022-10-06 16:24 ` [PATCH v6] Documentation/process: Be more explicit about who to mail on patch submission Bryan O'Donoghue
0 siblings, 1 reply; 2+ messages in thread
From: Bryan O'Donoghue @ 2022-10-06 16:24 UTC (permalink / raw)
To: corbet, linux, konstantin, krzysztof.kozlowski, linux-doc, joe
Cc: linux-kernel, Bryan O'Donoghue
V6:
- Drops distinction between dedicated and non-dedicated mailing lists
- I appreciate Akria's concern on keeping the text concise but OTOH I think
we should call out supporters and reviewers as well as the mailing
list(s) produced by get_maintainer as mail addresses which ought to be
mailed.
A little bit of extra text should hopefully help others get the right
list of recipients, with the least amount of additional text added as
possible.
V5:
- Drops get_maintainer.pl removal of supporter - Joe Perches
- Back to one standalone Documentation change - Krzysztof's suggested list
RESEND:
+ Akira
V4:
- Change the subject line of the series
Previous: Expand get_maintainer to be explicit about supporters
https://lore.kernel.org/all/20220930064629.329514-1-bryan.odonoghue@linaro.org/t/
- Update get_maintainer.pl to return "maintainer" for both "S: Supported"
and "S: Maintained" - Theodore Tso
For the purposes of sending a patch whether or not the maintainer is
listed as volunteer or paid is not really useful information.
Listing both as "maintainer" is clearer the end user.
- Incorporate Krzysztof's list of recipients into
Documentation/process/submitting-patches.rst.
- I didn't include the get_mainainter.pl example.
Comments from both Akira and Joe suggest to me the example is not that
useful.
- get_maintainer will no longer produce "supporter" so one could argue that
the documentation shouldn't refer to supporters however not all of the
potential output strings are documented and I've opted not to document
"chief penguin" either.
I'd like to focus on the particular case of supporters with some
reasonable knock-on documentation tweaks for the obvious gaps we've
identified in our discussion because "supporter" really means
"maintainer" and you absolutely have to mail that person to get your
patch into the right inbox.
V3:
- Drops change to get_maintainer.pl - Theodore
- Rewords around `get_maintainer --nogit-fallback` and gives an example
I think the document text now is clearer and should be more helpful to
others in getting their minimum submission list right every time.
V2:
https://lore.kernel.org/lkml/20220928003006.230103-1-bryan.odonoghue@linaro.org/T/#u
- Documentation/process
Added in text to also make clear subsystem mailing list should be
included - Krzysztof
- Changed get_maintainer.pl to print maintainer[supporter] or
maintainer[volunteer] depending on MAINTAINERS file. - Thorsten/Bryan
- Choose supporter and volunteer instead of supported and volunteer
Supporter and volunteer describe the role of the person whereas supported
and volunteer would describe an activity and a role which isn't
consistent. - Thorsten/Bryan
- I didn't change Documentation/process/5.Posting.rst
This file doesn't mention get_maintainer.pl and I was mostly aiming to
fixup the process around get_maintainer.pl. - Thorsten
- Myself and Thorsten discussed changing get_maintainer.pl, how it seems
like a desirable thing to do but also that "it might break scripts for
people" and it might.
I don't know if get_maintainer.pl is or should be considered to be a
stable interface and an explicit software contract but, making it clear a
supporter is also a maintainer seems like the right thing to do from a
transmission of information perspective.
There is still the option of just updating Documentation/process in
isolation.
V1:
- Sent a standalone change to Documentation/process stating
get_maintainer.pl email addresses marked "supporter" should be included
in a patch run.
Bryan O'Donoghue (1):
Documentation/process: Be more explicit about who to mail on patch
submission
Documentation/process/submitting-patches.rst | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
--
2.37.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v6] Documentation/process: Be more explicit about who to mail on patch submission
2022-10-06 16:24 [PATCH v6 0/1] Fixup instructions around mailing recipients Bryan O'Donoghue
@ 2022-10-06 16:24 ` Bryan O'Donoghue
0 siblings, 0 replies; 2+ messages in thread
From: Bryan O'Donoghue @ 2022-10-06 16:24 UTC (permalink / raw)
To: corbet, linux, konstantin, krzysztof.kozlowski, linux-doc, joe
Cc: linux-kernel, Bryan O'Donoghue
Recently when submitting a yaml change I found that I had omitted the
maintainer whose tree the change needed to go through.
The reason for that is the path in MAINTAINERS is marked as Supported not
Maintained. Reading MAINTAINERS we see quote:
Supported: Someone is actually paid to look after this.
Maintained: Someone actually looks after it.
The current submitting-patches.rst only says to mail maintainers though not
supporters. Discussing further on the list the suggestion was made to state
that the following are the right addresses to mail:
- Maintainers
- Supporters
- Reviewers
- Mailing lists
Add in a sentence to capture that statement.
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
Documentation/process/submitting-patches.rst | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
index be49d8f2601b4..a56e10811e8de 100644
--- a/Documentation/process/submitting-patches.rst
+++ b/Documentation/process/submitting-patches.rst
@@ -227,9 +227,11 @@ You should always copy the appropriate subsystem maintainer(s) on any patch
to code that they maintain; look through the MAINTAINERS file and the
source code revision history to see who those maintainers are. The
script scripts/get_maintainer.pl can be very useful at this step (pass paths to
-your patches as arguments to scripts/get_maintainer.pl). If you cannot find a
-maintainer for the subsystem you are working on, Andrew Morton
-(akpm@linux-foundation.org) serves as a maintainer of last resort.
+your patches as arguments to scripts/get_maintainer.pl). If you are using
+scripts/get_maintainer.pl it is a good idea to mail every maintainer, supporter,
+reviewer and mailing list given. If you cannot find a maintainer for the
+subsystem you are working on, Andrew Morton (akpm@linux-foundation.org) serves
+as a maintainer of last resort.
You should also normally choose at least one mailing list to receive a copy
of your patch set. linux-kernel@vger.kernel.org should be used by default
--
2.37.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-06 16:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-06 16:24 [PATCH v6 0/1] Fixup instructions around mailing recipients Bryan O'Donoghue
2022-10-06 16:24 ` [PATCH v6] Documentation/process: Be more explicit about who to mail on patch submission Bryan O'Donoghue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).